Update Configure-Netsuite.md with formatted changes#56888
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@eh2077 @ @flaviadefaria One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://4eac96c0.helpdot.pages.dev ⚡️ |
|
I've completed the remainder of the requirements |
I don't know if this is accurate but I couldn't see a place to use NetSuite to automate workflow configuration, so I've left this as it is. |
flaviadefaria
left a comment
There was a problem hiding this comment.
Suggested two changes!
This comment was marked as resolved.
This comment was marked as resolved.
|
Reviewing this morning, once I'm out of my Figma call. |
Suggesting some new changes to formatting and wording. Very minor stuff.
strepanier03
left a comment
There was a problem hiding this comment.
Requested some very minor changes; formating and grammar relatd.
|
Oh dang, I thought I was requesting some changes but I think I just made the changes myself 🤦♀️ I'm sorry about that. I will learn the proper way to request changes moving forward. |
|
I think I'm still waiting on approval - there don't seem to be any changes left |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@blimpich @zanyrenney One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I did the checks! |
|
@blimpich please can you merge!? |
Dismissing this review because according to this comment it seems like the changes have already been made, we just haven't updated this review: #56888 (review)
strepanier03
left a comment
There was a problem hiding this comment.
These all look good to me, thank you!
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.7-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.7-2 🚀
|


Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/463224
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop