Fix PDF files shadow by rezkiy37 · Pull Request #57185 · Expensify/App

rezkiy37 · 2025-02-20T14:56:30Z

Explanation of Change

The PR fixes the grey line that appears when the app loads a PDF file. Also, the line is visible during the fast scroll via the scrollbar.

Fixed Issues

$ #55671
PROPOSAL: #55671 (comment)

Tests

Open any chat and send PDF files.
Click on the PDF thumbnail to open a preview
Verify that the PDF file has been loaded without any gray lines.
Scroll fast or via the scrollbar.
Verify that the PDF file pages have been loaded without any gray lines.

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Both.mp4

Single.mp4

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…/55671-pdf-shadow

rezkiy37 · 2025-02-25T12:35:31Z

I've synced it up.

melvin-bot · 2025-02-25T16:29:34Z

@rayane-d Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2025-02-25T16:38:23Z

Videos are looking good to me.

assets/css/pdf.css

…/55671-pdf-shadow

shawnborton · 2025-02-26T17:08:54Z

Awesome, looks good to me - thanks for updating!

assets/css/pdf.css

shawnborton · 2025-02-27T16:20:13Z

@rayane-d all you!

…/55671-pdf-shadow

rezkiy37 · 2025-02-27T16:32:42Z

I've synced it up.

…/55671-pdf-shadow

rezkiy37 · 2025-03-03T10:51:16Z

I've synced it up.

rayane-d · 2025-03-03T10:53:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-03.at.3.47.33.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-03.at.3.11.12.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.15.28.57.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.15.29.18.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.15.12.55.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.14.57.08.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-03.at.2.49.14.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-03.at.2.50.27.PM.mov

rayane-d · 2025-03-03T14:20:21Z

@rezkiy37 @Expensify/design There is a difference in the shadows between mWeb Safari and mWeb Chrome:

mWeb Safari	mWeb Chrome

@Expensify/design Is this difference acceptable? I don’t understand why there’s a discrepancy since we’re applying the same styles. Any ideas, @rezkiy37? I suspect it might be platform-related.

rayane-d · 2025-03-03T14:51:32Z

cc @Expensify/design

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-03.at.3.47.33.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-03.at.3.11.12.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.15.28.57.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.15.29.18.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.15.12.55.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-03.at.14.57.08.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-03.at.2.49.14.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-03.at.2.50.27.PM.mov

rezkiy37 · 2025-03-03T15:37:14Z

@rayane-d, yes, the difference in shadow appearance between mobile Safari (mWeb Safari) and mobile Chrome (mWeb Chrome) can be platform-related. Several factors could be causing this issue: Different Rendering Engines, Differences in CSS Shadow Rendering, Pixel Density & Rendering Differences, and Color Management Differences. I can try to align them if it is not acceptable by @Expensify/design.

shawnborton · 2025-03-03T17:31:00Z

I think as long as the CSS values are truly identical, then we're good. But visually it does seem like a bigger difference than I would expect. Do we need to do any kind of weird `webkit resetting or anything via CSS?

dannymcclain · 2025-03-03T18:10:10Z

I think as long as the CSS values are truly identical, then we're good.

I feel the same. It might be nice to understand why they're so different, but I think as long as the values are the same on our end, it's fine.

rezkiy37 · 2025-03-03T18:15:06Z

Well, I am figuring it out! Let you know soon.

rezkiy37 · 2025-03-04T12:56:53Z

Yes, the shadow difference between mWeb Safari and mWeb Chrome can be a platform-related issue due to differences in rendering engines. Safari (WebKit) and Chrome (Blink on Android) handle box-shadow differently, affecting blur, spread, and anti-aliasing. Additionally, Safari applies color profiles more aggressively, which can alter shadow appearance. Device pixel ratio and subpixel rendering also contribute to these inconsistencies. Moreover, we usually face it with native applications as well.

Screenshots

dannymcclain · 2025-03-04T13:37:49Z

The screenshots you just posted look very similar to me. I'd be in favor of rolling with it.

rayane-d

LGTM

melvin-bot · 2025-03-04T13:41:54Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #55671 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

rayane-d

@amyevans all yours!

shawnborton · 2025-03-04T14:35:26Z

Right on, works for me and thanks for the detailed explanation!

amyevans

🚀

OSBotify · 2025-03-04T15:13:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-04T22:09:01Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-04T22:52:08Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-06T22:55:27Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Remove shadow image and update PDF styles for improved rendering

e324196

rezkiy37 mentioned this pull request Feb 20, 2025

[Due for payment 2025-03-13] [$250] Attachments-PDF preview loads with delay, the grey line shown first #55671

Closed

8 tasks

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

6606f5c

…/55671-pdf-shadow

rezkiy37 changed the title ~~[WIP] Fix PDF files shadow~~ Fix PDF files shadow Feb 25, 2025

rezkiy37 marked this pull request as ready for review February 25, 2025 16:29

rezkiy37 requested review from a team as code owners February 25, 2025 16:29

melvin-bot bot requested review from rayane-d and removed request for a team February 25, 2025 16:29

shawnborton reviewed Feb 25, 2025

View reviewed changes

assets/css/pdf.css Outdated Show resolved Hide resolved

rayane-d suggested changes Feb 25, 2025

View reviewed changes

assets/css/pdf.css Outdated Show resolved Hide resolved

rezkiy37 added 2 commits February 26, 2025 08:40

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

869e3ef

…/55671-pdf-shadow

Update PDF canvas box-shadow and add dark mode support

9f52e80

rezkiy37 requested review from rayane-d and shawnborton February 26, 2025 10:45

shawnborton reviewed Feb 26, 2025

View reviewed changes

assets/css/pdf.css Show resolved Hide resolved

rezkiy37 requested a review from shawnborton February 27, 2025 08:21

koko57 mentioned this pull request Feb 27, 2025

fix: bump react-fast-pdf version #57382

Merged

50 tasks

shawnborton approved these changes Feb 27, 2025

View reviewed changes

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

05b3e23

…/55671-pdf-shadow

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

25b4ce0

…/55671-pdf-shadow

rayane-d approved these changes Mar 4, 2025

View reviewed changes

melvin-bot bot requested a review from amyevans March 4, 2025 13:44

amyevans approved these changes Mar 4, 2025

View reviewed changes

amyevans merged commit c406bee into Expensify:main Mar 4, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 4, 2025

Deploy Checklist: New Expensify 2025-03-04 #57792

Closed

77 tasks

mitarachim mentioned this pull request Mar 5, 2025

Android Hybrid-Attachment- It is hard to scroll the pdf file #57823

Closed

8 tasks

Conversation

rezkiy37 commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

rezkiy37 commented Feb 25, 2025

Uh oh!

melvin-bot bot commented Feb 25, 2025

Uh oh!

dannymcclain commented Feb 25, 2025

Uh oh!

Uh oh!

Uh oh!

shawnborton commented Feb 26, 2025

Uh oh!

Uh oh!

shawnborton commented Feb 27, 2025

Uh oh!

rezkiy37 commented Feb 27, 2025

Uh oh!

rezkiy37 commented Mar 3, 2025

Uh oh!

rayane-d commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d commented Mar 3, 2025

Uh oh!

rayane-d commented Mar 3, 2025

Screenshots/Videos

Uh oh!

rezkiy37 commented Mar 3, 2025

Uh oh!

shawnborton commented Mar 3, 2025

Uh oh!

dannymcclain commented Mar 3, 2025

Uh oh!

rezkiy37 commented Mar 3, 2025

Uh oh!

rezkiy37 commented Mar 4, 2025

Uh oh!

dannymcclain commented Mar 4, 2025

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 4, 2025

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Mar 4, 2025

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rezkiy37 commented Feb 20, 2025 •

edited

Loading

rayane-d commented Mar 3, 2025 •

edited

Loading