Update helpdot links in flow to add company cards by allgandalf · Pull Request #57239 · Expensify/App

allgandalf · 2025-02-21T10:17:53Z

Explanation of Change

Problem
The hyperlinks to HelpDot in the flow to add company cards go to the Expensify Classic resources. We did this intentionally during implementation because we hadn't yet created New Expensify resources. However, they now exist, so these hyperlinks are incorrect.

Solution
Update the hyperlinks in the add company cards flow to go to New Expensify resources.

Fixed Issues

$ #56494
PROPOSAL: https://expensify.slack.com/archives/C07UR5Q5PT7/p1740132359754869

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to workspace > Company cards page > Click on add cards
Select any feed,
Verify that options hyperlink to go to https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

Verify that Amex corporate cards this help article to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-an-american-express-corporate-feed

Amex delivery file

Verify that Where do I find the delivery file name? hyperlinks to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-an-american-express-corporate-feed

Verify that Mastercard commercial cards
this help article redirects to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-mastercard-commercial-feed

contact your bank redirects to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-mastercard-commercial-feed

Mastercard distribution ID

Where do I find the distribution ID? redirects to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-a-mastercard-commercial-feed

Visa commercial cards

this help article redirects to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-visa-commercial-feed

contact your bank redirects to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-visa-commercial-feed

Visa feed details

Where do I find these IDs? redirects to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-a-visa-commercial-feed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-02-21T11:04:31Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-02-21T11:04:44Z

@c3024 please ignore the ping, this one is No QA

allgandalf · 2025-02-21T11:04:49Z

✅ Amex

Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

✅ Amex corporate cards

Update this help article to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-an-american-express-corporate-feed

✅ Amex delivery file

Update Where do I find the delivery file name? to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-an-american-express-corporate-feed

✅ Bank of America

Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

✅ Capital One

Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

✅ Chase

Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

✅ Citibank

Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

✅ Wells Fargo

Update options hyperlink to go to: https://help.expensify.com/new-expensify/hubs/connect-credit-cards/

✅ Mastercard commercial cards

Update this help article to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-mastercard-commercial-feed
Update contact your bank to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-mastercard-commercial-feed

✅ Mastercard distribution ID

Update Where do I find the distribution ID? to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-a-mastercard-commercial-feed

✅ Visa commercial cards

Update this help article to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-visa-commercial-feed
Update contact your bank to https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#how-to-set-up-a-visa-commercial-feed

✅ Visa feed details

Update Where do I find these IDs? to: https://help.expensify.com/articles/new-expensify/connect-credit-cards/company-cards/Commercial-feeds#steps-to-add-a-visa-commercial-feed

allgandalf · 2025-02-21T11:05:12Z

@mountiny all yours 🙇

mountiny · 2025-02-21T15:12:06Z

@allgandalf can you add tests for the QA in staging?

allgandalf · 2025-02-25T06:01:21Z

Missed the ping, updating now

allgandalf · 2025-02-25T08:43:02Z

We're good to merge here!

mountiny · 2025-02-25T09:09:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mountiny

Thanks!

OSBotify · 2025-02-25T09:46:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-26T00:23:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-26T10:43:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-26T22:41:13Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.6-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

update for Amex

513a857

allgandalf changed the title ~~update for Amex~~ Update helpdot links in flow to add company cards Feb 21, 2025

allgandalf added 6 commits February 21, 2025 15:55

Amex corporate cards

508418d

Amex delivery file

5e1f4ac

Mastercard commercial cards

7c7c1a3

Mastercard distribution ID & Visa commercial cards

55372d5

Visa feed details

1aad8a4

fix prettier and add spanish link redirects

08cd691

allgandalf marked this pull request as ready for review February 21, 2025 11:04

allgandalf requested a review from a team as a code owner February 21, 2025 11:04

melvin-bot bot requested review from c3024 and removed request for a team February 21, 2025 11:04

allgandalf changed the title ~~Update helpdot links in flow to add company cards~~ [No QA] Update helpdot links in flow to add company cards Feb 21, 2025

mountiny assigned allgandalf Feb 21, 2025

allgandalf changed the title ~~[No QA] Update helpdot links in flow to add company cards~~ Update helpdot links in flow to add company cards Feb 25, 2025

mountiny removed the request for review from c3024 February 25, 2025 09:09

mountiny approved these changes Feb 25, 2025

View reviewed changes

mountiny merged commit e9359f1 into Expensify:main Feb 25, 2025
19 checks passed

github-actions bot mentioned this pull request Feb 25, 2025

Deploy Checklist: New Expensify 2025-02-25 #57435

Closed

49 tasks

melvin-bot bot mentioned this pull request Feb 26, 2025

[Due for payment 2025-03-05] [$125] Update helpdot links in flow to add company cards #56494

Closed

Conversation

allgandalf commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 21, 2025

Uh oh!

allgandalf commented Feb 21, 2025

Uh oh!

allgandalf commented Feb 21, 2025

Uh oh!

allgandalf commented Feb 21, 2025

Uh oh!

mountiny commented Feb 21, 2025

Uh oh!

allgandalf commented Feb 25, 2025

Uh oh!

allgandalf commented Feb 25, 2025

Uh oh!

mountiny commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

allgandalf commented Feb 21, 2025 •

edited

Loading

mountiny commented Feb 25, 2025 •

edited

Loading