Refactor getTrackExpenseInformation function by mkzie2 · Pull Request #57316 · Expensify/App

mkzie2 · 2025-02-24T04:12:46Z

Explanation of Change

Refactor getTrackExpenseInformation function

Fixed Issues

$ #57190
PROPOSAL: #57190 (comment)

Tests

Login to an account with selfDM
Create a track expense
Verify that the track expense is created without issue
Categorize the track expense
Verify that it's moved successfully

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Login to an account with selfDM
Create a track expense
Verify that the track expense is created without issue
Categorize the track expense
Verify that it's moved successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-24.at.11.07.28.mov

Android: mWeb Chrome

Screen.Recording.2025-02-24.at.11.00.44.mov

iOS: Native

Screen.Recording.2025-02-24.at.11.08.49.mov

iOS: mWeb Safari

Screen.Recording.2025-02-24.at.11.01.36.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-24.at.10.58.51.mov

MacOS: Desktop

Screen.Recording.2025-02-24.at.11.04.42.mov

melvin-bot · 2025-02-24T04:38:43Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/IOU.ts

mkzie2 · 2025-02-25T05:27:13Z

@s77rt I updated, please help to check again.

src/libs/actions/IOU.ts

s77rt · 2025-02-25T10:44:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

neil-marcellini

One small request but otherwise looks great

neil-marcellini · 2025-02-25T19:03:11Z

src/libs/actions/IOU.ts

+type GetTrackExpenseInformationPolicyParams = {
+    policy?: OnyxEntry<OnyxTypes.Policy>;
+    policyTagList?: OnyxEntry<OnyxTypes.PolicyTagLists>;
+    policyCategories?: OnyxEntry<OnyxTypes.PolicyCategories>;
+};


Can we re-use RequestMoneyPolicyParams? Perhaps we could rename that type to be more generic?

App/src/libs/actions/IOU.ts

Lines 346 to 350 in 23ac11f

type RequestMoneyPolicyParams = {

policy?: OnyxEntry<OnyxTypes.Policy>;

policyTagList?: OnyxEntry<OnyxTypes.PolicyTagLists>;

policyCategories?: OnyxEntry<OnyxTypes.PolicyCategories>;

};

@neil-marcellini I updated the RequestMoneyPolicyParams name and use it here.

OSBotify · 2025-02-26T16:36:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-26T23:04:24Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.7-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-03T16:44:07Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.7-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

refactor getTrackExpenseInformation function

d89d8cc

mkzie2 marked this pull request as ready for review February 24, 2025 04:38

mkzie2 requested a review from a team as a code owner February 24, 2025 04:38

melvin-bot bot requested review from s77rt and removed request for a team February 24, 2025 04:38

mkzie2 mentioned this pull request Feb 24, 2025

[Due for payment 2025-03-10] [$125] Refactor getTrackExpenseInformation to use a parameter object #57190

Closed

s77rt suggested changes Feb 24, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Show resolved Hide resolved

mkzie2 added 2 commits February 25, 2025 12:13

reuse existing type

ea50d6c

Merge branch 'main' into mkzie2-issue/57190

aeb9c98

s77rt suggested changes Feb 25, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

mkzie2 added 2 commits February 25, 2025 16:30

update type

817bf52

add new type for policy params

23ac11f

s77rt approved these changes Feb 25, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini February 25, 2025 10:45

neil-marcellini requested changes Feb 25, 2025

View reviewed changes

mkzie2 added 2 commits February 26, 2025 17:44

Merge branch 'main' into mkzie2-issue/57190

f2d1a2d

update policy param type name

00b184f

neil-marcellini approved these changes Feb 26, 2025

View reviewed changes

neil-marcellini merged commit 7215156 into Expensify:main Feb 26, 2025
17 checks passed

github-actions bot mentioned this pull request Feb 26, 2025

Deploy Checklist: New Expensify 2025-02-26 #57504

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor getTrackExpenseInformation function#57316

Refactor getTrackExpenseInformation function#57316
neil-marcellini merged 7 commits intoExpensify:mainfrom
mkzie2:mkzie2-issue/57190

mkzie2 commented Feb 24, 2025

Uh oh!

melvin-bot bot commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

mkzie2 commented Feb 25, 2025

Uh oh!

Uh oh!

s77rt commented Feb 25, 2025

Uh oh!

neil-marcellini left a comment

Uh oh!

neil-marcellini Feb 25, 2025

Uh oh!

mkzie2 Feb 26, 2025

Uh oh!

Uh oh!

OSBotify commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	type RequestMoneyPolicyParams = {
	policy?: OnyxEntry<OnyxTypes.Policy>;
	policyTagList?: OnyxEntry<OnyxTypes.PolicyTagLists>;
	policyCategories?: OnyxEntry<OnyxTypes.PolicyCategories>;
	};

Conversation

mkzie2 commented Feb 24, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

mkzie2 commented Feb 25, 2025

Uh oh!

Uh oh!

s77rt commented Feb 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

mkzie2 Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 26, 2025

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants