Fix: Handle unsupported videos in iOS by HezekielT · Pull Request #57353 · Expensify/App

HezekielT · 2025-02-24T22:44:11Z

Explanation of Change

This PR adds a video error indicator that will be shown when a user tries to play videos with av1 codec on iOS which are not currently fully supported by apple.

Fixed Issues

$ #52673
PROPOSAL: #52673 (comment)

Tests

Open any report and send a video with AV1 codec

Here is a sample video for testing purpose - https://github.com/user-attachments/assets/2b502b64-83c3-4b81-bc7b-b57cf6892ab0

Play the video.

On Supported devices such as android native, chrome and Macbook pro M3 macOS safari

Verify the video plays as expected.

For iOS native and iOS: mweb Safari

Verify that
- a slashed video is shown as placeholder for video previews or
- a slashed video with an error message that says An error occurred while trying to play this video. for videos that are inside attachment modal indicating that the video is not playable.

Slashed Video Example

Screenshot 2025-03-02 at 10 42 58 at night

Verify that no errors appear in the JS console

Offline tests

An internet connection is required to load the video.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native_av1.mp4

Android: mWeb Chrome

mweb_chrome_av1_final.mov

iOS: Native

av1_ios_native.mp4

iOS: mWeb Safari

av1_ios_mweb_safari.mov

MacOS: Chrome / Safari

web_safari_av1_codec.mov

MacOS: Desktop

desktop_av1.mp4

…ormats

github-actions · 2025-02-24T22:44:22Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

github-actions · 2025-02-25T13:31:13Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

melvin-bot · 2025-02-25T13:32:44Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-02-25T14:10:10Z

Did you ever have an official mockup for this? This doesn't feel very good:

I would think we:

wouldn't use a different background color
we would use some kind of text below to explain why the video can't be played

shawnborton · 2025-02-25T14:10:15Z

cc @Expensify/design for vis

github-actions · 2025-02-25T14:15:55Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

HezekielT · 2025-02-25T14:19:23Z

Did you ever have an official mockup for this? This doesn't feel very good:

@shawnborton I used the svg that was shared here in the issue

shawnborton · 2025-02-25T14:21:21Z

Yes, but I think you missed the mockup here. Can you please re-review? Thanks!

HezekielT · 2025-02-25T14:27:42Z

@shawnborton Sorry if I'm mistaken but I assumed the conclusion was to only show the icon based on this two comments. comment one and comment two. Sorry, if we want the text to be shown, I will try to update it.

dannymcclain · 2025-02-25T14:28:17Z

🫣 It was after that mock up that there was some trouble implementing the text in that view, so I suggested just using the icon, and you and Jon agreed it would be ok. 😬

Do we need to revisit that?

shawnborton · 2025-02-25T14:31:56Z

I thought that was in reference to the icon being enough just for the attachment preview area? I could be mistaken though. I thought that when you actually view the attachment in the modal, we would still show it...

HezekielT · 2025-03-07T09:34:44Z

can we make the text here use our textSupporting color? cc @Expensify/design for gut check

Yes, we can use textSupporting color. Should I go ahead and push the changes to the PR, or should we wait for the design team to verify first? @shawnborton

shawnborton · 2025-03-07T09:38:12Z

I say go ahead and push, this is something that we have historically agreed upon so I like our chances 🤣 and if not, I will deal with the ensuing wrath.

github-actions · 2025-03-07T09:48:09Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

hoangzinh · 2025-03-07T13:25:07Z

@hoangzinh can you help me with this comment?

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

sure @HezekielT. Let me ask other people.

hoangzinh · 2025-03-07T14:10:04Z

Hi @puneetlath, can you help to trigger an AdHoc build for Hybrid here? Thank you.

hoangzinh · 2025-03-07T14:10:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native Standalone

Screen.Recording.2025-03-07.at.21.12.31.android.mov

Android: Native Hybrid

Screen.Recording.2025-03-07.at.21.05.17.android.hybrid.mov

Android: mWeb Chrome

Screen.Recording.2025-03-07.at.21.07.36.android.chrome.mov

iOS: Native Standalone

Screen.Recording.2025-03-07.at.21.16.15.ios.mov

iOS: Native Hybrid

Screen.Recording.2025-03-07.at.20.46.32.ios.hybrid.mov

iOS: mWeb Safari

Screen.Recording.2025-03-07.at.20.59.05.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-07.at.20.45.09.web.mov

MacOS: Desktop

Screen.Recording.2025-03-07.at.20.48.19.desktop.mov

shawnborton · 2025-03-07T14:10:59Z

I can fire one up quickly 🚀

github-actions · 2025-03-07T14:11:30Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-07T14:15:10Z

🚧 @puneetlath has triggered a test app build. You can view the workflow run here.

hoangzinh · 2025-03-07T14:15:54Z

Thank you @shawnborton and @puneetlath

dannymcclain · 2025-03-07T14:16:39Z

As predicted, I agree with Shawn's comment earlier! 😁

github-actions · 2025-03-07T14:46:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57353/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57353/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
N/A	N/A
N/A	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

hoangzinh

LGTM. Tested on both Hybrid and Standalone apps

OSBotify · 2025-03-07T18:10:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-10T21:35:28Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.1.11-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

HezekielT · 2025-03-12T15:10:35Z

@puneetlath @hoangzinh I forgot to mention it, but I wanted to state that the upstream PR to expo-av has been approved 🎉 🎉

puneetlath · 2025-03-12T15:17:34Z

Awesome!

github-actions · 2025-03-14T01:06:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

…dle-unsupported-video-formats" This reverts commit d01c94e, reversing changes made to 5466c1d.

HezekielT and others added 12 commits February 24, 2025 14:30

added video slash svg

d34415b

style change in AttachmentOfflineIndicator

cc1484d

include video slash in Expensicons

bb72f96

create a new component VideoErrorIndicator

e9dbcd9

update in PlaybackContext

33b4f6a

handle errors generated by unsupported video inside BaseVideoPlayer

3369bba

created a patch for expo-av that handles unsupported video for ios

7aab44a

run prettier

3fb9c57

remove incorrect asset

95a183c

Merge branch 'Expensify:main' into fix/ios-handle-unsupported-video-f…

a16bf25

…ormats

added video-slash to assets/images

038cde0

Merge branch 'Expensify:main' into fix/ios-handle-unsupported-video-f…

494b566

…ormats

run prettier

7618a3b

HezekielT marked this pull request as ready for review February 25, 2025 13:32

HezekielT requested review from a team as code owners February 25, 2025 13:32

melvin-bot bot requested review from hoangzinh and removed request for a team February 25, 2025 13:32

fix eslint error

425d489

fixed styling issue in attachment offline indicator

8c1cf87

HezekielT requested a review from hoangzinh March 7, 2025 09:48

puneetlath added the Ready To Build label Mar 7, 2025

This comment has been minimized.

Sign in to view

hoangzinh approved these changes Mar 7, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath March 7, 2025 15:09

puneetlath approved these changes Mar 7, 2025

View reviewed changes

puneetlath merged commit d01c94e into Expensify:main Mar 7, 2025
23 checks passed

github-actions bot mentioned this pull request Mar 10, 2025

Deploy Checklist: New Expensify 2025-03-10 #58124

Closed

melvin-bot bot mentioned this pull request Mar 14, 2025

[Due for payment 2025-03-21] [$500][HIGH] Safari - Unable to play video attachment #52673

Closed

8 tasks

hoangzinh added a commit to hoangzinh/Expensify-App that referenced this pull request Mar 20, 2025

Revert "Merge pull request Expensify#57353 from HezekielT/fix/ios-han…

d64c7ad

…dle-unsupported-video-formats" This reverts commit d01c94e, reversing changes made to 5466c1d.

linhvovan29546 mentioned this pull request Apr 29, 2025

fix: error message overlaps video player when re connect #60893

Merged

51 tasks

Guccio163 mentioned this pull request Sep 23, 2025

[Due for payment 2026-02-04] Migrate App’s VideoPlayer from Deprecated expo-av to expo-video #64846

Closed

Conversation

HezekielT commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 24, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

melvin-bot bot commented Feb 25, 2025

Uh oh!

shawnborton commented Feb 25, 2025

Uh oh!

shawnborton commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

HezekielT commented Feb 25, 2025

Uh oh!

shawnborton commented Feb 25, 2025

Uh oh!

HezekielT commented Feb 25, 2025

Uh oh!

dannymcclain commented Feb 25, 2025

Uh oh!

shawnborton commented Feb 25, 2025

Uh oh!

HezekielT commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

hoangzinh commented Mar 7, 2025

Uh oh!

hoangzinh commented Mar 7, 2025

Uh oh!

hoangzinh commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

shawnborton commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

hoangzinh commented Mar 7, 2025

Uh oh!

dannymcclain commented Mar 7, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 7, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

HezekielT commented Mar 12, 2025

Uh oh!

puneetlath commented Mar 12, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

HezekielT commented Feb 24, 2025 •

edited

Loading

HezekielT commented Mar 7, 2025 •

edited

Loading

hoangzinh commented Mar 7, 2025 •

edited

Loading