Skip to content

fix: Missing bookmark icon for saved #57368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flodnv merged 6 commits into from
Mar 3, 2025
+5 −0
Merged

fix: Missing bookmark icon for saved #57368

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f39dbf
fix: Missing bookmark icon for saved
nkdengineer Feb 25, 2025
b7d6100
Merge branch 'main' into fix/57161
nkdengineer Feb 27, 2025
63138ff
fix icon width
nkdengineer Feb 27, 2025
c402bec
fix lint
nkdengineer Feb 27, 2025
d002972
fix style
nkdengineer Feb 27, 2025
ea2599b
fix style
nkdengineer Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import Navigation from '@libs/Navigation/Navigation';
import {getAllTaxRates} from '@libs/PolicyUtils';
import {buildSearchQueryJSON, buildUserReadableQueryString, isCannedSearchQuery} from '@libs/SearchQueryUtils';
import {createBaseSavedSearchMenuItem, createTypeMenuItems, getOverflowMenu as getOverflowMenuUtil} from '@libs/SearchUIUtils';
import variables from '@styles/variables';
import * as Expensicons from '@src/components/Icon/Expensicons';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
Expand Down Expand Up @@ -113,6 +114,10 @@ function SearchTypeMenuPopover({queryJSON, searchName, shouldGroupByReports}: Se
styles: [styles.textSupporting],
isSelected: false,
shouldCallAfterModalHide: true,
icon: Expensicons.Bookmark,
iconWidth: variables.iconSizeNormal,
iconHeight: variables.iconSizeNormal,
shouldIconUseAutoWidthStyle: false,
};
},
[hash, getOverflowMenu, styles.textSupporting, personalDetails, reports, taxRates, allCards],
Expand Down