Fix - Company cards - QBO: user stays on Export tab when click back arrow by FitseTLT · Pull Request #57394 · Expensify/App

FitseTLT · 2025-02-25T12:25:40Z

Details

Fixed Issues

$ #57030
PROPOSAL: #57030 (comment)

Tests

Precondition: workspace with added Company cards and QBO connected. Some card is assigned to the user

Go to ws > Company cards
Click on assigned card
Click on 'QuickBooks Online credit card export' row
Click the hyperlinked 'export option' in the subheader of the list
Click any of the interactive menu on the page
Click Back to land back on the card-level export page
Click back again and verify that you are not navigated to the same card-level export page

Make sure the accounting flows (Import/Export/Advance) work as expected.
Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

2025-02-25.15-22-13.mp4

iOS: Native

2025-02-25.16-17-23.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2025-02-25T12:25:46Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…n-bug

hungvu193 · 2025-02-26T08:56:49Z

Bug:
When you change the export option, you're navigated to main panel:

Screen.Recording.2025-02-26.at.15.56.30.mov

…n-bug

FitseTLT · 2025-02-26T14:14:50Z

Bug: When you change the export option, you're navigated to main panel:

Screen.Recording.2025-02-26.at.15.56.30.mov

Wow nice Catch @hungvu193 Fixed 👍

hungvu193 · 2025-02-26T15:22:17Z

I think with the current approach, we still have 2 Export screen in stack, checkout the video below.

Screen.Recording.2025-02-26.at.22.19.28.mov

hungvu193 · 2025-02-26T15:23:34Z

If I choose VendorBill, then there will be an infinite loop between Card Details and Export screen 🤔

Screen.Recording.2025-02-26.at.22.22.48.mov

FitseTLT · 2025-02-27T14:01:53Z

@hungvu193 Fixed

hungvu193 · 2025-02-27T15:55:01Z

Can you check again?> I can still reproduce the bug above, looping between Card detail and export screen.

Screen.Recording.2025-02-27.at.22.53.54.mov

FitseTLT · 2025-02-27T16:01:06Z

For that U will have to hold for #56177 @hungvu193

hungvu193 · 2025-02-28T04:19:40Z

For that U will have to hold for #56177 @hungvu193

That PR was created 1 month ago, do you think you can push it forward soon?

FitseTLT · 2025-02-28T13:42:08Z

Make sense @hungvu193 since you are quicker, I have applied the partial changes that are needed here. U can proceed 👍

hungvu193 · 2025-02-28T16:53:28Z

Cool. Can you also list other places that will be affected by your changes in your tests checklist?

FitseTLT · 2025-02-28T19:19:21Z

The change I made from the other pr doesn't change the navigation behavior it will only solve the loop. no need to change the steps.

This reverts commit d11f83b.

…n-bug

FitseTLT · 2025-02-28T22:19:21Z

The PR was merged so I reverted the last change and merged main 👍

hungvu193 · 2025-03-01T07:44:00Z

The change I made from the other pr doesn't change the navigation behavior it will only solve the loop. no need to change the steps.

I know that but we also found this bug right? So I think we still might need to list all the flow that we touched the code recently, no need to write down the detail, just need somethings like: Make sure the Export flow of Sage Intact works as expected....

hungvu193

@FitseTLT Great work, I don't expect we need so many changes. Thanks for your good job here!

hungvu193 · 2025-02-28T17:03:19Z

src/pages/workspace/accounting/intacct/export/SageIntacctDatePage.tsx

+                if (!policyID) {
+                    return;
+                }


We already had this early return inside clearSageIntacctErrorField, do we still need it here? If no, let's remove it in other places that are using clearSageIntacctErrorField as well

FitseTLT · 2025-03-03T14:41:43Z

The change I made from the other pr doesn't change the navigation behavior it will only solve the loop. no need to change the steps.

I know that but we also found this bug right? So I think we still might need to list all the flow that we touched the code recently, no need to write down the detail, just need somethings like: Make sure the Export flow of Sage Intact works as expected....

I am struggling to come up with a step for a feature that already works on main Wouldn't that be confusing for QA? But if you still down to it can you suggest the exact text U want me to add to OP? Thx

hungvu193 · 2025-03-03T15:10:53Z

Please add:

Make sure the accounting flows (Import/Export/Advance) work as expected.

FitseTLT · 2025-03-03T15:15:00Z

Thx updated

hungvu193 · 2025-03-03T15:16:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-01.at.16.24.38.mov

Android: mWeb Chrome

mAndroid.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desk.mov

hungvu193

LGTM!

OSBotify · 2025-03-03T21:10:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-04T22:09:25Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.1.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-04T22:52:32Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.1.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-06T22:55:51Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix back navigation to export page

cb94e41

FitseTLT requested a review from a team as a code owner February 25, 2025 12:25

melvin-bot bot requested review from hungvu193 and removed request for a team February 25, 2025 12:25

FitseTLT added 6 commits February 25, 2025 15:59

lint fix

c6398e9

lint fix

ff4f5a9

lint fix

88cf4bf

lint fix

048932f

lint fix

12ec742

Merge branch 'main' into fix-company-cards-export-page-back-navigatio…

a9dd4ba

…n-bug

mallenexpensify mentioned this pull request Feb 26, 2025

[Due for payment 2025-03-13] [$250] Company cards - QBO: user stays on Export tab when click back arrow #57030

Closed

8 tasks

FitseTLT added 4 commits February 26, 2025 16:45

Merge branch 'main' into fix-company-cards-export-page-back-navigatio…

1eeef3e

…n-bug

minor fix

e25d518

fix ts

a1dcf7a

fix navigation bug

2a855dc

FitseTLT added 2 commits February 27, 2025 00:28

fix for qbo

e593f9d

fix other integrations

eab331c

lint fix

d99b95f

fix navigation loop bug

d11f83b

FitseTLT added 2 commits March 1, 2025 01:18

Revert "fix navigation loop bug"

4ab8c2e

This reverts commit d11f83b.

Merge branch 'main' into fix-company-cards-export-page-back-navigatio…

779388d

…n-bug

hungvu193 suggested changes Mar 1, 2025

View reviewed changes

minor update

21c5bac

FitseTLT requested a review from hungvu193 March 3, 2025 14:41

minor update

ef040fa

hungvu193 approved these changes Mar 3, 2025

View reviewed changes

melvin-bot bot requested a review from arosiclair March 3, 2025 15:16

arosiclair approved these changes Mar 3, 2025

View reviewed changes

arosiclair merged commit 227c221 into Expensify:main Mar 3, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 4, 2025

Deploy Checklist: New Expensify 2025-03-04 #57792

Closed

77 tasks

Conversation

FitseTLT commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 25, 2025

Uh oh!

hungvu193 commented Feb 26, 2025

Uh oh!

FitseTLT commented Feb 26, 2025

Uh oh!

hungvu193 commented Feb 26, 2025

Uh oh!

hungvu193 commented Feb 26, 2025

Uh oh!

FitseTLT commented Feb 27, 2025

Uh oh!

hungvu193 commented Feb 27, 2025

Uh oh!

FitseTLT commented Feb 27, 2025

Uh oh!

hungvu193 commented Feb 28, 2025

Uh oh!

FitseTLT commented Feb 28, 2025

Uh oh!

hungvu193 commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FitseTLT commented Feb 28, 2025

Uh oh!

FitseTLT commented Feb 28, 2025

Uh oh!

hungvu193 commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Mar 3, 2025

Uh oh!

hungvu193 commented Mar 3, 2025

Uh oh!

FitseTLT commented Mar 3, 2025

Uh oh!

hungvu193 commented Mar 3, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FitseTLT commented Feb 25, 2025 •

edited

Loading

hungvu193 commented Feb 28, 2025 •

edited

Loading

hungvu193 commented Mar 1, 2025 •

edited

Loading