[HybridApp] Add HybridApp turbomodule#57406
Conversation
# Conflicts: # Mobile-Expensify # package-lock.json # src/libs/Environment/getEnvironment/index.native.ts # src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx
|
|
|
|
|
|
|
|
WoLewicki
left a comment
There was a problem hiding this comment.
Some comments here too 😅
# Conflicts: # Mobile-Expensify # package-lock.json
|
|
|
|
# Conflicts: # Mobile-Expensify
|
|
|
|
|
|
|
|
# Conflicts: # package-lock.json # src/components/BookTravelButton.tsx # src/components/ScreenWrapper.tsx # src/pages/Travel/MyTripsPage.tsx # src/pages/Travel/TripSummaryPage.tsx # src/pages/settings/InitialSettingsPage.tsx
|
|
|
🚧 @Julesssss has triggered a test app build. You can view the workflow run here. |
|
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Julesssss
left a comment
There was a problem hiding this comment.
Understood very little, but it's testing well!
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
|
mountiny
left a comment
There was a problem hiding this comment.
Gonna merge this and that should unblock the kotlin action in the oldApp pr
|
|
||
| - (void)completeOnboarding:(BOOL)status { | ||
| NSLog(@"[ReactNativeHybridApp] `completeOnboarding` should never be called in standalone `New Expensify` app"); | ||
|
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…p-turbomodule (cherry picked from commit 931dcd3) (CP triggered by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.12-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.13-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.14-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
@war-in QA facing with issue #58357 |
|
@izarutskaya Yes, as Daniel said this is not implemented on web |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.14-5 🚀
|
Explanation of Change
This PR adds
hybrid-appmodule, which provides functionality required to communicate with the OldDot part (HybridAppModulepreviously)Fixed Issues
$ #57510
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13442
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop