Android - Search - Text in search input, bounces with every letter added to the search by thelullabyy · Pull Request #57666 · Expensify/App

thelullabyy · 2025-03-03T11:24:20Z

Explanation of Change

Fixed Issues

$#56526
PROPOSAL:#56526 (comment)

Tests

Open the Expensify app.
Open any chat with content in it.
Tap on the search icon on the top right corner.
Tap on "Search in this chat"
Start typing on the search input until the text doesn´t fit the input and the first part of the content disappears.
Verify: With every letter added, content in search input not bouncing move and display green loader

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Open any chat with content in it.
Tap on the search icon on the top right corner.
Tap on "Search in this chat"
Start typing on the search input until the text doesn´t fit the input and the first part of the content disappears.
Verify: With every letter added, content in search input not bouncing move and display green loader

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

untitled.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

chorme.mp4

MacOS: Desktop

desktop.mov

melvin-bot · 2025-03-03T11:24:24Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-03-03T11:43:36Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-03-04T10:57:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-06.at.8.35.20.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-06.at.8.34.24.AM.mov

iOS: Native

Screen.Recording.2025-03-06.at.8.31.10.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-03-06.at.8.31.58.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-06.at.8.29.13.AM.mov

MacOS: Desktop

allgandalf · 2025-03-05T18:25:37Z

Done with checklist will upload the checklist tomorrow

allgandalf

please hold on the merge

allgandalf · 2025-03-06T03:08:39Z

src/components/TextInput/BaseTextInput/index.native.tsx

                                    size="small"
                                    color={theme.iconSuccessFill}
-                                    style={[styles.mt4, styles.ml1, loadingSpinnerStyle]}
+                                    style={[styles.mt4, styles.ml1, loadingSpinnerStyle, {opacity: inputProps.isLoading ? 1 : 0}]}


oh actually i just realised we define this in the stylesheet:

https://github.com/search?q=repo%3AExpensify%2FApp%20opacity&type=code

@thelullabyy can you please update it accordingly ?

@allgandalf I updated PR, please help me check. Thanks

@thelullabyy did you test these new changes again?

@allgandalf yep, all good with the new update

Screen.Recording.2025-03-10.at.09.24.48.mov

OSBotify · 2025-03-11T17:29:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-12T14:07:39Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

…nput-bounces-on-each-letter-added" This reverts commit e635341, reversing changes made to 8088713.

github-actions · 2025-03-14T01:07:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-03-14T02:17:55Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-17T11:40:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: Text in search input bounces with each letter added to the search

5c0222e

thelullabyy marked this pull request as ready for review March 3, 2025 11:43

thelullabyy requested a review from a team as a code owner March 3, 2025 11:43

melvin-bot bot requested review from allgandalf and removed request for a team March 3, 2025 11:43

allgandalf approved these changes Mar 6, 2025

View reviewed changes

melvin-bot bot requested a review from deetergp March 6, 2025 03:06

allgandalf suggested changes Mar 6, 2025

View reviewed changes

refactor: use stylesheet instead

2687591

allgandalf approved these changes Mar 10, 2025

View reviewed changes

deetergp approved these changes Mar 11, 2025

View reviewed changes

deetergp merged commit e635341 into Expensify:main Mar 11, 2025
20 checks passed

thelullabyy mentioned this pull request Mar 12, 2025

[Due for payment 2025-04-14] [$250] Search - Pasting long text removes left padding & cursor focus is missing #58214

Closed

8 tasks

github-actions bot mentioned this pull request Mar 12, 2025

Deploy Checklist: New Expensify 2025-03-12 #58283

Closed

71 tasks

daledah mentioned this pull request Mar 12, 2025

[Due for payment 2025-03-24] [Due for payment 2025-03-21] Reports - Search field has extra right padding #58294

Closed

8 tasks

deetergp added a commit that referenced this pull request Mar 12, 2025

Revert "Merge pull request #57666 from thelullabyy/fix/56526-search-i…

7d58250

…nput-bounces-on-each-letter-added" This reverts commit e635341, reversing changes made to 8088713.

melvin-bot bot mentioned this pull request Mar 14, 2025

[Due for payment 2025-04-08] [Due for payment 2025-03-24] [Due for payment 2025-03-21] [$250] Android - Search - Text in search input, bounces with every letter added to the search. #56526

Closed

8 tasks

github-actions bot mentioned this pull request Mar 14, 2025

Deploy Checklist: New Expensify 2025-03-14 #58424

Closed

90 tasks

Conversation

thelullabyy commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 3, 2025

Uh oh!

melvin-bot bot commented Mar 3, 2025

Uh oh!

allgandalf commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Mar 5, 2025

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 11, 2025

Uh oh!

github-actions bot commented Mar 12, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thelullabyy commented Mar 3, 2025 •

edited

Loading

allgandalf commented Mar 4, 2025 •

edited

Loading