[CP Staging] Revert "[No QA] Change offline status when Pusher PINGPONG fails"#57680
Merged
MarioExpensify merged 1 commit intomainfrom Mar 3, 2025
Merged
Conversation
tgolen
changed the title
MarioExpensify
approved these changes
Mar 3, 2025
|
@MarioExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
Not an emergency, it is a straight revert. |
OSBotify
pushed a commit
that referenced
this pull request
Mar 3, 2025
…-triggeroffline [CP Staging] Revert "[No QA] Change offline status when Pusher PINGPONG fails" (cherry picked from commit 0b5045d) (CP triggered by puneetlath)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
40 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.7-2 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.7-2 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.7-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #57255
This is a straight revert. It was still taking clients offline a little too much so we need to discuss how to roll this out further.