fix: Do not display errors in the Start screen of USD VBA flow by MrMuzyk · Pull Request #57776 · Expensify/App

MrMuzyk · 2025-03-04T18:31:56Z

Explanation of Change

Nested OfflineWithFeedback component deeper so it is only displayed when we show set of buttons for Continue scenario
Pass only latest error to OfflineWithFeedback component

Fixed Issues

$ #57768
PROPOSAL:
#57768 (comment)

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a new USD workspace.
Go to workspace settings > Workflows.
Click Connect bank account.
Click Connect manually.
Enter 011401533 for Routing number.
Enter 111111111111111 for Account number.
Click Next.
Click RHP back button.
No errors should be displayed
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mov

Android: mWeb Chrome

android.mweb.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-05.at.09.24.40.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-03-04T18:32:01Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

QichenZhu · 2025-03-04T19:35:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  Test steps require a network connection.
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I noticed an error not related to this PR. A contributor has reported it in Slack.
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
Not added, and I don’t think it’s necessary since the same issue is unlikely to happen again.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

QichenZhu · 2025-03-04T20:26:36Z

Hi @MrMuzyk, I saw the plan to update this PR tomorrow. Please ping me once it’s ready. Thanks!

MrMuzyk · 2025-03-05T08:54:52Z

Hi @QichenZhu. PR is ready for the review

src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

QichenZhu · 2025-03-05T11:34:53Z

Thanks @MrMuzyk! The code looks good and works well.

Just a few suggestions as required by the checklist:

Please update the expected behavior in the title and test steps.
If applicable, please add screenshots/videos for other platforms.
I couldn’t find the "Update to USD" button (it’s not there on the main branch either). Do you think it’s necessary to add a step to manually change the currency?

This branch / main branch	Staging

MrMuzyk · 2025-03-05T11:48:17Z

I couldn’t find the "Update to USD" button (it’s not there on the main branch either). Do you think it’s necessary to add a step to manually change the currency?

I believe it's only shown when your freshly created workspace has different currency than USD. This step doesn't matter when it comes to final outcome. I've changed the QA steps to create USD workspace straight away and removed mention of the Updated to USD button.

If applicable, please add screenshots/videos for other platforms.

I will add recordings from other platforms soon.

MrMuzyk · 2025-03-05T13:41:09Z

I've updated description and title and uploaded recordings for all the platforms but android mWeb. I hope we can skip this one as I'm having some issues running this atm (swapped to new laptop recently) and I'm about to finish my day. I can see that you've provided recording from that platform so it's all working well.

MrMuzyk · 2025-03-05T13:48:49Z

I've finally managed to run the mweb version on android too. Added a recording

QichenZhu · 2025-03-05T13:50:10Z

@MrMuzyk thanks for your time and patience!

neil-marcellini

I asked a question about the proposal on the issue. I want to understand it before we go ahead with this.

QichenZhu · 2025-03-07T12:43:09Z

src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

-                                )}
+                    {shouldShowContinueSetupButton === true ? (
+                        <OfflineWithFeedback
+                            errors={getLatestError(errors)}


I have a small concern with this function call. Since it relies on timestamps and one error comes from the client and the other from the server, if the client's clock is one second ahead, the order will be reversed.

I don't think we need to worry about such an extreme edge case. If you can find a flow which is causing that error somewhat regularly then you can report it as a separate bug.

neil-marcellini · 2025-03-07T17:31:58Z

src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

-                                )}
+                    {shouldShowContinueSetupButton === true ? (
+                        <OfflineWithFeedback
+                            errors={getLatestError(errors)}


I don't think we need to worry about such an extreme edge case. If you can find a flow which is causing that error somewhat regularly then you can report it as a separate bug.

OSBotify · 2025-03-07T17:40:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-10T21:36:10Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.11-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-14T01:07:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: Pass only latest error entry point screen

b61aeb6

MrMuzyk requested a review from a team as a code owner March 4, 2025 18:31

melvin-bot bot requested a review from QichenZhu March 4, 2025 18:32

melvin-bot bot removed the request for review from a team March 4, 2025 18:32

fix: do not display error at all

4729bf7

QichenZhu reviewed Mar 5, 2025

View reviewed changes

src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx Show resolved Hide resolved

MrMuzyk changed the title ~~fix: Pass only latest error on entry screen of USD flow~~ fix: Do not display errors in the Start screen of USD VBA flow Mar 5, 2025

QichenZhu approved these changes Mar 5, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini March 5, 2025 13:46

QichenZhu mentioned this pull request Mar 5, 2025

[Due for payment 2025-03-21] Bank account - Two error messages appear on the main page when bank info is incorrect #57768

Closed

8 tasks

neil-marcellini requested changes Mar 5, 2025

View reviewed changes

fix: pass only latest error

a49c13a

MrMuzyk requested a review from neil-marcellini March 7, 2025 07:48

QichenZhu reviewed Mar 7, 2025

View reviewed changes

neil-marcellini approved these changes Mar 7, 2025

View reviewed changes

neil-marcellini merged commit a180aa2 into Expensify:main Mar 7, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 10, 2025

Deploy Checklist: New Expensify 2025-03-10 #58124

Closed

Conversation

MrMuzyk commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 4, 2025

Uh oh!

QichenZhu commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Mar 4, 2025

Uh oh!

MrMuzyk commented Mar 5, 2025

Uh oh!

Uh oh!

QichenZhu commented Mar 5, 2025

Uh oh!

MrMuzyk commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrMuzyk commented Mar 5, 2025

Uh oh!

MrMuzyk commented Mar 5, 2025

Uh oh!

QichenZhu commented Mar 5, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MrMuzyk commented Mar 4, 2025 •

edited

Loading

QichenZhu commented Mar 4, 2025 •

edited

Loading

MrMuzyk commented Mar 5, 2025 •

edited

Loading