[CP Staging] Fix: Scroll Issue on Reports Page, side pane appearing after language change by blazejkustra · Pull Request #57831 · Expensify/App

blazejkustra · 2025-03-05T08:47:24Z

Explanation of Change

Issue was reported by @shawnborton on Slack here. Fixing two big issues in one PR:

Unable to Scroll Down on Reports Page
HelpButton was displayed for anyone that changed their langugage back and forth

Fixed Issues

$ #56988
PROPOSAL: N/A

Tests

Open Reports page on web (safari desktop, chrome desktop, safari ios, chrome android)
Verify that the page works well and user can scroll the reports
Make sure you have Help nvp disabled:

Onyx.set("nvp_sidePaneExpanded", null)

Change language from English to Spanish, and from Spanish to English
Verify that HelpButton isn't displayed in headers (for example on reports page)

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: mWeb Chrome

and.webm

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-05.at.09.54.50.mp4

MacOS: Chrome

Screen.Recording.2025-03-05.at.09.53.01.mov

MacOS: Safari

Screen.Recording.2025-03-05.at.09.53.27.mov

melvin-bot · 2025-03-05T08:59:43Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2025-03-05T09:03:26Z

FYI, this should also resolve a performance issue on the Reports screen. The issue was that all reports were being rendered at once, including those outside the visible area. This not only caused performance problems but also made scrolling impossible since the reports were technically present but positioned off-screen 😓

github-actions · 2025-03-05T09:34:43Z

🚧 @shawnborton has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-03-05T09:59:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57831/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57831/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/57831/NewExpensify.dmg	https://57831.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

brunovjk · 2025-03-05T11:11:44Z

Even in Spanish I can manually enable Pane:

bug.mov

brunovjk · 2025-03-05T11:17:04Z

There is something strange happening when I change the report search type, it only happens on iOS - Safari mWeb:

iosm.web-.bug.mov

On other platforms it works fine:

Screenshots/Videos

Android: mWeb Chrome

57831-android-web.mov

iOS: Native

57831_ios_native.mov

iOS: mWeb Safari - Bug above

MacOS: Chrome / Safari

57831-web-chrome.mov

57831-web-safari.mov

MacOS: Desktop

57831-web-desktop.mov

shawnborton · 2025-03-05T11:27:41Z

This seems to have fixed the Reports page scrolling for me.

sumo-slonik · 2025-03-05T12:47:46Z

There is something strange happening when I change the report search type, it only happens on iOS - Safari mWeb:

iosm.web-.bug.mov
On other platforms it works fine:

Screenshots/Videos

Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari - Bug above
MacOS: Chrome / Safari
MacOS: Desktop

Hi @brunovjk
There was already a very similar issue to the one with the popup menu on mobile Safari: #57327
And as I mentioned in this comment, it will be fixed soon:
#57327 (comment)

rushatgabhane · 2025-03-05T19:01:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

WhatsApp.Video.2025-03-05.at.20.09.02.mp4

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-03-05.at.20.06.38.mov

iOS: mWeb Safari

Screen.Recording.2025-03-05.at.20.04.46.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-05.at.19.59.56.mov

MacOS: Desktop

francoisl · 2025-03-05T19:03:15Z

src/libs/Navigation/AppNavigator/useRootNavigatorScreenOptions.ts

            animation: Animations.NONE,
            web: {
+                cardStyle: {
+                    height: '100%',


NAB - Down the line we can probably move this to a style utils too.

rushatgabhane

retrigger checklist

OSBotify · 2025-03-05T19:23:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ts-screen [CP Staging] Fix: Scroll Issue on Reports Page, side pane appearing after language change (cherry picked from commit a99a5fe) (CP triggered by francoisl)

github-actions · 2025-03-05T20:05:42Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.1.9-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-06T22:56:51Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Fix Side Pane deploy blockers

247c88a

blazejkustra marked this pull request as ready for review March 5, 2025 08:59

blazejkustra requested a review from a team as a code owner March 5, 2025 08:59

melvin-bot bot requested a review from brunovjk March 5, 2025 08:59

melvin-bot bot removed the request for review from a team March 5, 2025 08:59

shawnborton added the Ready To Build label Mar 5, 2025

shawnborton mentioned this pull request Mar 5, 2025

Deploy Checklist: New Expensify 2025-03-04 #57792

Closed

77 tasks

Hide help panel on other languages

ef8193d

francoisl changed the title ~~Fix: Scroll Issue on Reports Page, side pane appearing after language change~~ [CP Staging] Fix: Scroll Issue on Reports Page, side pane appearing after language change Mar 5, 2025

francoisl requested review from brunovjk and rushatgabhane and removed request for brunovjk March 5, 2025 18:51

francoisl reviewed Mar 5, 2025

View reviewed changes

rushatgabhane approved these changes Mar 5, 2025

View reviewed changes

melvin-bot bot requested a review from francoisl March 5, 2025 19:09

francoisl approved these changes Mar 5, 2025

View reviewed changes

rushatgabhane approved these changes Mar 5, 2025

View reviewed changes

melvin-bot bot requested a review from francoisl March 5, 2025 19:14

francoisl merged commit a99a5fe into Expensify:main Mar 5, 2025
18 of 21 checks passed

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 5, 2025

melvin-bot bot mentioned this pull request Mar 6, 2025

[Due for payment 2025-03-21] [SIDEPANE][Due for payment 2025-03-13] Build "Stage 1) Build a placeholder help pane, tested via NVP" of "Add live-navigating help side pane" #471592 #56988

Closed

Conversation

blazejkustra commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 5, 2025

Uh oh!

blazejkustra commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

brunovjk commented Mar 5, 2025

Uh oh!

brunovjk commented Mar 5, 2025

Screenshots/Videos

Uh oh!

shawnborton commented Mar 5, 2025

Uh oh!

sumo-slonik commented Mar 5, 2025

Screenshots/Videos

Uh oh!

rushatgabhane commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

francoisl Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

blazejkustra commented Mar 5, 2025 •

edited

Loading

rushatgabhane commented Mar 5, 2025 •

edited

Loading

rushatgabhane left a comment •

edited

Loading