[CP STAGING] fix: Attachments-Swiping to the left through attachment by nkdengineer · Pull Request #57856 · Expensify/App

nkdengineer · 2025-03-05T15:10:44Z

Explanation of Change

Fixed Issues

$ #57291
#57825
PROPOSAL:

Tests

1) Test attachment swiping

Sign in as a gmail user
Navigate to 1:1 chat with the attachments or send a few attachments
Open the first attachment preview and swipe to the right a few attachments
Swipe to the left 1-2 times
Verify that: User is navigating to the previous attachment preview when swiping to the left from the next attachment

2) Test HybridApp PDF scrolling

Open Expensify hybrid app
Tap on any conversation
Tap on pdf preview
Scroll to see more
Verify that the user can easily scroll up and down through the PDF file

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios-mweb.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-05T15:24:52Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2025-03-05T22:42:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Before	After
Screen.Recording.2025-03-05.at.11.54.02.PM.mov	Screen.Recording.2025-03-05.at.11.58.20.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-06.at.12.36.33.AM.mov

iOS: Native

Before	After
Screen.Recording.2025-03-06.at.12.08.39.AM.mov	Screen.Recording.2025-03-06.at.12.11.04.AM.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-06.at.00.32.41.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-06.at.12.27.12.AM.mov

MacOS: Desktop

Screen.Recording.2025-03-06.at.12.34.25.AM.mov

rayane-d · 2025-03-05T23:01:20Z

Confirmed it fixes issue #57823 👍

Before	After
Screen.Recording.2025-03-05.at.11.54.02.PM.mov	Screen.Recording.2025-03-05.at.11.58.20.PM.mov

Testing issue #57825 and #57291 now...

rayane-d · 2025-03-05T23:12:27Z

Confirmed it fixes issue #57825 👍

Before	After
Screen.Recording.2025-03-06.at.12.08.39.AM.mov	Screen.Recording.2025-03-06.at.12.11.04.AM.mov

Testing issue #57291 now...

rayane-d · 2025-03-05T23:19:51Z

Confirmed that this still fixes the issue #57291 👍

Screen.Recording.2025-03-06.at.12.12.46.AM.mov

Completing the checklist now...

rayane-d · 2025-03-05T23:39:35Z

@puneetlath / @Julesssss Could you please add this QA test case to the author checklist (for issue #57823):

1. Open Expensify hybrid app
2. Tap on any conversation
3. Tap on pdf preview
4. Scroll to see more
5. Verify that the user can easily scroll up and down through the PDF file

rayane-d

LGTM and tests well 👍

[CP STAGING] fix: Attachments-Swiping to the left through attachment (cherry picked from commit 11a0f63) (CP triggered by Julesssss)

rayane-d · 2025-03-05T23:53:57Z

@Julesssss Could you please add the issue link #57823 as well to the "Fixed Issues" in the author checklist, and assign me there as well? Thanks!

github-actions · 2025-03-06T00:29:11Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Julesssss · 2025-03-06T00:54:14Z

I'm getting a crash on build 9.1.9-5, likely not related but we'll need to resolve that before checking this off.

AndroidCrash5march.mp4

github-actions · 2025-03-06T22:56:54Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: Attachments-Swiping to the left through attachment

e47328c

nkdengineer marked this pull request as ready for review March 5, 2025 15:24

nkdengineer requested a review from a team as a code owner March 5, 2025 15:24

melvin-bot bot requested review from DylanDylann and removed request for a team March 5, 2025 15:24

nkdengineer mentioned this pull request Mar 5, 2025

iOS Hybrid - Attachments-Swiping to the left through attachment previews navigates back to the chat #57825

Closed

8 tasks

NikkiWines mentioned this pull request Mar 5, 2025

Android Hybrid-Attachment- It is hard to scroll the pdf file #57823

Closed

8 tasks

puneetlath approved these changes Mar 5, 2025

View reviewed changes

Julesssss approved these changes Mar 5, 2025

View reviewed changes

rayane-d approved these changes Mar 5, 2025

View reviewed changes

melvin-bot bot requested a review from blimpich March 5, 2025 23:39

Julesssss changed the title ~~fix: Attachments-Swiping to the left through attachment~~ [CP STAGING] fix: Attachments-Swiping to the left through attachment Mar 5, 2025

Julesssss merged commit 11a0f63 into Expensify:main Mar 5, 2025
20 of 21 checks passed

OSBotify pushed a commit that referenced this pull request Mar 5, 2025

Merge pull request #57856 from nkdengineer/fix/57825

19430a3

[CP STAGING] fix: Attachments-Swiping to the left through attachment (cherry picked from commit 11a0f63) (CP triggered by Julesssss)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 5, 2025

github-actions bot mentioned this pull request Mar 5, 2025

Deploy Checklist: New Expensify 2025-03-04 #57792

Closed

77 tasks

melvin-bot bot mentioned this pull request Mar 6, 2025

[Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right #57291

Closed

8 tasks

rayane-d mentioned this pull request Mar 18, 2025

fix: search page cannot be dismissed by swiping to the right #57516

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP STAGING] fix: Attachments-Swiping to the left through attachment#57856

[CP STAGING] fix: Attachments-Swiping to the left through attachment#57856
Julesssss merged 1 commit intoExpensify:mainfrom
nkdengineer:fix/57825

nkdengineer commented Mar 5, 2025 •

edited by Julesssss

Loading

Uh oh!

melvin-bot bot commented Mar 5, 2025

Uh oh!

rayane-d commented Mar 5, 2025 •

edited

Loading

Uh oh!

rayane-d commented Mar 5, 2025 •

edited

Loading

Uh oh!

rayane-d commented Mar 5, 2025

Uh oh!

rayane-d commented Mar 5, 2025

Uh oh!

rayane-d commented Mar 5, 2025 •

edited

Loading

Uh oh!

rayane-d left a comment

Uh oh!

Uh oh!

rayane-d commented Mar 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Julesssss commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nkdengineer commented Mar 5, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 5, 2025

Uh oh!

rayane-d commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d commented Mar 5, 2025

Uh oh!

rayane-d commented Mar 5, 2025

Uh oh!

rayane-d commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rayane-d commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Julesssss commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Mar 5, 2025 •

edited by Julesssss

Loading

rayane-d commented Mar 5, 2025 •

edited

Loading

rayane-d commented Mar 5, 2025 •

edited

Loading

rayane-d commented Mar 5, 2025 •

edited

Loading

rayane-d commented Mar 5, 2025 •

edited

Loading