Fix: Share code appears zoomed in briefly when opening share RHP with help panel by blazejkustra · Pull Request #57857 · Expensify/App

blazejkustra · 2025-03-05T15:36:09Z

Explanation of Change

Fixed Issues

$ #57815
PROPOSAL: N/A

Tests

Precondition:

Run Onyx.set('nvp_sidePaneExpanded', {}) in console.
Go to workspace settings > Overview.
Click help icon.
Click Share
Verify that QRCode is not zoomed in initialy

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2025-03-05.at.16.35.49.mov

melvin-bot · 2025-03-05T15:36:15Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kicu

Not the pretties solution, but its contained only for share QR code so I think its fine 👍

blazejkustra · 2025-03-05T15:39:00Z

This is a regression from one of my PR @QichenZhu and @brunovjk should review this one, sorry!

QichenZhu · 2025-03-05T18:15:23Z

I observed a similar issue in production with the steps below, though it's not as obvious, so the root cause should not be your previous PR. This commit looks more related.

In macOS Chrome, open the side panel of an expense.
Press F12, go to the Performance panel, and set the CPU to 20x slowdown.
Click Share.

prod-57815.mov

QichenZhu

Would you consider addressing the root cause? If that's not practical, we can go with the current approach.

brunovjk · 2025-03-06T10:46:08Z

The original issue is no longer observable in my tests:

MacOS: Chrome / Safari

57815_web_chrome.mov

MacOS: Desktop

57815_web_desktop.mov

Android: Native

57815_android_native.mov

iOS: Native

57815_ios_native.mov

However after we "go to the Performance panel, and set the CPU to 20x slowdown." we can still see the QR code changing size:

MacOS: Chrome / Safari

57815_web_chrome_bug.mov

What do you think @blazejkustra and @QichenZhu ? Thanks.

blazejkustra · 2025-03-06T11:58:21Z

The original issue is no longer observable in my tests:

I can reliably reproduce on web, so I think we should still fix it.

Would you consider addressing the root cause? If that's not practical

We wouldn't want to use isSmallScreenWidth as it is deprecated. I'm not convinced the change you refer is the cause of this issue as it was only affecting width of the QRCode, while I'm changing the height 🤔

brunovjk · 2025-03-06T12:37:40Z

The original issue is no longer observable in my tests:

Sorry @blazejkustra I mean testing your PR

brunovjk · 2025-03-06T12:39:42Z

The original issue is no longer observable in my tests:

MacOS: Chrome / Safari
MacOS: Desktop
Android: Native
iOS: Native
However after we "go to the Performance panel, and set the CPU to 20x slowdown." we can still see the QR code changing size:

MacOS: Chrome / Safari
What do you think @blazejkustra and @QichenZhu ? Thanks.

All those results come from your PR :D