Fix FAB button state synchronization with create menu activity

[Amoralchik]

Explanation of Change

Fixed Issues

$ #54643 \ #57797
PROPOSAL: #54643 (comment)

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Create new account
Choose "Get paid back by my employer" option in onboarding
Click the "Submit expense" task from Concierge
Make sure you can see a green emoji-like button inline with the text
Make sure you can click green button and finish Task (Create expense)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

2025-03-20.13.53.48-1.mov

Android: mWeb Chrome

2025-03-20.12.33.25.mov

iOS: Native

2025-03-20.13.18.25.mov

iOS: mWeb Safari

2025-03-20.12.45.27.mov

MacOS: Chrome / Safari

2025-03-20.12.25.19-1.mov

MacOS: Desktop

2025-03-20.12.26.44-1.mov

[melvin-bot]

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[tgolen]

@allroundexperts this is to fix a deploy blocker, do you think you could take a look at it soon?

[rushatgabhane]

@Amoralchik this isn't quite working. The performance is not good and the fab button icon's state is inconsistent

Screen.Recording.2025-03-05.at.23.42.21.mov

[Amoralchik]

@rushatgabhane Could you provide more information, perhaps some steps?

[tgolen]

For now, we will revert the original PR so you don't need to stress about this blocking the deploy. I've opened #57890 for the revert.

[Amoralchik]

@tgolen I think it's not my fault, something happened on the search page, that triggers FAB so it's starts lags, but okay, my main is pretty old, so maybe after revert we can investigate it
Yep, after update main, I got same lags with FAB

2025-03-06_01-24-22.mp4

[Amoralchik]

oh sorry, I probably need to mention @rushatgabhane instead
please take a look at #57874 (comment)

[allroundexperts]

@tgolen Sorry, My plate is full. Please re-assign if needed.

[Amoralchik]

@rushatgabhane Please, take a look, and say what you think, as I say I still have lags onthe search page, but I guess now it works slightly better

[rushatgabhane]

sorry, i dont have much context on this feature so I won't ve reviewing it

[c3024]

The lag appears on main too for me, so I do not think the changes in this PR caused it.

Regarding the old deploy blocker #57797, it happens because this onClose should trigger after the popover closes.

App/src/pages/home/sidebar/FloatingActionButtonPopover.tsx

Line 494 in caaae0c

onClose={hideCreateMenu}

Instead, it gets triggered first, so hidePopoverMenu closes the popover first, and then the togglePopoverMenu of this onPress opens it again.

App/src/components/Navigation/BottomTabBar/index.tsx

Line 249 in caaae0c

onPress={() => toggleCreateMenu(localFabRef)}

While using a local ref fixes this specific issue, there is still a case where the popover onClose action happens before the togglePopoverMenu of onPress in the FloatingActionButton, following these steps:
1. Click on the emoji from the task description to open the FAB popover.
2. Click on the FAB (not the emoji) to close the popover.
3. Observe that it does not close on the first click and only closes on the second click.

Screen.Recording.2025-03-10.at.8.03.47.PM.mov

It does not close the first time because the onClose of the popover triggers first, followed by the togglePopoverMenu. This worked correctly in the previous PR #56602.

[Amoralchik]

@c3024 Thank you, I know about this behavior (and working on it), I just wanted to understand, if this way, works better, for rushatgabhane who pointed out performance issues in #57874 (review) for original fix

[c3024]

@Amoralchik

Any update?

[danielrvidal]

@Amoralchik can you please take a look at this one? It would be great to get this out and done this week. Let us know if you are waiting on anything from anyone.

[Amoralchik]

Updated, add video, ready for review
Solution with ref's fixes the lag issue
Solution with local states, fix issues with open/close by clicking on second button.
Sorry for waiting

[roryabraham]

you've got conflicts here

[Amoralchik]

(AGAIN) Resolved by merging the latest main to the branch
thank you for noticing it
typescript error in failing checks comes from 9bf7f0d commit

[Amoralchik]

This a little reminder that you can start reviewing @c3024

[Amoralchik]

Resolved a small conflict in ReportUtils, updated to latest main

[rushatgabhane]

@c3024 all yours

[Amoralchik]

Resolved a small conflict in HTMLEngineProviderComponentList and BaseHTMLEngineProvider, updated to the latest main

[Amoralchik]

Resolved a conflict by updating to the latest main

[Amoralchik]

Resolved a conflict by updating to the latest main, again

[Amoralchik]

Resolved a conflict by updating to the latest main
Moved "!['submitExpense', 'trackExpense', 'startChat', 'splitExpense'].includes(task.type)," from Report.ts to ReportUtils.ts due to new conditions