Skip to content

Fix: Auto-scroll to bottom after tracking expense #57901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 2 commits into from
Mar 12, 2025
Merged

Fix: Auto-scroll to bottom after tracking expense #57901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61109c9
Fix: Auto-scroll to bottom after tracking expense
huult Mar 6, 2025
e86aff0
remove direct call scroll to bottom
huult Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ function ReportActionsList({
const [accountID] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.accountID});
const participantsContext = useContext(PersonalDetailsContext);

const [isScrollToBottomEnabled, setIsScrollToBottomEnabled] = useState(false);

useEffect(() => {
const unsubscriber = Visibility.onVisibilityChange(() => {
setIsVisible(Visibility.isVisible());
Expand Down Expand Up @@ -458,10 +460,11 @@ function ReportActionsList({
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
return;
}
reportScrollManager.scrollToBottom();

setIsScrollToBottomEnabled(true);
});
},
[reportScrollManager, report.reportID],
[report.reportID],
);
useEffect(() => {
// Why are we doing this, when in the cleanup of the useEffect we are already calling the unsubscribe function?
Expand Down Expand Up @@ -667,8 +670,12 @@ function ReportActionsList({
const onLayoutInner = useCallback(
(event: LayoutChangeEvent) => {
onLayout(event);
if (isScrollToBottomEnabled) {
reportScrollManager.scrollToBottom();
setIsScrollToBottomEnabled(false);
}
},
[onLayout],
[isScrollToBottomEnabled, onLayout, reportScrollManager],
);
const onContentSizeChangeInner = useCallback(
(w: number, h: number) => {
Expand Down
Loading