Add image for search reports help site doc#57905
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@hoangzinh @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://2ed46691.helpdot.pages.dev ⚡️ |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@suneox @ @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Eeek, Pull Bear is assigning C+ here, and this one needs to be internal. |
|
@MonilBhavsar it's all yours! |
MonilBhavsar
left a comment
There was a problem hiding this comment.
This image is not here https://2ed46691.helpdot.pages.dev/articles/new-expensify/getting-started/Using-Reports-in-New-Expensify
Is it supposed to be displayed here or any other page? Are we missing linking the image to the doc?
lydiabarclay
left a comment
There was a problem hiding this comment.
I have the same question as @MonilBhavsar, I'm not seeing the image in the updated article? https://2ed46691.helpdot.pages.dev/articles/new-expensify/getting-started/Using-Reports-in-New-Expensify
|
This is just a PR to add the image to the assets folder - the PR to add the images to the article is here but it's on hold for this PR as the image won't display correctly until it's added to the folder. |
|
Curious why we are not doing in a single PR? 😅 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.12-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀
|
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/473578
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined