Merged
Conversation
Beamanator
commented
Mar 7, 2025
| 2. `npm run pod-install` (if you build iOS) | ||
| 3. `npm run ios` or `npm run android` | ||
| If you encounter any problems, please refer to the [[#Pro Tips & Troubleshooting]] section, or (if you don't find your answer there) remove the cache by executing `npm run clean` | ||
| If you encounter any problems, please refer to the [[Pro Tips & Troubleshooting](#pro-tips-and-troubleshooting)] section, or (if you don't find your answer there) remove the cache by executing `npm run clean` |
Contributor
Author
There was a problem hiding this comment.
I believe we wanted this to be a link, and now it's linkable!
cristipaval
approved these changes
Mar 7, 2025
Contributor
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.11-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Noticed a few things that could be improved while using this doc to build the hybrid app
Fixed Issues
$ N/A
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop