Fix: small gap underneath chat report header by martasudol · Pull Request #58296 · Expensify/App

martasudol · 2025-03-12T15:36:12Z

Explanation of Change

This PR fixes the issue with gap underneath chat report header.

Fixed Issues

$#58284

Tests

Navigate to any report with messages.
You should see no gap underneath chat report header.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-12T16:01:09Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/LoadingBar.tsx

joekaufmanexpensify · 2025-03-12T16:21:43Z

I'm going to reassign this to @dukenv0307 as this is a regression from a PR they reviewed last week.

src/components/LoadingBar.tsx

github-actions · 2025-03-12T16:51:48Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

dukenv0307 · 2025-03-12T16:56:53Z

Reviewing...

dukenv0307 · 2025-03-12T17:16:30Z

I think we should find a better solution, we can easily see the gap in iOS

Screen.Recording.2025-03-13.at.00.12.48.mov

martasudol · 2025-03-12T17:22:03Z

@dukenv0307 could you please retest on the newest version?

shawnborton · 2025-03-13T08:00:41Z

This is super minor but I could have sworn we wanted the green loader to be sitting right on top of the bottom border of the report header? Right now it sits directly below the header... so I think it needs to move up by 1px (like if it had top: -1px it would be better):

Is that your take too @Expensify/design ?

shawnborton · 2025-03-13T08:01:16Z

Also I could have sworn we don't want the edges on the loader to be round either... they do appear slightly round?

Feels like maybe some styles got reverted at some point perhaps?

martasudol · 2025-03-13T09:19:04Z

@shawnborton that looks reasonable to improve. I'll remove rounded edges and move it up. Update soon!

shawnborton · 2025-03-13T09:20:24Z

Thank you!

martasudol · 2025-03-13T12:30:01Z

@shawnborton could you please retest it? 🙏

github-actions · 2025-03-13T14:28:53Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-13T14:55:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58296/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58296/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/58296/NewExpensify.dmg	https://58296.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-03-13T16:01:57Z

Hmm one thing I am noticing is that there are times when the loader appears on both the LHN and the chat pane on desktop. I thought the idea was that the loader ONLY appears on the LHN on desktop when on the Inbox tab. @martasudol do you know if anything changed in that regard? @nkdengineer is that how you first implemented this?

shawnborton · 2025-03-13T16:03:50Z

src/styles/index.ts

+            width: '100%',
+            position: 'absolute',
+            top: 'auto',
+            bottom: -0.5,


Sorry, this should be -1px and not a half pixel value.

The chat header has a bottom border with a height of 1px. Therefore, if we want the element to align in the middle of the border, we need to set it to -0.5px. Let me attach screenshots to show the difference.

With -0.5px:

With -1px:

Yeah, understood, but I don't think we want the half pixel. I think -1px makes sense but I can't remember what we were doing before. Can you check for us and let us know?

dannymcclain · 2025-03-13T16:07:08Z

I thought the idea was that the loader ONLY appears on the LHN on desktop when on the Inbox tab.

Same.

shawnborton · 2025-03-13T16:08:48Z

@martasudol I see that this PR has a bunch of logic changes and things like that. Could we first just fix the 2px gap we are seeing, and then you can revisit with all of these other code changes? I would love to get this fixed ASAP since it is going to appear slightly broken for all NewDot users.

martasudol · 2025-03-13T16:15:28Z

Hmm one thing I am noticing is that there are times when the loader appears on both the LHN and the chat pane on desktop. I thought the idea was that the loader ONLY appears on the LHN on desktop when on the Inbox tab. @martasudol do you know if anything changed in that regard? @nkdengineer is that how you first implemented this?

The logic for the loading bar in LHN has not been changed. Of course, we can modify this, but all the changes related to loading states (not only in this PR but also in all previous ones) are related only to report view, not LHN. As discussed with @adhorodyski, improving the loading states in LHN would be addressed in the near future.

I think it's a valid point, however not related to this issue. What do you think?

shawnborton · 2025-03-13T16:17:45Z

Hmm I have never seen it before, hence why I bring it up. Only once I used the adhoc build from this PR did I start seeing the two loaders...

shawnborton · 2025-03-13T16:18:23Z

Maybe a better approach is to just revert whatever PR caused the gap in the first place then?

martasudol · 2025-03-13T16:30:19Z

Hmm I have never seen it before, hence why I bring it up. Only once I used the adhoc build from this PR did I start seeing the two loaders...
I see it also on staging. Take a look 👇
https://github.com/user-attachments/assets/f174b374-4a79-4860-ba28-6c973829ff30

shawnborton · 2025-03-13T16:31:30Z

Hmm interesting, I could have sworn we never implemented it this way. @nkdengineer can you please confirm? I'd like to get to the bottom of this one.

shawnborton · 2025-03-13T16:32:24Z

Maybe a better approach is to just revert whatever PR caused the gap in the first place then?

@martasudol curious what you think about this comment here though ^ this way we can approach these kinds of changes with more time and patience. But right now this is going to make its way to production, as I don't think this was marked as a deploy blocker.

martasudol · 2025-03-13T16:47:11Z

Maybe a better approach is to just revert whatever PR caused the gap in the first place then?

@martasudol curious what you think about this comment here though ^ this way we can approach these kinds of changes with more time and patience. But right now this is going to make its way to production, as I don't think this was marked as a deploy blocker.

Ok, makes sense. Let's do that 👌

shawnborton · 2025-03-13T18:19:17Z

Okay, are you able to prepare the revert? Apologies as I'm not too familiar with how that process works. Can you link the offending PR here though for posterity and I will ask internally? Thanks!

nkdengineer · 2025-03-14T08:55:27Z

Hmm interesting, I could have sworn we never implemented it this way. @nkdengineer can you please confirm? I'd like to get to the bottom of this one.

What can I help here?

shawnborton · 2025-03-14T09:06:48Z

No worries, Marta is on top of it.

nkdengineer · 2025-03-14T10:20:27Z

Got it.

dukenv0307 · 2025-03-18T02:59:11Z

@martasudol any updates?

martasudol · 2025-03-18T06:21:18Z

@dukenv0307 I'm closing this PR as the issue was fixed by reverting PR causing it.

martasudol added 3 commits March 12, 2025 16:20

Fix: small gap underneath chat report header

eaac5c7

Fix: small gap underneath chat report header

054e438

Prettier fix

1cf9950

martasudol marked this pull request as ready for review March 12, 2025 16:01

martasudol requested review from a team as code owners March 12, 2025 16:01

melvin-bot bot requested a review from jjcoffee March 12, 2025 16:01

melvin-bot bot removed the request for review from a team March 12, 2025 16:01

martasudol mentioned this pull request Mar 12, 2025

[$250] Small Gap Underneath Chat Report Header on iOS #58284

Closed

8 tasks

shawnborton reviewed Mar 12, 2025

View reviewed changes

src/components/LoadingBar.tsx Outdated Show resolved Hide resolved

Prettier fix

d255b9f

shawnborton reviewed Mar 12, 2025

View reviewed changes

src/components/LoadingBar.tsx Outdated Show resolved Hide resolved

joekaufmanexpensify requested review from dukenv0307 and removed request for jjcoffee March 12, 2025 16:21

Prettier fix

e4f8d0a

shawnborton added the Ready To Build label Mar 12, 2025

Prettier fix

170b38a

martasudol commented Mar 12, 2025

View reviewed changes

src/components/LoadingBar.tsx Show resolved Hide resolved

Prettier fix

867cbb0

Prettier fix

7a90cb8

This comment has been minimized.

Sign in to view

Modified rounded edges and position of loading bar

b0fe121

shawnborton reviewed Mar 13, 2025

View reviewed changes

martasudol closed this Mar 18, 2025

Conversation

martasudol commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 12, 2025

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2025

Uh oh!

dukenv0307 commented Mar 12, 2025

Uh oh!

dukenv0307 commented Mar 12, 2025

Uh oh!

martasudol commented Mar 12, 2025

Uh oh!

This comment has been minimized.

shawnborton commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

martasudol commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

martasudol commented Mar 13, 2025

Uh oh!

github-actions bot commented Mar 13, 2025

Uh oh!

github-actions bot commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

shawnborton Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

martasudol Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

martasudol Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

shawnborton Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

martasudol commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

martasudol commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

martasudol commented Mar 13, 2025

Uh oh!

shawnborton commented Mar 13, 2025

Uh oh!

nkdengineer commented Mar 14, 2025

Uh oh!

shawnborton commented Mar 14, 2025

Uh oh!

nkdengineer commented Mar 14, 2025

martasudol commented Mar 12, 2025 •

edited

Loading