Fix MentionSuggestions gap in android #58488

zirgulis · 2025-03-14T14:39:07Z

Explanation of Change

On Android devices, when editing mentions in a room chat, there is a large space displayed between the mention suggestions popup and the composer. This gap is inconsistent across different Android devices, with some devices (particularly Pixel phones) showing a significantly larger gap than others (like Samsung devices).

Implement an adaptive solution in getBottomSuggestionPadding/index.android.ts that calculates appropriate padding based on the device's aspect ratio.

Fixed Issues

$ #57734
PROPOSAL: #57734 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open the Expensify app.
Open any room chat or create one if necessary.
Send a mention of any user that is not part of the room.
Send another mention of a different user that is not part of the room.
Return to inbox and open room again, so the system message for the first mention, appears again.
With the keyboard opened, long tap over the second mention and select "Edit Message"
Check the gap displayed between the mentions suggestions box and the edition composer.
Suggestions box should be displayed above the edition composer, without a big space in between.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-14T14:39:13Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…to fix/android-suggestions-gap

jjcoffee · 2025-03-14T18:37:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2025-04-01_16.12.54.mp4

Android: mWeb Chrome

android-chrome-2025-04-01_16.17.41.mp4

iOS: Native

ios-app-2025-04-01_16.35.02.mp4

iOS: mWeb Safari

ios-safari-2025-04-01_16.37.53.mp4

MacOS: Chrome / Safari

desktop-chrome-2025-04-01_16.10.36.mp4

MacOS: Desktop

desktop-app-2025-04-01_16.20.04.mp4

jjcoffee · 2025-03-14T18:38:44Z

@zirgulis Thanks! Would you be able to add screenshots for other platforms, just for completeness?

zirgulis · 2025-03-14T19:23:27Z

@zirgulis Thanks! Would you be able to add screenshots for other platforms, just for completeness?

@jjcoffee is it required, though? This change only affects Android native. Other platforms are not affected

jjcoffee · 2025-03-14T19:37:04Z

is it required, though? This change only affects Android native. Other platforms are not affected

Usually, yes! I understand it's a bit annoying to do when you know for sure that the changes only affect one platform, but my understanding is we always enforce it to ensure there isn't some edge case where other platforms are unexpectedly affected.

jjcoffee · 2025-03-18T09:07:36Z

@zirgulis Any thoughts on this?

zirgulis · 2025-03-18T14:01:54Z

@jjcoffee I found some issues with the current approach, working on a fix, will ping you here in a few hours

zirgulis · 2025-03-19T09:42:30Z

@jjcoffee could you please have another look? I've added some fixes

jjcoffee · 2025-03-19T16:24:09Z

Thanks, I'll retest tomorrow!

zirgulis · 2025-03-20T21:27:37Z

@jjcoffee hmmm this is what I see on my end:

Could you please try running:

git clean -fxd
npm i
npm run android

This should make sure that there's no cached files and it should pickup the latest code changes

zirgulis · 2025-03-21T10:25:20Z

@jjcoffee I added a commit with some console.logs for debugging. Could you please share what you get printed out?

jjcoffee · 2025-03-21T14:06:44Z

@zirgulis Here ya go:

windowHeight 890.2857142857143 - (cursorCoordinates.y 27.809524536132812 - scrollValue 0 + y 793.5238647460938) - keyboardHeight -24 = 92.95232500348777
getBottomSuggestionPadding height 890.285714
AutoCompleteSuggestionsPortal bottomPadding 30
AutoCompleteSuggestionsPortal bottom + bottomPadding 122.952325

zirgulis · 2025-03-24T16:27:57Z

@jjcoffee thank you so much for the details! I've made some fixes, could you please check again if it works on your end?

jjcoffee · 2025-03-25T15:37:17Z

Thanks, I'll retest tomorrow!

jjcoffee · 2025-03-26T15:00:27Z

@zirgulis Nice, that's much better!

One slight issue still, once the . is entered for the mention, the positioning adjusts and is too close to the input.

android-app-2025-03-26_15.58.47.mp4

zirgulis · 2025-03-27T16:00:45Z

@zirgulis Nice, that's much better!

One slight issue still, once the . is entered for the mention, the positioning adjusts and is too close to the input.

android-app-2025-03-26_15.58.47.mp4

@jjcoffee yes that bug is also present on iOS:

This happens because cursorCoordinates.y returns a higher value which makes bottomValue smaller thus decreases the gap whenever the text input becomes multiline.

I think we can live with this since this seems like a corner case. In order to fix this we would need to do an extensive refactoring of all the code related to AutoCompleteSuggestions.

jjcoffee · 2025-03-28T16:49:05Z

@zirgulis Okay thanks for confirming, that's fine if it's an existing bug.

jjcoffee · 2025-03-28T16:49:53Z

...ompleteSuggestions/AutoCompleteSuggestionsPortal/getBottomSuggestionPadding/index.android.ts

+function getBottomSuggestionPadding(bottom: number): number {    
+    const {height} = Dimensions.get('window');
+
+    const bottomPercentageToHeight = (bottom / height) * 100;


@zirgulis Could you add some explanatory comments here? There's a lot of magic numbers that future devs won't know what to do with 😄

@jjcoffee done!

jjcoffee · 2025-04-01T13:21:29Z

@zirgulis Prettier is failing.

zirgulis · 2025-04-01T14:11:54Z

@zirgulis Prettier is failing.

@jjcoffee fixed

jjcoffee · 2025-04-01T14:53:20Z

iOS seems to have the same bug as in the original issue:

ios-app-2025-04-01_16.35.02.mp4

zirgulis · 2025-04-02T11:55:41Z

iOS seems to have the same bug as in the original issue:

ios-app-2025-04-01_16.35.02.mp4

@jjcoffee The original issue is in regards to android, therefore the fix in this PR is focusing on android platform. Do we need another task for iOS? when can we merge this PR?

jjcoffee · 2025-04-02T12:58:33Z

@zirgulis I think QA may just not have tested on all platforms. If the fix has the same RCA, we might be better off doing it in this PR, but if it's more complicated I agree it could be a followup.

jjcoffee

LGTM for Android 👍

Approving to get a CME assigned to see whether or not we should create a separate issue to fix iOS, since it wasn't brought up in the original issue, and this has dragged on for a while already! cc @cead22

melvin-bot · 2025-04-02T13:00:02Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #57734 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

cead22 · 2025-04-03T00:55:55Z

Whoops ok I just read all the comments. I think it's up to you if you wanna fix iOS in this PR. That's what I'd recommend but not opposed to doing it in a separate PR

cead22 · 2025-04-03T00:58:09Z

src/components/AutoCompleteSuggestions/index.tsx

            const contentMaxHeight = measureHeightOfSuggestionRows(suggestionsLength, true);
            const contentMinHeight = measureHeightOfSuggestionRows(suggestionsLength, false);
            let bottomValue = windowHeight - (cursorCoordinates.y - scrollValue + y) - keyboardHeight;
+


Suggested change

cead22 · 2025-04-03T00:58:23Z

src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/index.native.tsx

    const StyleUtils = useStyleUtils();
-    const styles = useMemo(() => StyleUtils.getBaseAutoCompleteSuggestionContainerStyle({left, width, bottom: bottom + getBottomSuggestionPadding()}), [StyleUtils, left, width, bottom]);
+    const bottomPadding = Platform.OS === 'android' ? (getBottomSuggestionPadding as GetBottomSuggestionPaddingAndroid)(bottom) : getBottomSuggestionPadding();
+


Suggested change

cead22 · 2025-04-03T00:59:06Z

src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/index.native.tsx

 function AutoCompleteSuggestionsPortal<TSuggestion>({left = 0, width = 0, bottom = 0, resetSuggestions = () => {}, ...props}: AutoCompleteSuggestionsPortalProps<TSuggestion>) {
    const StyleUtils = useStyleUtils();
-    const styles = useMemo(() => StyleUtils.getBaseAutoCompleteSuggestionContainerStyle({left, width, bottom: bottom + getBottomSuggestionPadding()}), [StyleUtils, left, width, bottom]);
+    const bottomPadding = Platform.OS === 'android' ? (getBottomSuggestionPadding as GetBottomSuggestionPaddingAndroid)(bottom) : getBottomSuggestionPadding();


I thought we weren't supposed to do this Platform.OS === 'android'. Is this allowed in index.native.tsx files?

@cead22 I think in this case it's ok to have this check since the platform-specific difference is minimal. Creating a separate index.ios.tsx would result in significant code duplication

Why's that? We're already importing getBottomSuggestionPadding, can't we make that platform specific?

@cead22 getBottomSuggestionPadding is platform specific, but we pass bottom param only to the android version of getBottomSuggestionPadding, therefore there's Platform.OS === 'android' check

Can we create a getBottomSuggestionPadding for ios and use that here? If not, can you elaborate on why we'd need a lot of duplicate code?

@cead22 we already have getBottomSuggestionPadding for iOS here

However we only need bottom param for the getBottomSuggestionPadding/index.android.ts , that's why I added Platform.OS === 'android' check so we would only pass bottom param to getBottomSuggestionPadding function in android file

Could we pass the param to the iOS function and do nothing with it, so we can simplify this code?

@cead22 yes, added that in my latest commit

jjcoffee · 2025-04-07T09:35:16Z

Friendly bump @zirgulis on @cead22's comments.

zirgulis · 2025-04-07T09:59:29Z

@jjcoffee @cead22 regarding the iOS: we should create a separate task for that. I checked last week what's going on iOS and the fix might not be so straightforward and might affect other platforms. For iOS the issue is when the measureParentContainerAndReportCursor kicks in. @cead22 if someone from Expensify team could create an issue for it I would be happy to work on it

OSBotify · 2025-04-09T17:10:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-10T01:19:50Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.1.26-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2025-04-10T15:42:47Z

Failing on iOS with original bug id #57734

https://platform.applause.com/services/links/v1/external/c7bc4645a8615e8c28bee4a39fbd7374aedb03c766c188149c4d08ec6292129c

jasperhuangg · 2025-04-10T21:49:30Z

@kavimuru That is unrelated to the original issue as it only deals with Android. Is there an existing issue for this, or can we create one to track the iOS version of this problem?

github-actions · 2025-04-11T00:04:42Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.26-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix suggestions gap in android

bc6e46a

zirgulis requested a review from a team as a code owner March 14, 2025 14:39

melvin-bot bot requested review from jjcoffee and removed request for a team March 14, 2025 14:39

zirgulis mentioned this pull request Mar 14, 2025

[Due for payment 2025-04-18] [$250] Android - Room -When editing mention, big space is displayed between suggestion and composer #57734

Closed

8 tasks

zirgulis added 2 commits March 14, 2025 16:50

fix prettier

564b31b

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

124d951

…to fix/android-suggestions-gap

This comment was marked as resolved.

Sign in to view

fix padding for tall android screens

6d97db0

fix prettier

033c902

This comment was marked as resolved.

Sign in to view

add debug console logs

967bcfe

add check for bottom percentage to height

951143a

jjcoffee reviewed Mar 28, 2025

View reviewed changes

add comments

cce136a

fix prettier

4dde28e

jjcoffee approved these changes Apr 2, 2025

View reviewed changes

melvin-bot bot requested a review from cead22 April 2, 2025 13:00

This comment was marked as resolved.

Sign in to view

cead22 reviewed Apr 3, 2025

View reviewed changes

remove line gaps

795e2b8

add bottom param for all platforms

a054394

cead22 approved these changes Apr 9, 2025

View reviewed changes

cead22 merged commit 0209727 into Expensify:main Apr 9, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 10, 2025

Deploy Checklist: New Expensify 2025-04-10 #59968

Closed

65 tasks

jjcoffee mentioned this pull request Apr 17, 2025

Inline auto suggestion #42630

Merged

50 tasks

Fix MentionSuggestions gap in android #58488

Fix MentionSuggestions gap in android #58488

Uh oh!

Conversation

zirgulis commented Mar 14, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 14, 2025

Uh oh!

jjcoffee commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Mar 14, 2025

Uh oh!

zirgulis commented Mar 14, 2025

Uh oh!

jjcoffee commented Mar 14, 2025

Uh oh!

This comment was marked as resolved.

jjcoffee commented Mar 18, 2025

Uh oh!

zirgulis commented Mar 18, 2025

Uh oh!

zirgulis commented Mar 19, 2025

Uh oh!

jjcoffee commented Mar 19, 2025

Uh oh!

This comment was marked as resolved.

zirgulis commented Mar 20, 2025

Uh oh!

This comment was marked as resolved.

zirgulis commented Mar 21, 2025

Uh oh!

jjcoffee commented Mar 21, 2025

Uh oh!

zirgulis commented Mar 24, 2025

Uh oh!

jjcoffee commented Mar 25, 2025

Uh oh!

jjcoffee commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zirgulis commented Mar 27, 2025

Uh oh!

jjcoffee commented Mar 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Apr 1, 2025

Uh oh!

zirgulis commented Apr 1, 2025

Uh oh!

jjcoffee commented Apr 1, 2025

Uh oh!

zirgulis commented Apr 2, 2025

Uh oh!

jjcoffee commented Apr 2, 2025

Uh oh!

jjcoffee left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Apr 2, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

cead22 commented Apr 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Mar 14, 2025 •

edited

Loading

jjcoffee commented Mar 26, 2025 •

edited

Loading

jjcoffee left a comment •

edited

Loading

jasperhuangg commented Apr 10, 2025 •

edited

Loading