Skip to content

fix: Completed task does not show strikethrough style. #58629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariaHCD merged 5 commits into from
Apr 10, 2025
Merged

fix: Completed task does not show strikethrough style. #58629

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
024ae7a
fix: Completed task does not show strikethrough style.
Krishna2323 Mar 18, 2025
5b4dd96
fix: Chat - Bold markdown is not applied for url.
Krishna2323 Mar 18, 2025
d77744b
Merge branch 'main' into krishna2323/issue/58265
Krishna2323 Apr 5, 2025
6bc2458
remove duplicate styles.
Krishna2323 Apr 5, 2025
f5185e8
Merge branch 'Expensify:main' into krishna2323/issue/58265
Krishna2323 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/ReportActionItem/TaskPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ function TaskPreview({
return <RenderHTML html={`<deleted-action>${translate('parentReportAction.deletedTask')}</deleted-action>`} />;
}

const getTaskHTML = () => {
Copy link
Collaborator

@mananjadhav mananjadhav Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to use useMemo?

Copy link
Contributor Author

@Krishna2323 Krishna2323 Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any value in adding useMemo here. I think we can use useMemo on line 70. WDYT?

const taskTitleWithoutImage = Parser.replace(Parser.htmlToMarkdown(taskTitle), {disabledRules: [...CONST.TASK_TITLE_DISABLED_RULES]});

if (isTaskCompleted) {
return `<del><comment center>${taskTitleWithoutImage}</comment></del>`;
}

return `<comment center>${taskTitleWithoutImage}</comment>`;
};

return (
<View style={[styles.chatItemMessage, !hasAssignee && styles.mv1]}>
<PressableWithoutFeedback
Expand Down Expand Up @@ -149,7 +157,7 @@ function TaskPreview({
</UserDetailsTooltip>
)}
<View style={[styles.alignSelfCenter, styles.flex1]}>
<RenderHTML html={`<comment center>${taskTitleWithoutImage}</comment>`} />
<RenderHTML html={getTaskHTML()} />
</View>
</View>
{shouldShowGreenDotIndicator && (
Expand Down
Loading