Skip to content

[CP Staging] Revert "[CP Staging] fix: blocked scrolling event in reports list"#58675

Merged
jasperhuangg merged 1 commit intomainfrom
revert-58219-fix-blocked-scrolling-event-in-reports-list
Mar 19, 2025
Merged

[CP Staging] Revert "[CP Staging] fix: blocked scrolling event in reports list"#58675
jasperhuangg merged 1 commit intomainfrom
revert-58219-fix-blocked-scrolling-event-in-reports-list

Conversation

@jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Mar 19, 2025

Reverts #58219

$ #58672

@github-actions
Copy link
Contributor

🚧 @jasperhuangg has triggered a test app build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58675/index.html
The QR code can't be generated, because the Android build failed iOS
Android Hybrid 🤖🔄 iOS Hybrid 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58675-hybrid/index.html
Android Hybrid iOS Hybrid
Desktop 💻 Web 🕸️
❌ FAILED ❌ ❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

@jasperhuangg jasperhuangg marked this pull request as ready for review March 19, 2025 03:12
@jasperhuangg jasperhuangg requested a review from a team as a code owner March 19, 2025 03:12
@jasperhuangg
Copy link
Contributor Author

Verified this fixes this issue via AdHoc build

@melvin-bot melvin-bot bot requested review from dangrous and removed request for a team March 19, 2025 03:12
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2025

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg jasperhuangg self-assigned this Mar 19, 2025
@jasperhuangg jasperhuangg changed the title Revert "[CP Staging] fix: blocked scrolling event in reports list" [CP Staging] Revert "[CP Staging] fix: blocked scrolling event in reports list" Mar 19, 2025
@jasperhuangg jasperhuangg merged commit 01058e8 into main Mar 19, 2025
14 of 18 checks passed
@jasperhuangg jasperhuangg deleted the revert-58219-fix-blocked-scrolling-event-in-reports-list branch March 19, 2025 03:51
@melvin-bot melvin-bot bot added the Emergency label Mar 19, 2025
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2025

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@jasperhuangg
Copy link
Contributor Author

Straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Mar 19, 2025
…olling-event-in-reports-list

[CP Staging] Revert "[CP Staging] fix: blocked scrolling event in reports list"

(cherry picked from commit 01058e8)

(CP triggered by jasperhuangg)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 19, 2025
@github-actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.1.15-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.15-9 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Ready To Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants