Skip to content

Wallet bank account popover has extra space #58747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 4 commits into from
Mar 25, 2025
Merged

Wallet bank account popover has extra space #58747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
544539a
Wallet bank account popover has extra space
dukenv0307 Mar 19, 2025
d0dae0c
Merge branch 'main' into fix/57774
dukenv0307 Mar 19, 2025
376685c
clean code
dukenv0307 Mar 19, 2025
d544e9d
Merge branch 'main' into fix/57774
dukenv0307 Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/pages/settings/Wallet/WalletPage/WalletPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,16 @@ function WalletPage({shouldListenForResize = false}: WalletPageProps) {
anchorRef={paymentMethodButtonRef as RefObject<View>}
>
{!showConfirmDeleteModal && (
<View style={[styles.mv5, !shouldUseNarrowLayout ? styles.sidebarPopover : {}]}>
<View
style={[
!shouldUseNarrowLayout
? {
...styles.sidebarPopover,
...styles.pv4,
}
: styles.pt5,
]}
>
{isPopoverBottomMount && (
<MenuItem
title={paymentMethod.formattedSelectedPaymentMethod.title}
Expand Down Expand Up @@ -668,7 +677,16 @@ function WalletPage({shouldListenForResize = false}: WalletPageProps) {
}}
anchorRef={paymentMethodButtonRef as RefObject<View>}
>
<View style={[styles.mv5, !shouldUseNarrowLayout ? styles.sidebarPopover : {}]}>
<View
style={[
!shouldUseNarrowLayout
? {
...styles.sidebarPopover,
...styles.pv4,
}
: styles.pt5,
]}
>
{isPopoverBottomMount && (
<MenuItem
title={paymentMethod.formattedSelectedPaymentMethod.title}
Expand Down
11 changes: 10 additions & 1 deletion src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,16 @@ function WorkspaceInvoiceVBASection({policyID}: WorkspaceInvoiceVBASectionProps)
anchorRef={paymentMethodButtonRef as RefObject<View>}
>
{!showConfirmDeleteModal && (
<View style={[styles.mv5, !shouldUseNarrowLayout ? styles.sidebarPopover : {}]}>
<View
style={[
!shouldUseNarrowLayout
? {
...styles.sidebarPopover,
...styles.pv4,
}
: styles.pt5,
]}
>
{isPopoverBottomMount && (
<MenuItem
title={paymentMethod.formattedSelectedPaymentMethod.title}
Expand Down