Skip to content

fix(translation): show correct error message for bank account flow #58764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinpersaud merged 5 commits into from
Apr 1, 2025
Merged

fix(translation): show correct error message for bank account flow #58764

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dba1693
fix(translation): show correct error message for bank account flow
jaydamani Mar 19, 2025
1fbdf84
prettier
jaydamani Mar 19, 2025
fda176f
make max attempt error non dismissable
jaydamani Mar 26, 2025
ea2a6f2
Merge branch 'main' into translation/show-too-many-attempts-error-for…
jaydamani Mar 29, 2025
67531a8
add margin for error message
jaydamani Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import ValidateCodeActionModal from '@components/ValidateCodeActionModal';
import useLocalize from '@hooks/useLocalize';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import {getEarliestErrorField, getLatestError, getLatestErrorField} from '@libs/ErrorUtils';
import {getEarliestErrorField, getLatestError, getLatestErrorField, getMicroSecondOnyxErrorWithTranslationKey} from '@libs/ErrorUtils';
import getPlaidDesktopMessage from '@libs/getPlaidDesktopMessage';
import {REIMBURSEMENT_ACCOUNT_ROUTE_NAMES} from '@libs/ReimbursementAccountUtils';
import WorkspaceResetBankAccountModal from '@pages/workspace/WorkspaceResetBankAccountModal';
Expand Down Expand Up @@ -219,8 +219,12 @@ function VerifiedBankAccountFlowEntryPoint({
)}
{shouldShowContinueSetupButton === true ? (
<OfflineWithFeedback
errors={getLatestError(errors)}
errors={
reimbursementAccount?.maxAttemptsReached ? getMicroSecondOnyxErrorWithTranslationKey('connectBankAccountStep.maxAttemptsReached') : getLatestError(errors)
}
errorRowStyles={styles.mt2}
shouldShowErrorMessages
canDismissError={!reimbursementAccount?.maxAttemptsReached}
Copy link
Contributor

@justinpersaud justinpersaud Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Expensify/design what do you think about this change? This is making the error persistent and not allowing you to dismiss it. I'd argue that you can dismiss the error after you've seen it, then that is on you because you saw it and dismissed it. The error will still be presented when they try to setup the bank account again on a different screen.

Copy link
Contributor

@shawnborton shawnborton Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I don't feel too strongly. Normally we allow users to dismiss the error, although in this case, if you dismiss the error, the buttons would still be disabled which might feel weird right?

Copy link
Contributor

@shawnborton shawnborton Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think I would keep it there as not dismissable. What makes it so that you can log in again though?

Copy link
Contributor

@justinpersaud justinpersaud Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for adding a bank account. So in this case, we're showing an error because they've already failed too many times to add a bank account, and their next step is to reach out to Concierge.

If they dismiss the error, they can go through the flow again but then they'll hit the same error page. I think in that case, making it non dismissable is fine since the outcome is the same, right?

onClose={resetReimbursementAccount}
>
<MenuItem
Expand Down