-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add QA message for new deploys #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/android.yml
Outdated
| channel: '#qa', | ||
| attachments: [{ | ||
| color: "#39AA56", | ||
| text: `${process.env.AS_WORKFLOW} version *${{ env.VERSION }}* was deployed 🚀`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the screenshot in the PR description this results in saying "eslint version was deployed" which is sure a bit odd. I'm not really sure where AS_WORKFLOW is coming from, but maybe changing the message to say that "Expensify Chat version was deployed" would be better?
Also, the message isn't very actionable. Is there a way that we can link to the regression tests and then add that to the message like "Expensify Chat version 1.2.3 was deployed. Please begin regression testing." and the words "regression testing" would be a link to the tests they will be running. If we don't have a link, that's OK as just adding those action words is more helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AS_WORKFLOW will be the github action's name, so it will be: Build and Deploy Android for this example. This is the same thing we do for the failed build notifications.
Yes, I can add a bit about regression testing 👍
|
Thanks for adding the links! I still think it will get confusing without calling out that it's Expensify-Chat specifically, but we can wait to see if that is indeed a problem first or not. |
@tgolen - Will you please review?
Adds QA deploy message in #qa
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/142698
Tests
I tested in
#andrew-test, but we will have a bit of testing on production for this as I haven't run the deploy scripts.