Skip to content

Conversation

@AndrewGable
Copy link
Contributor

@tgolen - Will you please review?

Adds QA deploy message in #qa

Screen Shot 2020-10-02 at 5 25 43 PM

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/142698

Tests

I tested in #andrew-test, but we will have a bit of testing on production for this as I haven't run the deploy scripts.

@AndrewGable AndrewGable requested a review from tgolen as a code owner October 3, 2020 00:26
@AndrewGable AndrewGable self-assigned this Oct 3, 2020
channel: '#qa',
attachments: [{
color: "#39AA56",
text: `${process.env.AS_WORKFLOW} version *${{ env.VERSION }}* was deployed 🚀`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the screenshot in the PR description this results in saying "eslint version was deployed" which is sure a bit odd. I'm not really sure where AS_WORKFLOW is coming from, but maybe changing the message to say that "Expensify Chat version was deployed" would be better?

Also, the message isn't very actionable. Is there a way that we can link to the regression tests and then add that to the message like "Expensify Chat version 1.2.3 was deployed. Please begin regression testing." and the words "regression testing" would be a link to the tests they will be running. If we don't have a link, that's OK as just adding those action words is more helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS_WORKFLOW will be the github action's name, so it will be: Build and Deploy Android for this example. This is the same thing we do for the failed build notifications.

Yes, I can add a bit about regression testing 👍

@AndrewGable AndrewGable requested a review from tgolen October 5, 2020 17:26
@tgolen
Copy link
Contributor

tgolen commented Oct 5, 2020

Thanks for adding the links! I still think it will get confusing without calling out that it's Expensify-Chat specifically, but we can wait to see if that is indeed a problem first or not.

@tgolen tgolen merged commit b76bd79 into master Oct 5, 2020
@tgolen tgolen deleted the andrew-qa branch October 5, 2020 18:40
@MelvinBot MelvinBot mentioned this pull request Jan 29, 2024
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants