[CP Staging] Receipt - Unable to replace receipt and page stucks by WojtekBoman · Pull Request #58901 · Expensify/App

WojtekBoman · 2025-03-21T11:37:35Z

Explanation of Change

During the receipt replacement, two actions are performed:

closing the modal
navigating to the appropriate screen.

The issue is caused by the overlap of these two actions, before the modal had time to close, we tried to perform the Navigation.navigate. Using InteractionManager.runAfterInteractions fixes this problem, the navigating takes place after the modal has closed

Fixed Issues

$ #58814
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Launch app
Tap fab - create a scan expense
Open expense and enter amount and merchant and save
Tap receipt and select replace
Verify if the upload image page has been opened

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-21.at.11.03.29.mov

iOS: Native

Screen.Recording.2025-03-21.at.12.14.27.mov

github-actions · 2025-03-21T11:44:27Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny

Changes look good to me, thanks for the quick follow up

melvin-bot · 2025-03-21T11:45:34Z

@fedirjh @arosiclair One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-03-21T11:46:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

2025-03-21.13.09.53.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

ZhenjaHorbach · 2025-03-21T12:12:37Z

When we press go back button
We navigate to the expense details screen twice

2025-03-21.13.11.41.mov

ZhenjaHorbach · 2025-03-21T12:19:10Z

Hm
But actually I can't reproduce it anymore

github-actions · 2025-03-21T12:19:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58901-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58901-hybrid/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://58901.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

WojtekBoman · 2025-03-21T12:23:00Z

@ZhenjaHorbach Does it happen on the main branch? It seems unrelated to this issue, I think it might be caused by this one Navigation - Repeating navigation after submitting expense and returning via device gesture

ZhenjaHorbach · 2025-03-21T12:27:33Z

@ZhenjaHorbach Does it happen on the main branch? It seems unrelated to this issue, I think it might be caused by this one Navigation - Repeating navigation after submitting expense and returning via device gesture

No
It's a current branch

And yeah
A bit similar case
But in any case I don't have a stable way to reproduce this issue 😅

ZhenjaHorbach · 2025-03-21T12:29:28Z

And judging by the header in the video, we are making navigation to another screen
But the content does not change

2025-03-21.13.31.43.mov

But I think this is not related to our changes !

arosiclair · 2025-03-21T12:57:04Z

And judging by the header in the video, we are making navigation to another screen But the content does not change

But I think this is not related to our changes !

Why not? I'm confused on whether this PR is causing the issue or not.

@WojtekBoman are you able to reproduce that double navigation problem? Is it something you might be able to fix before merging this?

WojtekBoman · 2025-03-21T13:29:48Z

I'll take a look at it

@ZhenjaHorbach Could you write repro steps for this issue? Does it occur on native platforms?

ZhenjaHorbach · 2025-03-21T13:36:15Z

I'll take a look at it

@ZhenjaHorbach Could you write repro steps for this issue? Does it occur on native platforms?

Unfortunately I don't have a stable way to reproduce this

And I was able to reproduce it once on iOS-web

arosiclair

Alright let's merge this

OSBotify · 2025-03-21T14:17:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…chment-modal [CP Staging] Receipt - Unable to replace receipt and page stucks (cherry picked from commit 428bd5c) (CP triggered by mountiny)

github-actions · 2025-03-21T14:51:58Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.16-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-21T16:05:12Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.16-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-21T22:22:35Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Fix navigating after closing attachment modal

e371bd9

mountiny assigned WojtekBoman Mar 21, 2025

mountiny added the Ready To Build label Mar 21, 2025

mountiny requested a review from ZhenjaHorbach March 21, 2025 11:44

mountiny approved these changes Mar 21, 2025

View reviewed changes

WojtekBoman marked this pull request as ready for review March 21, 2025 11:45

WojtekBoman requested a review from a team as a code owner March 21, 2025 11:45

melvin-bot bot requested review from arosiclair and fedirjh and removed request for a team March 21, 2025 11:45

mountiny changed the title ~~Receipt - Unable to replace receipt and page stucks~~ [CP Staging] Receipt - Unable to replace receipt and page stucks Mar 21, 2025

mountiny removed the request for review from fedirjh March 21, 2025 12:02

adamgrzybowski approved these changes Mar 21, 2025

View reviewed changes

ZhenjaHorbach approved these changes Mar 21, 2025

View reviewed changes

arosiclair approved these changes Mar 21, 2025

View reviewed changes

arosiclair merged commit 428bd5c into Expensify:main Mar 21, 2025
18 of 20 checks passed

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 21, 2025

github-actions bot mentioned this pull request Mar 21, 2025

Deploy Checklist: New Expensify 2025-03-20 #58801

Closed

72 tasks

huult mentioned this pull request Mar 23, 2025

[Due for payment 2025-04-10] [$250] mweb-expense-Context menu flickers&shown in create expense page in a workspace chat. #58188

Closed

8 tasks

melvin-bot bot mentioned this pull request Mar 24, 2025

[Due for payment 2025-03-31] Receipt - Unable to replace receipt and page stucks #58814

Closed

8 tasks

bernhardoj mentioned this pull request Apr 10, 2025

[Payment due 4/23][$250] Expense - App is not responsive after closing receipt view on confirmation page #59934

Closed

18 tasks

Conversation

WojtekBoman commented Mar 21, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

WojtekBoman commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arosiclair commented Mar 21, 2025

Uh oh!

WojtekBoman commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

WojtekBoman commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading