[CP Staging] fix: chat jumps to top briefly each time the expense is created by nkdengineer · Pull Request #58904 · Expensify/App

nkdengineer · 2025-03-21T12:32:16Z

Explanation of Change

fix: chat jumps to top briefly each time the expense is created

Fixed Issues

$ #58871
PROPOSAL: #58871 (comment)

Tests

Open a group chat
Create a split bill expense
Create another one
Verify that the report doesn't jump to top briefly

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Open a group chat
Create a split bill expense
Create another one
Verify that the report doesn't jump to top briefly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-21.at.19.26.55.mov

Android: mWeb Chrome

Screen.Recording.2025-03-21.at.19.23.32.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-03-21.at.19.24.48.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-21.at.19.18.03.mov

MacOS: Desktop

Screen.Recording.2025-03-21.at.19.37.32.mov

melvin-bot · 2025-03-21T12:47:31Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Navigation/Navigation.ts

main.jsbundle.map

ZhenjaHorbach · 2025-03-21T13:20:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

2025-03-21.17.49.14.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

ZhenjaHorbach · 2025-03-21T13:34:29Z

Looks like expenses still jump

2025-03-21.14.33.13.mov

nkdengineer · 2025-03-21T13:44:03Z

@ZhenjaHorbach The first jump bug with the error of DISSMISS_MODAL is fixed. I'm not sure what causes another jump, I can also reproduce this jump in production.

Screen.Recording.2025-03-21.at.20.43.21.mov

ZhenjaHorbach · 2025-03-21T13:54:03Z

As I can see in prod everything works good

2025-03-21.14.52.29.mov

ZhenjaHorbach · 2025-03-21T13:56:31Z

Yeah
Current fix looks much better than in staging
But these jumps are still reproduced stably

nkdengineer · 2025-03-21T13:59:23Z

Current fix looks much better than in staging

@ZhenjaHorbach Yes, this jump is different and I can reproduce it in production, you can try to create split bill serval times.

nkdengineer · 2025-03-21T14:00:56Z

Screen.Recording.2025-03-21.at.21.00.37.mov

ZhenjaHorbach · 2025-03-21T14:11:02Z

I still can't reproduce in prod 😅

@WojtekBoman
Could you please try to reproduce this issue in prod?
To make sure

ZhenjaHorbach · 2025-03-21T14:20:09Z

In ios looks like we still have issue with dismissModal

2025-03-21.15.18.48.mov

ZhenjaHorbach · 2025-03-21T14:26:41Z

And we have this issue on native apps
When we press go back after creating split expense
We return to confirm details instead list of chats

2025-03-21.15.23.31.mov

WojtekBoman · 2025-03-21T14:31:54Z

And we have this issue on native apps When we press go back after creating split expense We return to confirm details instead list of chats

2025-03-21.15.23.31.mov

This issue should be fixed by this PR #58908

WojtekBoman · 2025-03-21T14:33:42Z

@ZhenjaHorbach @nkdengineer

I checked the method responsible for scrolling to bottom in ReportActionsList component, could you verify if removing this line fixes this issue for you? Please check the attached video

Screen.Recording.2025-03-21.at.15.29.20.mov

WojtekBoman · 2025-03-21T14:37:48Z

Just to clarify, I don't suggest to remove this line to fix the issue, because it will definitely cause many side effects, but it might be related to the encountered problem

ZhenjaHorbach · 2025-03-21T14:40:09Z

Just to clarify, I don't suggest to remove this line to fix the issue, because it will definitely cause many side effects, but it might be related to the encountered problem

It's okay
Since this issue is reproduce in prod
We can ignore it

WojtekBoman · 2025-03-21T14:41:51Z

In ios looks like we still have issue with dismissModal

2025-03-21.15.18.48.mov

I think it might also be connected with the issue which is fixed by this PR #58904

ZhenjaHorbach · 2025-03-21T14:43:58Z

In ios looks like we still have issue with dismissModal
2025-03-21.15.18.48.mov

I think it might also be connected with the issue which is fixed by this PR #58904

It's true
But I'm in the current branch see this issue😅

ZhenjaHorbach · 2025-03-21T14:55:01Z

In ios looks like we still have issue with dismissModal
2025-03-21.15.18.48.mov

I think it might also be connected with the issue which is fixed by this PR #58904

Here is a wrong link
But if we talk about your PR
It helped !

nkdengineer · 2025-03-21T14:55:14Z

I checked the method responsible for scrolling to bottom in ReportActionsList component, could you verify if removing this line fixes this issue for you? Please check the attached video

I checked and it's fixed

src/pages/home/report/ReportActionsList.tsx

ZhenjaHorbach · 2025-03-21T16:57:56Z

LGTM !

mountiny

Thanks!

[CP Staging] fix: chat jumps to top briefly each time the expense is created (cherry picked from commit 55ec5d2) (CP triggered by luacmartins)

OSBotify · 2025-03-21T17:09:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-21T17:55:59Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-21T22:22:38Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

nkdengineer added 3 commits March 21, 2025 19:29

fix: chat jumps to top briefly each time the expense is created

480e22e

dismiss modal in the case not topmost report

28616b2

remove dev code

381c592

nkdengineer marked this pull request as ready for review March 21, 2025 12:47

nkdengineer requested a review from a team as a code owner March 21, 2025 12:47

melvin-bot bot requested a review from ZhenjaHorbach March 21, 2025 12:47

melvin-bot bot removed the request for review from a team March 21, 2025 12:47

WojtekBoman reviewed Mar 21, 2025

View reviewed changes

src/libs/Navigation/Navigation.ts Outdated Show resolved Hide resolved

update logic for narrow layout

83db96e

ZhenjaHorbach reviewed Mar 21, 2025

View reviewed changes

main.jsbundle.map Outdated Show resolved Hide resolved

remove file

d406f0c

mountiny assigned nkdengineer Mar 21, 2025

fix dismissModal bug in native

7c9af66

ZhenjaHorbach reviewed Mar 21, 2025

View reviewed changes

src/pages/home/report/ReportActionsList.tsx Outdated Show resolved Hide resolved

remove log

4f70c3e

WojtekBoman mentioned this pull request Mar 21, 2025

Prevent navigating from scrollToBottomForCurrentUserAction #58908

Closed

50 tasks

run lint

f0435ac

ZhenjaHorbach approved these changes Mar 21, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 21, 2025 16:57

mountiny changed the title ~~fix: chat jumps to top briefly each time the expense is created~~ [CP Staging] fix: chat jumps to top briefly each time the expense is created Mar 21, 2025

mountiny approved these changes Mar 21, 2025

View reviewed changes

mountiny merged commit 55ec5d2 into Expensify:main Mar 21, 2025
18 checks passed

OSBotify pushed a commit that referenced this pull request Mar 21, 2025

Merge pull request #58904 from nkdengineer/fix/58871

99c4897

[CP Staging] fix: chat jumps to top briefly each time the expense is created (cherry picked from commit 55ec5d2) (CP triggered by luacmartins)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 21, 2025

github-actions bot mentioned this pull request Mar 21, 2025

Deploy Checklist: New Expensify 2025-03-20 #58801

Closed

72 tasks

dominictb mentioned this pull request Mar 24, 2025

[$250] Android -Chat -Chat has to be closed twice if deleting expense and submitting another offline #58206

Closed

8 tasks

melvin-bot bot mentioned this pull request Mar 24, 2025

[Due for payment 2025-03-31] Web - Expense - Chat jumps to the top briefly each time expense preview is generated #58871

Closed

8 tasks

Conversation

nkdengineer commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 21, 2025

Uh oh!

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

nkdengineer commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

nkdengineer commented Mar 21, 2025

Uh oh!

nkdengineer commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

WojtekBoman commented Mar 21, 2025

Uh oh!

WojtekBoman commented Mar 21, 2025

Uh oh!

WojtekBoman commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

WojtekBoman commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

nkdengineer commented Mar 21, 2025

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

WojtekBoman commented Mar 21, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading