New Feature: "When to export" selector for auto-sync for Quickbooks Online by twilight2294 · Pull Request #58980 · Expensify/App

twilight2294 · 2025-03-24T09:22:37Z

Explanation of Change

We need to build the same selector we made for NetSuite in #51512, but for Quickbooks Online (QBO).

The selection should be saved under the property accountingMethod in the QBO config object.

If there is no accountingMethod property set in the QBO config, the selector should default to CASH

Fixed Issues

$ #57522
$ #58501
$ #58429
PROPOSAL: #57522 (comment)

Tests

Same as Qa

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Open workspace connected to QBO > accounting
Click Advanced

Verify you see a Auto Sync menu description

click on it

Verify that the toggle is visible, verify that when the toggle is enabeld we see a new menu item to select

Enable toggle and click on the new menu item

Verify that you see 2 options CASH and accural.

Select the non selected one

Verify that the newly selected option is showed on the auto-sync page.

Verify that no errors appear in the JS console

Note

If you see #58501 happening again, please put a internal label on the issue, as it is a BE bug.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20250307_152728.mp4

Android: mWeb Chrome

Screen_recording_20250307_153144.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2025-03-07.at.14.57.40.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2025-03-07.at.14.59.59.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-07.at.2.53.30.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-07.at.3.01.01.PM.mov

…nline

…ge.tsx

twilight2294 · 2025-03-24T11:44:16Z

src/pages/workspace/accounting/qbo/advanced/QuickbooksAccountingMethodPage.tsx

+    const accountingMethod = config?.accountingMethod ?? COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH;
+    const data: MenuListItem[] = Object.values(COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD).map((accountingMethodType) => ({
+        value: accountingMethodType,
+        text: translate(`workspace.accountingMethods.values.${accountingMethodType}` as TranslationPaths),


note to self: update this import

melvin-bot · 2025-03-31T07:27:37Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-03-31T07:27:39Z

Fixing, the tests now

twilight2294 · 2025-03-31T07:28:06Z

@hungvu193 I think @suneox will review this since he was the reviewer of the original PR

suneox · 2025-03-31T17:40:12Z

@twilight2294 Please fix the ESLint check and typecheck

twilight2294 · 2025-04-04T17:49:55Z

Looking tomorrow

twilight2294 · 2025-04-08T06:27:22Z

@suneox PR ready for your review

twilight2294 · 2025-04-10T04:04:31Z

bump for review @suneox

suneox · 2025-04-10T09:31:22Z

bump for review @suneox

I missed this one from the K2 so I'll prioritize it today.

suneox · 2025-04-10T15:06:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-10.at.21.14.58.mp4

Android: mWeb Chrome

Screen.Recording.2025-04-10.at.21.20.05.mp4

iOS: Native

Screen.Recording.2025-04-10.at.21.56.51.mp4

iOS: mWeb Safari

Screen.Recording.2025-04-10.at.21.46.57.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-04-10.at.21.04.09.mp4

MacOS: Desktop

Screen.Recording.2025-04-10.at.21.17.39.mp4

suneox

The change set is the same as the previous PR and use enableEdgeToEdgeBottomSafeAreaPadding LGTM

twilight2294 · 2025-04-11T12:20:38Z

@techievivek can you please check and merge this one

techievivek

techievivek · 2025-04-14T05:40:39Z

@twilight2294 Do you mind resolving the conflicts? Thanks.

techievivek · 2025-04-14T11:06:43Z

src/languages/en.ts

                [CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.CHECK]: 'To use check export, set up a bank account in QuickBooks Online',
            },
            noAccountsFound: 'No accounts found',
+            noAccountsFoundDescription: 'Add the account in QuickBooks Online and sync the connection again.',


This already exists on 3192.

Same for spanish.

techievivek · 2025-04-15T03:30:28Z

@twilight2294 Friendly bump on fixing the linting errors.

src/languages/en.ts

src/languages/es.ts

OSBotify · 2025-04-15T12:02:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:38:56Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-18T20:30:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

twilight2294 added 4 commits March 24, 2025 09:20

New Feature: "When to export" selector for auto-sync for Quickbooks O…

c521fb8

…nline

Create QuickbooksAccountingMethodPage page

16c81e8

Create QuickbooksAutoSyncPage.tsx page

5b953c7

Rename QuickbooksAccountingMethodPage to QuickbooksAccountingMethodPa…

c19fbc6

…ge.tsx

twilight2294 commented Mar 24, 2025

View reviewed changes

Merge branch 'Expensify:main' into newAutoSyncQBO

95e0ddd

twilight2294 marked this pull request as ready for review March 31, 2025 07:27

twilight2294 requested a review from a team as a code owner March 31, 2025 07:27

melvin-bot bot requested review from hungvu193 and removed request for a team March 31, 2025 07:27

twilight2294 added 3 commits April 8, 2025 10:46

Merge branch 'main' into newAutoSyncQBO

e91ca50

fix translation imports

ed00bba

fix es lint

f36c300

Merge branch 'Expensify:main' into newAutoSyncQBO

fe0c358

suneox approved these changes Apr 10, 2025

View reviewed changes

melvin-bot bot requested a review from techievivek April 10, 2025 15:30

techievivek previously approved these changes Apr 14, 2025

View reviewed changes

techievivek assigned twilight2294 Apr 14, 2025

Merge branch 'main' into newAutoSyncQBO

6298890

twilight2294 dismissed techievivek’s stale review via 6298890 April 14, 2025 11:01

techievivek reviewed Apr 14, 2025

View reviewed changes

twilight2294 commented Apr 15, 2025

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

twilight2294 commented Apr 15, 2025

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

041387c

techievivek approved these changes Apr 15, 2025

View reviewed changes

techievivek merged commit 31543a6 into Expensify:main Apr 15, 2025
16 checks passed

github-actions bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

melvin-bot bot mentioned this pull request Apr 18, 2025

[Due for payment 2025-04-25] New Feature: "When to export" selector for auto-sync for Quickbooks Online #57522

Closed

This was referenced Apr 18, 2025

[Due for payment 2025-04-25] QBO - Automatically changes to other option of When to Export #58501

Closed

[Due for payment 2025-04-25] iOS - QBO - Offline indicator is not at the page bottom #58429

Closed

Conversation

twilight2294 commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

twilight2294 Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 31, 2025

Uh oh!

twilight2294 commented Mar 31, 2025

Uh oh!

twilight2294 commented Mar 31, 2025

Uh oh!

suneox commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilight2294 commented Apr 4, 2025

Uh oh!

twilight2294 commented Apr 8, 2025

Uh oh!

twilight2294 commented Apr 10, 2025

Uh oh!

suneox commented Apr 10, 2025

Uh oh!

suneox commented Apr 10, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

twilight2294 commented Apr 11, 2025

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

techievivek commented Apr 14, 2025

Uh oh!

techievivek Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

techievivek Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

techievivek commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

twilight2294 commented Mar 24, 2025 •

edited

Loading

suneox commented Mar 31, 2025 •

edited

Loading