Skip to content

[No QA] Add a testID to identify the not found page specifically in FullStory #59176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techievivek merged 4 commits into from
Apr 1, 2025
Merged

[No QA] Add a testID to identify the not found page specifically in FullStory #59176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbd5678
Add a testID to identify the not found page specifically in FullStory
tgolen Mar 26, 2025
d71351c
Move the testID to a different element
tgolen Mar 26, 2025
9049b21
Merge branch 'main' into tgolen-fullpage-testid
tgolen Mar 31, 2025
f6242d4
Remove conflg change
tgolen Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/BlockingViews/BlockingView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ type BaseBlockingViewProps = {

/** Whether to add bottom safe area padding to the content. */
addOfflineIndicatorBottomSafeAreaPadding?: boolean;

/** A testing ID that can be applied to the element on the page */
testID?: string;
};

type BlockingViewIconProps = {
Expand Down Expand Up @@ -108,6 +111,7 @@ function BlockingView({
containerStyle: containerStyleProp,
addBottomSafeAreaPadding = false,
addOfflineIndicatorBottomSafeAreaPadding = addBottomSafeAreaPadding,
testID,
}: BlockingViewProps) {
const styles = useThemeStyles();
const {translate} = useLocalize();
Expand Down Expand Up @@ -151,6 +155,7 @@ function BlockingView({
<View
style={[styles.flex1, styles.alignItemsCenter, styles.justifyContentCenter, styles.ph10, containerStyle]}
accessibilityLabel={accessibilityLabel}
testID={testID}
>
{!!animation && (
<Lottie
Expand Down
1 change: 1 addition & 0 deletions src/components/BlockingViews/ForceFullScreenView/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type ChildrenProps from '@src/types/utils/ChildrenProps';

type ForceFullScreenViewProps = ChildrenProps & {
shouldForceFullScreen?: boolean;
testID?: string;
};

export default ForceFullScreenViewProps;
1 change: 1 addition & 0 deletions src/components/BlockingViews/FullPageNotFoundView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ function FullPageNotFoundView({
subtitleStyle={subtitleStyle}
addBottomSafeAreaPadding={addBottomSafeAreaPadding}
addOfflineIndicatorBottomSafeAreaPadding={addOfflineIndicatorBottomSafeAreaPadding}
testID={FullPageNotFoundView.displayName}
/>
</View>
</ForceFullScreenView>
Expand Down