Skip to content

[CP Staging] Revert "Migrate AuthScreens to useOnyx v3"#59189

Merged
mountiny merged 1 commit intomainfrom
revert-58006-use-onyx/auth-screens-3
Mar 26, 2025
Merged

[CP Staging] Revert "Migrate AuthScreens to useOnyx v3"#59189
mountiny merged 1 commit intomainfrom
revert-58006-use-onyx/auth-screens-3

Conversation

@cristipaval
Copy link
Contributor

@cristipaval cristipaval commented Mar 26, 2025

Reverts #58006

Fixes:
$ #59139
$ #59128
$ #59184

More context in this Slack conversation

@cristipaval cristipaval requested a review from mountiny March 26, 2025 20:49
@cristipaval cristipaval self-assigned this Mar 26, 2025
@cristipaval cristipaval requested a review from a team as a code owner March 26, 2025 20:49
@melvin-bot melvin-bot bot removed the request for review from a team March 26, 2025 20:49
@melvin-bot
Copy link

melvin-bot bot commented Mar 26, 2025

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

🚧 @cristipaval has triggered a test app build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
❌ FAILED ❌ ❌ FAILED ❌
The QR code can't be generated, because the Android build failed The QR code can't be generated, because the iOS build failed
Android Hybrid 🤖🔄 iOS Hybrid 🍎🔄
Android Hybrid iOS Hybrid
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59189/NewExpensify.dmg ❌ FAILED ❌
Desktop The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

@cristipaval cristipaval changed the title Revert "Migrate AuthScreens to useOnyx v3" [CP Staging] Revert "Migrate AuthScreens to useOnyx v3" Mar 26, 2025
@mountiny
Copy link
Contributor

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit aa7e3ab into main Mar 26, 2025
14 of 18 checks passed
@mountiny mountiny deleted the revert-58006-use-onyx/auth-screens-3 branch March 26, 2025 21:13
@melvin-bot
Copy link

melvin-bot bot commented Mar 26, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Mar 26, 2025
…creens-3

[CP Staging] Revert "Migrate AuthScreens to useOnyx v3"

(cherry picked from commit aa7e3ab)

(CP triggered by cristipaval)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 26, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.1.19-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.19-5 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants