Skip to content

fix: admins can't edit expenses on draft reports in NewDot #59201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youssef-lr merged 1 commit into from
Mar 28, 2025
Merged

fix: admins can't edit expenses on draft reports in NewDot #59201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3670,8 +3670,8 @@ function canEditMoneyRequest(reportAction: OnyxInputOrEntry<ReportAction<typeof
return false;
}

// Admin & managers can always edit coding fields such as tag, category, billable, etc. As long as the report has a state higher than OPEN.
if ((isAdmin || isManager) && !isOpenExpenseReport(moneyRequestReport)) {
// Admin & managers can always edit coding fields such as tag, category, billable, etc.
if (isAdmin || isManager) {
return true;
}

Expand Down