fix crash when swiping to chat immediately after creating a room#59207
Merged
yuwenmemon merged 4 commits intoExpensify:mainfrom Apr 2, 2025
Merged
fix crash when swiping to chat immediately after creating a room#59207yuwenmemon merged 4 commits intoExpensify:mainfrom
yuwenmemon merged 4 commits intoExpensify:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #58220
PROPOSAL: #58220 (comment)
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-03-27.at.16.08.11.mp4
Android: mWeb Chrome
Screen.Recording.2025-03-27.at.16.18.04.mp4
iOS: Native
Screen.Recording.2025-03-27.at.16.19.08.mp4
iOS: mWeb Safari
Screen.Recording.2025-03-27.at.16.21.08.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-03-27.at.16.22.18.mp4
MacOS: Desktop
Screen.Recording.2025-03-27.at.16.24.03.mp4