Skip to content

[CP Staging] Revert "Fix nested markdown isn't applied"#59490

Merged
neil-marcellini merged 1 commit intomainfrom
revert-59202-fix/58468-nested-markdown-not-applied
Apr 1, 2025
Merged

[CP Staging] Revert "Fix nested markdown isn't applied"#59490
neil-marcellini merged 1 commit intomainfrom
revert-59202-fix/58468-nested-markdown-not-applied

Conversation

@neil-marcellini
Copy link
Copy Markdown
Contributor

@neil-marcellini neil-marcellini commented Apr 1, 2025 •
edited
Loading

Reverts #59202

Fixed Issues

$ #59487

Tests

  1. Run the tests in the linked issues
  2. Verify the expected result
  3. Check out staging
  4. Verify the bug is reproducible

@neil-marcellini neil-marcellini self-assigned this Apr 1, 2025
@neil-marcellini neil-marcellini requested review from a team as code owners April 1, 2025 21:00
@melvin-bot melvin-bot bot requested review from chiragsalian and removed request for a team April 1, 2025 21:01
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 1, 2025

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@srikarparsi
Copy link
Copy Markdown
Contributor

srikarparsi commented Apr 1, 2025

Thanks for catching this @neil-marcellini

srikarparsi
srikarparsi approved these changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@srikarparsi srikarparsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert

@neil-marcellini
Copy link
Copy Markdown
Contributor Author

neil-marcellini commented Apr 1, 2025

No checklists needed for a straight revert. Thanks for the review @srikarparsi

@neil-marcellini neil-marcellini merged commit f7e3115 into main Apr 1, 2025
14 of 17 checks passed
@neil-marcellini neil-marcellini deleted the revert-59202-fix/58468-nested-markdown-not-applied branch April 1, 2025 21:04
@melvin-bot melvin-bot bot added the Emergency label Apr 1, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 1, 2025

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@srikarparsi srikarparsi mentioned this pull request Apr 1, 2025
Closed
16 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 1, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Apr 1, 2025
@neil-marcellini @OSBotify
Merge pull request #59490 from Expensify/revert-59202-fix/58468-neste…
0435081 
…d-markdown-not-applied

[CP Staging] Revert "Fix nested markdown isn't applied"

(cherry picked from commit f7e3115)

(CP triggered by Julesssss)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Apr 1, 2025
@github-actions github-actions bot mentioned this pull request Apr 1, 2025
Closed
60 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.22-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

🚀 Deployed to production by https://github.com/grgia in version: 9.1.22-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Apr 3, 2025
@bernhardoj
Revert "Merge pull request Expensify#59490 from Expensify/revert-5920…
2bab605 
…2-fix/58468-nested-markdown-not-applied"

This reverts commit f7e3115, reversing
changes made to 4325900.
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Closed
66 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2025

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.25-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.25-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srikarparsi srikarparsi srikarparsi approved these changes

@chiragsalian chiragsalian Awaiting requested review from chiragsalian

Assignees

@neil-marcellini neil-marcellini

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neil-marcellini @srikarparsi @OSBotify