[DRAFT] Feature/kuba nowakowski/create add unreported expense page#59651
Closed
sumo-slonik wants to merge 60 commits intoExpensify:mainfrom
Closed
Conversation
…-component' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page # Conflicts: # Mobile-Expensify
…-component' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page # Conflicts: # src/components/TransactionItemComponent/index.tsx
…-component' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page
…-component' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page
…-component' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page
…-component' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page
…d-Expense-page # Conflicts: # src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
…unreported-expense-rhp Fix hovering and style AddUnreportedExpense component
…dd-unreported-Expense-page' into feature/kuba-nowakowski/Create-Add-unreported-Expense-page
…d-Expense-page # Conflicts: # src/components/TransactionItemRow/index.tsx # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/pages/Search/SearchMoneyRequestReportPage.tsx # src/styles/index.ts
…ba-nowakowski/Create-Add-unreported-Expense-page # Conflicts: # src/CONST.ts # src/libs/API/parameters/ChangeTransactionsReportParams.ts # src/libs/API/types.ts
…d-Expense-page # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportView.tsx # src/components/TransactionItemRow/index.tsx # src/libs/ReportActionsUtils.ts # src/libs/ReportUtils.ts
…ba-nowakowski/Create-Add-unreported-Expense-page # Conflicts: # src/libs/ReportUtils.ts
Contributor
|
@sumo-slonik a lot of the code in this PR is similar and doing the same thing as #58597. I'd recommend that in this PR we only add the new UI/pages to add transactions and wait to call the API we're developing in #58597. That PR is almost ready to be merged. |
This reverts commit 3daab6e.
…ied-actions-on-header-v2
…-actions-on-header-v2
…ied-actions-on-header-v2
…w/simplified-actions-on-header-v2
…wski/unneseary_delete_option Delete option is present for approved expense which causes error when deleting itjnowakow/simplified-actions-on-header-v2
…kuba-nowakowski/Create-Add-unreported-Expense-page # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportView.tsx # src/libs/ReportUtils.ts # src/libs/actions/Report.ts # src/pages/home/report/PureReportActionItem.tsx # src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
…d-Expense-page # Conflicts: # src/libs/API/parameters/ChangeTransactionsReportParams.ts # src/libs/ReportUtils.ts # src/libs/actions/Transaction.ts # src/pages/home/report/PureReportActionItem.tsx
…d-Expense-page # Conflicts: # src/libs/actions/Report.ts
Contributor
Author
|
I created a new draft PR due to a large number of changes on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop