[Manager McTest] Clean up - Do not show Manager McTest for new users who are invited to a workspace by JKobrynski · Pull Request #59660 · Expensify/App

JKobrynski · 2025-04-04T12:03:39Z

…ed to workspaces

Explanation of Change

Exclude Manager McTest from recipients list for users who have a workspace that they are not an owner of - this basically means, they were invited to the workspace thus they shouldn't be able to access Manager McTest.

Fixed Issues

$ #59208
PROPOSAL: N/A

Tests

Create a new account in the web app (account A)
Click on the FAB and select 'Create expense' and 'Manual'
Input some random amount and proceed to the next step
Make sure you can see Manager McTest in the recipients list
Log out of the account A
Log into some other account that owns a workspace (account B)
Invite account A to your workspace
Log into account A
Repeat steps 2-3
Make sure you can't see Manager McTest in the recipients list anymore

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Account A - you can access Manager McTest on a fresh account

web1-compressed.mov

Account B - invite account A to a workspace

web2-compressed.mov

Account A - log into account A, you can't access Manager McTest anymore

web3-compressed.mov

…ed to workspaces

melvin-bot · 2025-04-07T08:16:25Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-04-08T08:25:40Z

src/libs/OptionsListUtils.ts

 ): Options {
    const userHasReportWithManagerMcTest = canShowManagerMcTest && Object.values(options.reports).some((report) => isManagerMcTestReport(report));
+    // If user has a workspace that he doesn't own, it means he was invited to it.
+    const isUserInvitedToWorkspace = Object.values(policies ?? {}).some((policy) => policy?.ownerAccountID !== currentUserAccountID && policy?.isPolicyExpenseChatEnabled);


Suggested change

const isUserInvitedToWorkspace = Object.values(policies ?? {}).some((policy) => policy?.ownerAccountID !== currentUserAccountID && policy?.isPolicyExpenseChatEnabled);

const isUserInvitedToWorkspace = Object.values(policies ?? {}).some((policy) => policy?.ownerAccountID !== currentUserAccountID && policy?.isPolicyExpenseChatEnabled && policy?.policyID && policy?.policyID !== CONST.POLICY.ID_FAKE);

DylanDylann · 2025-04-08T08:38:00Z

@JKobrynski In this case, We also should disable the test scanning tooltip ???

Screen.Recording.2025-04-08.at.15.35.22.mov

JKobrynski · 2025-04-08T12:53:45Z

I think so, does it only reproduce on this branch or main too? If it reproduces on main, we should create a separate issue for it

github-actions · 2025-04-08T13:48:55Z

🚧 @grgia has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-08T14:19:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59660-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59660-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59660/NewExpensify.dmg	https://59660.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

DylanDylann · 2025-04-09T04:20:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-09.at.11.33.33.mov

Android: mWeb Chrome

Screen.Recording.2025-04-09.at.11.27.30.mov

iOS: Native

Screen.Recording.2025-04-09.at.11.29.14.mov

iOS: mWeb Safari

Screen.Recording.2025-04-09.at.11.23.19.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-09.at.11.14.56.mov

MacOS: Desktop

DylanDylann · 2025-04-09T04:35:19Z

src/libs/OptionsListUtils.ts

    }: GetOptionsConfig = {},
 ): Options {
    const userHasReportWithManagerMcTest = canShowManagerMcTest && Object.values(options.reports).some((report) => isManagerMcTestReport(report));
+    // If user has a workspace that he doesn't own, it means he was invited to it.


Suggested change

// If user has a workspace that he doesn't own, it means he was invited to it.

// If user has a workspace that he isn't owner, it means he was invited to it.

grgia

🚀

OSBotify · 2025-04-09T09:38:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-10T01:20:47Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.26-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-11T00:05:39Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.26-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

rojiphil · 2025-09-15T08:04:02Z

src/libs/OptionsListUtils.ts

    const userHasReportWithManagerMcTest = canShowManagerMcTest && Object.values(options.reports).some((report) => isManagerMcTestReport(report));
+    // If user has a workspace that he isn't owner, it means he was invited to it.
+    const isUserInvitedToWorkspace = Object.values(policies ?? {}).some(
+        (policy) => policy?.ownerAccountID !== currentUserAccountID && policy?.isPolicyExpenseChatEnabled && policy?.id && policy.id !== CONST.POLICY.ID_FAKE,


Manager McTest should not appear for the user who created the workspace. We fixed this in #65359

exclude Manager McTests from recipients list for users who were invit…

6312bf1

…ed to workspaces

JKobrynski marked this pull request as ready for review April 7, 2025 08:16

JKobrynski requested a review from a team as a code owner April 7, 2025 08:16

melvin-bot bot requested review from DylanDylann and removed request for a team April 7, 2025 08:16

DylanDylann reviewed Apr 8, 2025

View reviewed changes

DylanDylann mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-17] [Due for payment 2025-04-16] [Manager McTest] Only Allow Submitting Test Receipt to Manager #59717

Closed

apply suggested changes

6df3746

DylanDylann approved these changes Apr 9, 2025

View reviewed changes

melvin-bot bot requested a review from grgia April 9, 2025 04:35

fix comment

9a464b0

grgia approved these changes Apr 9, 2025

View reviewed changes

grgia merged commit cd227b6 into Expensify:main Apr 9, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 10, 2025

Deploy Checklist: New Expensify 2025-04-10 #59968

Closed

65 tasks

jponikarchuk mentioned this pull request Apr 10, 2025

Create expense- Need to reload to see Manager McTest in the recipients list #59987

Closed

8 tasks

melvin-bot bot mentioned this pull request Apr 11, 2025

[Due for payment 2025-04-18] [Manager McTest] Clean up - Do not show Manager McTest for new users who are invited to a workspace #59208

Closed

JKobrynski mentioned this pull request Apr 14, 2025

(Fix) [Manager McTest] When a user is invited to a workspace, the scanning test tooltip still displays #60187

Merged

50 tasks

rojiphil reviewed Sep 15, 2025

View reviewed changes

	const isUserInvitedToWorkspace = Object.values(policies ?? {}).some((policy) => policy?.ownerAccountID !== currentUserAccountID && policy?.isPolicyExpenseChatEnabled);
	const isUserInvitedToWorkspace = Object.values(policies ?? {}).some((policy) => policy?.ownerAccountID !== currentUserAccountID && policy?.isPolicyExpenseChatEnabled && policy?.policyID && policy?.policyID !== CONST.POLICY.ID_FAKE);

	// If user has a workspace that he doesn't own, it means he was invited to it.
	// If user has a workspace that he isn't owner, it means he was invited to it.

Conversation

JKobrynski commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 7, 2025

Uh oh!

DylanDylann Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

JKobrynski Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 8, 2025

Uh oh!

JKobrynski commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

DylanDylann commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

JKobrynski Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

rojiphil Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JKobrynski commented Apr 4, 2025 •

edited

Loading

DylanDylann commented Apr 9, 2025 •

edited

Loading