Add iOS In-App Provisioning by Skalakid · Pull Request #59712 · Expensify/App

Skalakid · 2025-04-07T06:45:17Z

Explanation of Change

This is a react-native-wallet testing PR for iOS for Expensify App. Some of the In-App Provisioning features are available only on production (on the signed app), so we hid them behind the wallet beta, and we will verify if everything works on production. After that, we will publish the library to npm and change the tgz local module for the one from npm

Important

This PR adds an In-App Provisioning feature for iOS only, the Android will be added in the separate PR

Note

The feature is hidden behind the special beta flag, so we can test it properly before launching it for everybody

Fixed Issues

$ #36957
PROPOSAL:

Tests

Note

To be able to test and use In-App Provisioning you need to use physical iOS device on signed app

Open the app
Go to Settings > Wallet
Select any card
Verify if the Add to Apple Wallet button is available
Press it
Verify user details in the form and card title at the top ("<Card title>" will be available in Wallet)
Press Cancel and verify if no error appears and the native modal hides
Press Add to Apple Wallet again
Press Nest at the top right corner
Verify if the card is successfully added to the wallet
Verify if the Add to Apple Wallet button isn't visible on the page when the specified card is already in the wallet. On dev build Could Not Add Card alert appears at the end. On prod everything should be fine

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios_phyiscal.MP4

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

github-actions · 2025-04-07T06:45:31Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-07T07:32:03Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-07T07:46:50Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-07T10:02:50Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

thienlnam · 2025-04-08T17:11:54Z

src/libs/API/parameters/CreateAppleDigitalWalletParams.ts

+    // stringified {"certificates": string[]}
+    certificates: string;


Is this comment indicating it looks like this?

"['cert1', 'cert2']"

No, it's more like a result of this: JSON.stringify({"certificates": ['cert1', 'cert2']}). That's how it works on the OldDot 😅 I think we can change this later on the backend to just ['cert1', 'cert2']. What do you think about it?

thienlnam · 2025-04-08T17:13:47Z

src/libs/Wallet/RNAddToWalletButton/index.native.tsx

+import {checkIfWalletIsAvailable, handleAddCardToWallet, isCardInWallet} from '..';
+import type AddToWalletButtonProps from './types';
+
+function RNAddToWalletButton({card, cardHolderName, buttonStyle}: AddToWalletButtonProps) {


probably interferes with the import, but perhaps we could alias the import as import { AddToWalletButton as RNWAddToWalletButton }?

thienlnam · 2025-04-08T17:18:08Z

src/libs/Wallet/index.ios.ts

+            })
+            .catch((e) => {
+                Log.warn(`isCardInWallet error: ${e}`);
+                return Promise.resolve(card.state === 6);


What is this card.state === 6 represent?

It represents EXPENSIFY_CARD.STATE.CLOSED, but I think it's not appropriate here so I will change it to just false

thienlnam · 2025-04-08T17:19:53Z

src/libs/Wallet/index.ts

+function isCardInWallet(_card: Card) {
+    // Return true for other platforms, so the AddToWalletButton is always hidden
+    return Promise.resolve(true);


Is this necessary? It looks like src/libs/Wallet/RNAddToWalletButton/index.tsx already doesn't return the button so it shouldn't show up regardless

That's right but we wanted to secure the Wallet functions from using them on unsupported platforms like the web or desktop. It will prevent from bugs in the future and won't make the code platform-specific

github-actions · 2025-04-09T09:55:48Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-09T10:37:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59712-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59712-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59712/NewExpensify.dmg	https://59712.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2025-04-09T12:18:42Z

ScreenRecording_04-09-2025.14-11-52_1.mp4

ios looks good to me @brunovjk can complete the rest of testing and checklist

brunovjk · 2025-04-09T13:38:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

59712_android_native.mov

Android: mWeb Chrome

59712_android_web.mov

iOS: Native

iOS: mWeb Safari

59712_ios_web.mov

MacOS: Chrome / Safari

59712_web_safari.mov

MacOS: Desktop

59712_web_desktop.mov

brunovjk

I couldn't test the "Add to Wallet Button" itself, because I don't have a physical iOS, but Vit did it here. I tested if the changes did not break anything in the app and LGTM

mountiny

Looks good to me, all yours @thienlnam

OSBotify · 2025-04-10T09:32:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-11T00:51:52Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-16T22:13:01Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

zfurtak and others added 20 commits March 25, 2025 13:24

Initialisation

edb5b43

merge

a607ca7

Split code to proper files

e8bc8a9

Merge branch 'main' into @zfurtak/introduce-wallet-to-expensify

2242ed9

Merge branch 'main' into @zfurtak/introduce-wallet-to-expensify

4b8c957

Add expensify-react-native-wallet tgz

1e75c63

Fix TS errors

0ae96f8

Fix API call arguments

104e762

Move wallet tgz

7d42072

Update wallet module

067c153

Add In-App Provisioning util functions

6a7f9c6

Enhance 'Add to Apple Wallet' button component

34039ea

Merge branch 'main' into @Skalakid/add-to-apple-wallet

4d40ba3

Hide in app provisioning behind the beta

a32ea52

Merge branch 'main' into @Skalakid/add-to-apple-wallet

f0d53b9

Fix iOS Card Data

78f80e4

Change cardHolderName to user display name

5995fbb

Clean up AddToWalletButton

cf91bae

Check if card in the Wallet after finishing push provisioning

7d4d677

Remove text styles

beb2fc3

Skalakid added 2 commits April 7, 2025 09:29

Update package-lock.json

a9e1777

Update submodule

44b073e

Refinements

a425e28

Skalakid changed the title ~~Add In-App Provisioning on iOS~~ Add iOS In-App Provisioning Apr 7, 2025

Skalakid added 2 commits April 7, 2025 12:02

Fix launching web

610d0e5

Update module

2d1d3b6

This comment has been minimized.

Sign in to view

thienlnam reviewed Apr 8, 2025

View reviewed changes

Skalakid and others added 5 commits April 9, 2025 09:09

Add review changes

3c87542

Update package-lock.json

d7fef51

Rename component in Card Page

bbd98cd

Merge branch 'main' into @Skalakid/add-to-apple-wallet

8d07876

Update Mobile-Expensify version

6434667

Merge branch 'main' into @Skalakid/add-to-apple-wallet

ba575dc

brunovjk approved these changes Apr 9, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 9, 2025 13:46

mountiny previously approved these changes Apr 9, 2025

View reviewed changes

thienlnam previously approved these changes Apr 9, 2025

View reviewed changes

Merge branch 'main' into @Skalakid/add-to-apple-wallet

7c2607b

Skalakid dismissed stale reviews from thienlnam and mountiny via 7c2607b April 10, 2025 08:26

Skalakid added 2 commits April 10, 2025 10:31

Change card description to translated one

5a7a38e

Update submodule

9b9b68a

mountiny approved these changes Apr 10, 2025

View reviewed changes

mountiny merged commit a08e8f7 into Expensify:main Apr 10, 2025
24 checks passed

github-actions bot mentioned this pull request Apr 11, 2025

Deploy Checklist: New Expensify 2025-04-11 #60076

Closed

33 tasks

zfurtak mentioned this pull request Apr 16, 2025

Setup react-native-wallet on Android #60270

Merged

50 tasks

melvin-bot bot mentioned this pull request Apr 16, 2025

[$1500] Create new library and native module react-native-wallet #36957

Closed

zfurtak deleted the @Skalakid/add-to-apple-wallet branch September 9, 2025 09:57

		// stringified {"certificates": string[]}
		certificates: string;

Conversation

Skalakid commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

This comment has been minimized.

thienlnam Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thienlnam Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

thienlnam Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

thienlnam Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

mountiny commented Apr 9, 2025

Uh oh!

brunovjk commented Apr 9, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Skalakid commented Apr 7, 2025 •

edited

Loading

Skalakid Apr 9, 2025 •

edited

Loading