[UX Reliability] Use new modal in BasePopoverReactionList by blazejkustra · Pull Request #60016 · Expensify/App

blazejkustra · 2025-04-10T11:07:22Z

Explanation of Change

We've decided to refactor the react-native-bottom-modal code so that it utilizes react-native-reanimated, our goal was to improve FPS, remove the outdated library and gradually switch to the new solution. This PR enables the new solution in BasePopoverReactionList.

Fixed Issues

$ #49354
PROPOSAL: N/A

Tests

Go to any chat
React with an emoji to any message
Long press on that reaction on mobile (right click on web)
Verify that the modal with reactions list is displayed

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

aaaa.webm

Android: mWeb Chrome

and.webm

iOS: Native

ios.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-04-10.at.17.15.57.mov

borys3kk · 2025-04-10T15:03:43Z

nejlepší kód, jaký jsem kdy viděl!

…tion-list-modal

melvin-bot · 2025-04-10T15:17:41Z

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-04-14T16:26:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

…tion-list-modal

blazejkustra · 2025-04-17T12:22:44Z

@ZhenjaHorbach What's your ETA on finishing the checklist? I just merged the newest main for you! 🚀

ZhenjaHorbach · 2025-04-17T12:31:03Z

Oh
As I remember I didn't have any issues with this PR

ZhenjaHorbach · 2025-04-17T12:31:22Z

But now we have eslint issues 😅

blazejkustra · 2025-04-18T08:34:40Z

But now we have eslint issues 😅

Should be good now! @ZhenjaHorbach

ZhenjaHorbach · 2025-04-18T09:01:16Z

@blazejkustra
Not really 😅

…tion-list-modal

blazejkustra · 2025-04-18T09:29:29Z

How about now? 🙈

ZhenjaHorbach · 2025-04-18T11:22:24Z

Yes
Now everything is good !
But maybe I would probably just improve the closing animation
So that navigation occurs after the modal is completely closed

@shawnborton
What do you think ?

2025-04-18.13.19.28.mov

shawnborton · 2025-04-18T14:54:29Z

That seems reasonable to me, definitely down to try that and see how it looks. cc @Expensify/design for viz.

dannymcclain · 2025-04-18T15:10:23Z

Same

dubielzyk-expensify · 2025-04-22T00:47:31Z

Looking good to me as well 👍

…tion-list-modal

blazejkustra · 2025-04-22T14:05:25Z

@ZhenjaHorbach I tried using this code:

onClose?.();
InteractionManager.runAfterInteractions(() => {
    Navigation.navigate(ROUTES.PROFILE.getRoute(item.accountID));
});

However, after this change, the transition starts noticeably late:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-22.at.15.47.27.mp4

Here’s how it currently behaves:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-22.at.15.56.12.mp4

@shawnborton @dannymcclain @dubielzyk-expensify thoughts?

shawnborton · 2025-04-22T14:11:14Z

Hmm I have a hard time seeing what's wrong with that first video! Hah, it seems fine to me? Are you saying that it should launch the RHP faster after you tap the member row?

blazejkustra · 2025-04-22T14:14:43Z

I uploaded the wrong video.. Please check again @shawnborton 🙏

shawnborton · 2025-04-22T14:16:46Z

Okay yeah wow, that definitely feels bad. I feel like the current behavior is much better.

ZhenjaHorbach · 2025-04-22T14:24:19Z

@blazejkustra
Could you please check InteractionManager.runAfterInteractions ?
If it will be the same
Let's leave everything as is then !

dannymcclain · 2025-04-22T14:25:58Z

Yeah I think that delay is too much—definitely long enough to cause people to wonder "is anything happening?"

blazejkustra · 2025-04-22T14:26:28Z

Could you please check InteractionManager.runAfterInteractions ?

That's what I used and got this delay @ZhenjaHorbach

blazejkustra · 2025-04-22T14:27:16Z

Feel free to proceed with the checklist! Unless you have a better idea for navigating to the profile screen with a delay (aside from InteractionManager.runAfterInteractions).

ZhenjaHorbach · 2025-04-22T14:28:14Z

Could you please check InteractionManager.runAfterInteractions ?

That's what I used and got this delay @ZhenjaHorbach

Strange
I thought you used Navigation.setNavigationActionToMicrotaskQueue 😅
Or maybe it just seemed that way to me 😂
My bad

ZhenjaHorbach · 2025-04-22T14:35:20Z

Oh
I noticed that you are already using Navigation.setNavigationActionToMicrotaskQueue

As for me now it works a little smoother and I hardly see any jerks

2025-04-22.16.29.42.mov

ZhenjaHorbach · 2025-04-22T14:39:38Z

LGTM !
Agree that using InteractionManager.runAfterInteractions looks very slow
But using Navigation.setNavigationActionToMicrotaskQueue looks great to me !

mountiny

LGTM

mountiny · 2025-04-22T14:47:00Z

src/pages/home/report/ReactionList/PopoverReactionList/BasePopoverReactionList.tsx

    const {preferredLocale} = useLocalize();
+
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+    const reactionReportActionID = reportActionID || CONST.DEFAULT_NUMBER_ID;


When could the reportActionID be empty string?

As I remember from a parent component we pass actionID as an empty string by default

interesting, thanks

mountiny · 2025-04-22T14:48:42Z

@blazejkustra @ZhenjaHorbach Thanks for a thorough testing and suggesting improvements, also for patience with the review.

OSBotify · 2025-04-22T14:56:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-23T18:44:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-28T19:51:22Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[UX Reliability] Use new modal in BasePopoverReactionList

d705de8

borys3kk approved these changes Apr 10, 2025

View reviewed changes

blazejkustra added 2 commits April 10, 2025 17:16

Fix onyx crash

6763021

Merge branch 'main' of github.com:Expensify/App into feature/new-reac…

52aaf1b

…tion-list-modal

blazejkustra marked this pull request as ready for review April 10, 2025 15:17

blazejkustra requested a review from a team as a code owner April 10, 2025 15:17

melvin-bot bot requested review from ZhenjaHorbach and shawnborton and removed request for a team April 10, 2025 15:17

blazejkustra mentioned this pull request Apr 10, 2025

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Closed

Merge branch 'main' of github.com:Expensify/App into feature/new-reac…

5006c31

…tion-list-modal

Fix lint

644977e

blazejkustra added 2 commits April 18, 2025 11:23

Fix lint x2

4fa0b64

Merge branch 'main' of github.com:Expensify/App into feature/new-reac…

5da10a5

…tion-list-modal

blazejkustra added 2 commits April 22, 2025 14:50

Merge branch 'main' of github.com:Expensify/App into feature/new-reac…

6c58687

…tion-list-modal

Wrap navigation action in a microtask queue

6acf470

ZhenjaHorbach approved these changes Apr 22, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 22, 2025 14:38

mountiny assigned blazejkustra Apr 22, 2025

mountiny approved these changes Apr 22, 2025

View reviewed changes

mountiny merged commit 5380a53 into Expensify:main Apr 22, 2025
18 checks passed

github-actions bot mentioned this pull request Apr 23, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Closed

91 tasks

Conversation

blazejkustra commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

borys3kk commented Apr 10, 2025

Uh oh!

melvin-bot bot commented Apr 10, 2025

Uh oh!

ZhenjaHorbach commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

blazejkustra commented Apr 17, 2025

Uh oh!

ZhenjaHorbach commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 17, 2025

Uh oh!

blazejkustra commented Apr 18, 2025

Uh oh!

ZhenjaHorbach commented Apr 18, 2025

Uh oh!

blazejkustra commented Apr 18, 2025

Uh oh!

ZhenjaHorbach commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 18, 2025

Uh oh!

dannymcclain commented Apr 18, 2025

Uh oh!

dubielzyk-expensify commented Apr 22, 2025

Uh oh!

blazejkustra commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 22, 2025

Uh oh!

blazejkustra commented Apr 22, 2025

Uh oh!

shawnborton commented Apr 22, 2025

Uh oh!

ZhenjaHorbach commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Apr 22, 2025

Uh oh!

blazejkustra commented Apr 22, 2025

Uh oh!

blazejkustra commented Apr 22, 2025

Uh oh!

ZhenjaHorbach commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 22, 2025

Uh oh!

ZhenjaHorbach commented Apr 22, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra commented Apr 10, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 14, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 17, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 18, 2025 •

edited

Loading

blazejkustra commented Apr 22, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 22, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 22, 2025 •

edited

Loading

ZhenjaHorbach Apr 22, 2025 •

edited

Loading