[UX Reliability] Use new modal in ConfirmModal

[blazejkustra]

Explanation of Change

We've decided to refactor the react-native-bottom-modal code so that it utilizes react-native-reanimated, our goal was to improve FPS, remove the outdated library and gradually switch to the new solution. This PR enables the new solution in ConfirmModal.

Fixed Issues

$ #49354
PROPOSAL: N/A

Tests

Test just some of these cases, usage is really similar for all:

1. MoneyReportHeader

   • Deleting a money report

2. RoomMemberDetailsPage

   • Create a chat room → Three Dots Menu → Members → Click on one of the members → Click “Remove from group”

3. WorkspaceProfilePage

   • Create new workspace → Go to workspace profile (through settings page) → Delete workspace

4. WorkspacesListPage

   • Create new workspace → Go to workspaces list in settings → Three dots menu in corner of the new workspace → Delete workspace

5. WorkspaceTagsPage

   • 1. Log in to the app
   • 2. Go to existing Workspace or create new
   • 3. Go to Tags (as an admin)
   • 4. Add a few tags if you don’t have any
   • 5. Long press on some item
   • 6. Choose "Select"
   • 7. Try deleting it

6. ReportParticipantsPage

   • 1. Log in to the app
   • 2. Go to existing report or create new
   • 3. Go to Members (as an admin)
   • 4. Add a few members if you are alone
   • 5. Long press on some item
   • 6. Choose "Select"
   • 7. Try deleting it

7. RoomMembersPage

   • 1. Log in to the app
   • 2. Go to existing room or create new
   • 3. Go to Members (as an admin)
   • 4. Add a few members if you are alone
   • 5. Long press on some item
   • 6. Choose "Select"
   • 7. Click “Delete” button

8. WorkspaceMembersPage

   • 1. Log in to the app
   • 2. Go to existing Workspace or create new
   • 3. Go to Members (as an admin)
   • 4. Add a few members if you are alone
   • 5. Long press on some item
   • 6. Choose "Select"
   • 7. Click “Delete” button

9. WorkspaceCategoriesPage

   • 1. Log in to the app
   • 2. Go to existing workspace or create new
   • 3. Go to categories (as an admin)
   • 4. Long press on some item
   • 5. Choose "Select"
   • 6. Click “Delete” button

10. VisibilityPage

    • 1. Create a room by Selecting any visibility option
    • 2. Click room details > settings
    • 3. Verify that admin can change the visibility, other members just can see the visibility
    • 4. If admin wants to change the visibility to public, we should show the confirm modal

11. IOURequestStepScan

    • 1. Start creating an IOU Request (Distance)
    • 2. Fill out a waypoint
    • 3. Edit that waypoint
    • 4. Three dot menu
    • 5. Delete

12. TroubleshootPage

    • 1. Go to settings
    • 2. Troubleshoot
    • 3. Click “Clear cache and restart”

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

aaa.webm

Android: mWeb Chrome

andw.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-10.at.17.50.06.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-10.at.17.51.30.mp4

MacOS: Chrome / Safari

web.mov

[borys3kk]

ještě lepší kód

[melvin-bot]

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ZhenjaHorbach]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

[ZhenjaHorbach]

Damn
Performance issue
But I think it will be fixed when we update this branch to the latest version of main !

[ZhenjaHorbach]

Overall the changes look good !
I just noticed one bug
When we remove one member from a workspace
We change the text to plural

2025-04-14.09.56.52.mov

[blazejkustra]

Oh no, tests are still failing, let me try merge the newest main 🙏 I'll take care of remaining issues tomorrow morning.

[blazejkustra]

@ZhenjaHorbach I fixed perf tests and the bug you mentioned, back to you!

[ZhenjaHorbach]

We also have a similar issue with workspace taxes

And with tags

And with reportFields

I suppose it's better to find all places where we use setSelected function with ConfirmModal and with .length === 1 condition or translate with count param

2025-04-18.16.58.28.mov

[blazejkustra]

I suppose it's better to find all places where we use setSelected

Thank you for this tip! (this regex worked perfectly: setSelected.*\(\[\]\);)

Back to you @ZhenjaHorbach 😄

[ZhenjaHorbach]

I suppose it's better to find all places where we use setSelected

Thank you for this tip! (this regex worked perfectly: setSelected.*\(\[\]\);)

Back to you @ZhenjaHorbach 😄

Glad to help
And I'll check it out today!

[ZhenjaHorbach]

@blazejkustra

We need to fix workspace tags also

2025-04-23.10.36.04.mov

[ZhenjaHorbach]

Actually it's weird

@shawnborton @ZhenjaHorbach I pushed a commit that eliminates this delay and I think it looks better now, wdyt?

JFYI We can't animate status bar color on mobile web

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-24.at.14.17.26.mp4

About this feature
But for me this feature works a little broken

2025-04-30.09.17.47.mov

Perhaps we should revert these changes and fix them in a separate PR so as not to block this PR?

[ZhenjaHorbach]

We have a broken close animation on tags screen

I've spent quite a bit of time on this, but I think I've finally fixed it. Please check if it works across all platforms 🙏 @ZhenjaHorbach

And this works good !
Thanks !

[blazejkustra]

I'm back, working on this now! 😄

[blazejkustra]

Perhaps we should revert these changes and fix them in a separate PR so as not to block this PR?

@ZhenjaHorbach I agree with, changes are reverted and I'm working on a follow up PR 😄

edit: follow up is ready here

[blazejkustra]

Update: Chatted with @ZhenjaHorbach on slack — he didn’t have time to check it yesterday but will try to review it today 🤞

[ZhenjaHorbach]

LGTM !

[mountiny]

One question but not going to block on this

[mountiny]

Why is this extra view needed?

[blazejkustra]

Closing animation of the modal was broken when the ConfirmModal was nested inside AccessOrNotFoundWrapper, it was because it was unmounted for one frame and the animation was interrupted this way.

Fixed it right before this comment.

[mountiny]

Ok thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅