[Internal QA] Update Company Cards page to potentially show domain feeds by VickyStash · Pull Request #60261 · Expensify/App

VickyStash · 2025-04-15T09:57:32Z

Explanation of Change

Update Company Cards page to potentially show domain feeds.

Fixed Issues

$ #59837
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Create an account that is an admin on domainA and policyB
In the OD add a third party domain feed to domainA and set policyB as the preferred policy
Open policyB in NewDot and go to the Company Cards page
Make sure the feed shows up (NOTE there is a known BE issue when the third party domain feed cards are not returned in the ND, so you won't see the cards list, but you should see the feed on its own).
Add a workspace third party feed to policyB in the ND. Make sure you can assign cards, edit the settings, etc.

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

web.mp4

…ompany-cards # Conflicts: # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

…ompany-cards

VickyStash · 2025-04-16T10:14:51Z

The failing ESLint Check is caused by new rule, this PR has 42 places to update. I can fix that, but it will significantly complicate the PR and its testing.
Also, it would be good to wait for an official announcement/documentation regarding these updates.

melvin-bot · 2025-04-16T10:58:04Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/hooks/useCardFeeds.tsx

DylanDylann · 2025-04-17T08:15:49Z

I am fine to skip the eslint error in this PR if this PR is urgent

DylanDylann · 2025-04-17T08:16:12Z

@VickyStash Could you solve conflict and address my above comments

…ompany-cards # Conflicts: # src/pages/workspace/WorkspaceOverviewPage.tsx # src/pages/workspace/WorkspacesListPage.tsx

VickyStash · 2025-04-17T08:55:30Z

@DylanDylann Please, take another look!

DylanDylann · 2025-04-17T09:15:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-17.at.17.19.56.mov

Android: mWeb Chrome

Screen.Recording.2025-04-17.at.17.20.24.mov

iOS: Native

Screen.Recording.2025-04-17.at.17.19.15.mov

iOS: mWeb Safari

Screen.Recording.2025-04-17.at.17.19.39.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-17.at.17.17.38.mov

MacOS: Desktop

Screen.Recording.2025-04-17.at.17.18.07.mov

src/hooks/useCardFeeds.tsx

…ompany-cards # Conflicts: # src/pages/workspace/WorkspaceOverviewPage.tsx # src/pages/workspace/WorkspacesListPage.tsx

puneetlath · 2025-04-17T21:12:18Z

Looks like lint check is failing.

OSBotify · 2025-04-18T13:11:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-18T20:42:30Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.1.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2025-04-19T03:45:21Z

@DylanDylann @puneetlath Would you validate this internally as per issue title?

puneetlath · 2025-04-21T16:56:39Z

Seems to be working. Here's two domain feeds showing up:

github-actions · 2025-04-21T23:21:10Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.30-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Implement useCardFeeds hook

8cffd51

VickyStash mentioned this pull request Apr 15, 2025

[Due for payment 2025-04-28] Update Company Cards page to potentially show domain feeds #59837

Closed

Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…

c3eaf73

…ompany-cards # Conflicts: # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

VickyStash changed the title ~~[WIP] Update Company Cards page to potentially show domain feeds~~ [WIP] [Internal QA] Update Company Cards page to potentially show domain feeds Apr 16, 2025

VickyStash added 3 commits April 16, 2025 10:56

Update useCardFeed hook

92df591

Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…

9598359

…ompany-cards

Fix ts error

31236b9

VickyStash changed the title ~~[WIP] [Internal QA] Update Company Cards page to potentially show domain feeds~~ [Internal QA] Update Company Cards page to potentially show domain feeds Apr 16, 2025

VickyStash marked this pull request as ready for review April 16, 2025 10:57

VickyStash requested a review from a team as a code owner April 16, 2025 10:57

melvin-bot bot requested review from DylanDylann and removed request for a team April 16, 2025 10:58

DylanDylann reviewed Apr 17, 2025

View reviewed changes

src/hooks/useCardFeeds.tsx Outdated Show resolved Hide resolved

src/hooks/useCardFeeds.tsx Outdated Show resolved Hide resolved

VickyStash added 2 commits April 17, 2025 10:29

Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…

808fe39

…ompany-cards # Conflicts: # src/pages/workspace/WorkspaceOverviewPage.tsx # src/pages/workspace/WorkspacesListPage.tsx

Apply reviewer feedback

2b0c298

VickyStash requested a review from DylanDylann April 17, 2025 08:55

DylanDylann approved these changes Apr 17, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath April 17, 2025 10:21

puneetlath requested changes Apr 17, 2025

View reviewed changes

src/hooks/useCardFeeds.tsx Show resolved Hide resolved

VickyStash added 2 commits April 17, 2025 22:13

Merge branch 'refs/heads/main' into VickyStash/feature/59837-domain-c…

82611fc

…ompany-cards # Conflicts: # src/pages/workspace/WorkspaceOverviewPage.tsx # src/pages/workspace/WorkspacesListPage.tsx

Describe useCardFeeds hook

5f04b71

puneetlath previously approved these changes Apr 17, 2025

View reviewed changes

Add canBeMissing flags to fix lint errors

2528c8c

VickyStash dismissed puneetlath’s stale review via 2528c8c April 18, 2025 07:38

puneetlath approved these changes Apr 18, 2025

View reviewed changes

puneetlath merged commit fd4b9ad into Expensify:main Apr 18, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 18, 2025

Deploy Checklist: New Expensify 2025-04-18 #60506

Closed

64 tasks

nkdengineer mentioned this pull request Apr 19, 2025

[HOLD for payment 2025-05-05] Cards - Adding a card & refreshing page displays learn more page briefly #60533

Closed

8 tasks

VickyStash mentioned this pull request Apr 22, 2025

Fix company cards page loading #60629

Merged

50 tasks

Conversation

VickyStash commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash commented Apr 16, 2025

Uh oh!

melvin-bot bot commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Apr 17, 2025

Uh oh!

DylanDylann commented Apr 17, 2025

Uh oh!

VickyStash commented Apr 17, 2025

Uh oh!

DylanDylann commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

puneetlath commented Apr 17, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

mvtglobally commented Apr 19, 2025

Uh oh!

puneetlath commented Apr 21, 2025

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Apr 15, 2025 •

edited

Loading

DylanDylann commented Apr 17, 2025 •

edited

Loading