Add workspace autocomplete list and highlighting by 289Adam289 · Pull Request #60424 · Expensify/App

289Adam289 · 2025-04-17T12:27:35Z

Explanation of Change

Fixed Issues

$ #59367
PROPOSAL:

Tests

Use SearchRouter of Reports Page search input
Enter workspace:
Verify that autocomplete list of workspaces appear
Try using the list make sure it work similar to the other filters
Verify that correct Workspace name are highlighted
Verify that filter can be set using the advanced filters

Verify that no errors appear in the JS console

Offline tests

QA Steps

Use SearchRouter of Reports Page search input
Enter workspace:
Verify that autocomplete list of workspaces appear
Try using the list make sure it work similar to the other filters
Verify that correct Workspace name are highlighted
Verify that filter can be set using the advanced filters

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-04-22.at.12.30.10.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-04-22.at.12.18.25.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-22.at.12.05.27.mov

MacOS: Desktop

289Adam289 · 2025-04-17T14:18:19Z

@Expensify/design @flaviadefaria @mountiny @WojtekBoman This pr is pretty much ready. Could you trigger an adhoc build and test it.

289Adam289 · 2025-04-17T14:24:41Z

There is a bug currently on main that makes a search router behave weirdly. I fixed it in the last commit so the router can be tested in adhoc builds.

shawnborton · 2025-04-17T15:17:42Z

Will trigger a build now.

github-actions · 2025-04-17T15:18:14Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

dannymcclain · 2025-04-18T13:18:46Z

Highlight is looking pretty good to me!

mountiny · 2025-04-22T13:52:04Z

@289Adam289 How is this one looking?

Kicu

Looks pretty straightforward 👍

I only left minor ideas for code improvements, nothing big.

Kicu · 2025-04-22T14:49:28Z

src/libs/SearchAutocompleteUtils.ts

        case CONST.SEARCH.SYNTAX_FILTER_KEYS.FEED:
        case CONST.SEARCH.SYNTAX_FILTER_KEYS.CARD_ID:
+        case CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID:
            return substitutionMap[`${range.key}:${range.value}`] !== undefined;


No bugs here 👍 I noticed a small improvement that we could do.

The way this key is built: ${range.key}:${range.value} should be the exact same way that we build it inside autocompleteMap.
There is a local getSubstitutionsKey() function in buildSubstitutionsMap (and duplicated in 1 other file as well).
We could extract it, and reuse here - just to be super clean 😎

Kicu · 2025-04-22T14:52:30Z

src/libs/SearchQueryUtils.ts


+/**
+ * A copy of `getFilterDisplayValue` handling the policy ID, used if you have access to the leftHandBar beta.
+ * When this beta is no longer needed, this method will be renamed to `getFilterDisplayValue` and will replace the old method.


The cleanest thing we can do here is to mark this with @Todo and then link the correct issue for the cleanup (I think @WojtekBoman can probably help us find the proper one).
@todo comments stand out more than normal comments

Would be good to tie it to some issue so we do not forget this

src/components/Search/SearchAutocompleteList.tsx

289Adam289 · 2025-04-22T16:40:29Z

@289Adam289 How is this one looking?

I think we are ready for review

melvin-bot · 2025-04-22T16:40:39Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-04-22T23:08:44Z

@dukenv0307 @dannymcclain ready for a review

github-actions · 2025-04-22T23:09:00Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-22T23:39:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60424-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60424-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/60424/NewExpensify.dmg	https://60424.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dukenv0307 · 2025-04-23T08:49:55Z

code looks good

dukenv0307 · 2025-04-23T09:07:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-23.at.15.55.10.mov

Android: mWeb Chrome

Screen.Recording.2025-04-23.at.15.53.44.mov

iOS: Native

Screen.Recording.2025-04-23.at.15.54.43.mov

iOS: mWeb Safari

Screen.Recording.2025-04-23.at.15.53.10.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-23.at.15.47.54.mov

MacOS: Desktop

Screen.Recording.2025-04-23.at.15.58.11.mov

dukenv0307

LGTM

mountiny

Thanks!

mountiny · 2025-04-23T10:56:01Z

src/libs/SearchQueryUtils.ts


+/**
+ * A copy of `getFilterDisplayValue` handling the policy ID, used if you have access to the leftHandBar beta.
+ * When this beta is no longer needed, this method will be renamed to `getFilterDisplayValue` and will replace the old method.


Would be good to tie it to some issue so we do not forget this

OSBotify · 2025-04-23T11:08:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-23T18:45:24Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-04-23T18:47:27Z

@289Adam289 Any steps for QA team?

289Adam289 · 2025-04-23T19:24:07Z

@izarutskaya

Sorry I forgot about that

Use SearchRouter of Reports Page search input
Enter workspace:
Verify that autocomplete list of workspaces appear
Try using the list make sure it work similar to the other filters
Verify that correct Workspace name are highlighted
Verify that filter can be set using the advanced filters

github-actions · 2025-04-28T19:52:16Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

289Adam289 added 5 commits April 17, 2025 14:20

update autocomplete parser

40d0258

add workspace highlighting

b4010cc

Add workspace autocomplete list

17453df

fix tests typescripts

f18e704

Add canBeMissing param

dd58318

This comment has been minimized.

Sign in to view

mountiny assigned 289Adam289 Apr 17, 2025

289Adam289 force-pushed the 289Adam289/59367-add-workspace-autocomplete branch from 4fd0ba8 to dd58318 Compare April 22, 2025 07:16

289Adam289 added 3 commits April 22, 2025 09:26

Merge branch 'main' into 289Adam289/59367-add-workspace-autocomplete

6bf2ed3

fix can be missing param for reports

629aafe

fix comment

047f543

mountiny requested a review from dukenv0307 April 22, 2025 13:52

Kicu approved these changes Apr 22, 2025

View reviewed changes

review comments

7f259f5

289Adam289 marked this pull request as ready for review April 22, 2025 16:40

289Adam289 requested a review from a team as a code owner April 22, 2025 16:40

melvin-bot bot requested review from mountiny and removed request for a team April 22, 2025 16:40

dukenv0307 approved these changes Apr 23, 2025

View reviewed changes

mountiny approved these changes Apr 23, 2025

View reviewed changes

mountiny merged commit 8a9ecc6 into Expensify:main Apr 23, 2025
19 checks passed

github-actions bot mentioned this pull request Apr 23, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Closed

91 tasks

Conversation

289Adam289 commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

289Adam289 commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

289Adam289 commented Apr 17, 2025

Uh oh!

shawnborton commented Apr 17, 2025

Uh oh!

github-actions bot commented Apr 17, 2025

Uh oh!

This comment has been minimized.

dannymcclain commented Apr 18, 2025

Uh oh!

mountiny commented Apr 22, 2025

Uh oh!

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

Kicu Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

Kicu Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

289Adam289 commented Apr 22, 2025

Uh oh!

melvin-bot bot commented Apr 22, 2025

Uh oh!

mountiny commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

dukenv0307 commented Apr 23, 2025

Uh oh!

dukenv0307 commented Apr 23, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

izarutskaya commented Apr 23, 2025

Uh oh!

289Adam289 commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

289Adam289 commented Apr 17, 2025 •

edited

Loading

289Adam289 commented Apr 17, 2025 •

edited

Loading