Skip to content

Search - Cursor is not moved to the end after selecting for the suggestion #60435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarioExpensify merged 6 commits into from
Apr 25, 2025
Merged

Search - Cursor is not moved to the end after selecting for the suggestion #60435

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0909c5
fix: cursor not move to end after select suggestion
thelullabyy Apr 17, 2025
2d271d8
Merge branch 'main' into fix/59646-cursor-not-move-to-end-on-select-s…
thelullabyy Apr 22, 2025
dbc28f6
fix ESlint canBeMissing
thelullabyy Apr 22, 2025
374bae8
update canBeMissing value
thelullabyy Apr 23, 2025
27eb62f
Merge branch 'main' into fix/59646-cursor-not-move-to-end-on-select-s…
thelullabyy Apr 24, 2025
8520671
fix canBeMissing
thelullabyy Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});
const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false});
const taxRates = useMemo(() => getAllTaxRates(), []);
const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: false});
const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: true});
const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: true});
const allCards = useMemo(() => mergeCardListWithWorkspaceFeeds(workspaceCardFeeds ?? CONST.EMPTY_OBJECT, userCardList), [userCardList, workspaceCardFeeds]);
const cardFeedNamesWithType = useMemo(() => {
Expand Down Expand Up @@ -259,6 +259,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
<SearchInputSelectionWrapper
value={textInputValue}
substitutionMap={autocompleteSubstitutions}
selection={selection}
onSearchQueryChange={onSearchQueryChange}
isFullWidth
onSubmit={() => {
Expand Down Expand Up @@ -292,7 +293,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
autocompleteQueryValue={autocompleteQueryValue}
searchQueryItem={searchQueryItem}
onListItemPress={onListItemPress}
setTextQuery={setTextInputValue}
setTextQuery={setTextAndUpdateSelection}
updateAutocompleteSubstitutions={updateAutocompleteSubstitutions}
ref={listRef}
/>
Expand Down