Toggle selection with long press when selection mode is enabled by ChavdaSachin · Pull Request #60595 · Expensify/App

ChavdaSachin · 2025-04-21T21:27:46Z

Explanation of Change

Fixed Issues

$ #60320
PROPOSAL: #60320 (comment)

Tests

Same as QA
There are a few console errors relevant to 'canBeMissing' but those are irrelevant to this PR.

Verify that no errors appear in the JS console

Offline tests

Same as QA.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Note

these tests are only for small screen devices.

Pre-requisites: A workspace with -Distance Rates, Categories, Tags, Taxes and Report Fields enabled.

Navigate to workspace -> members page.
Enable selection mode- ie. long press a row and click select when popover menu is visible.
Now long press on few row one by one.
Verify long pressing a row in selection mode acts the same as simple click.(ie. toggles the selection)
Now repeat step 1-4 for workspace -> Distance Rates, workspace -> Categories, workspace -> Tags, workspace -> Taxes and workspace -> Report Fields.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-02.at.12.45.45.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-05-02.at.12.50.43.AM.mov

iOS: Native

Screen.Recording.2025-05-02.at.2.17.16.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-02.at.2.21.17.AM.mov

MacOS: Chrome / Safari

MacOS: Desktop

ChavdaSachin · 2025-04-21T21:39:28Z

@dubielzyk-expensify currently there are two different checkmark icons are being used.

Categories, Tags, Members, Etc...(with box)

Search Page(without box)

Could you confirm if all pages should use the same icon for checkmark? if yes, then which?

dubielzyk-expensify · 2025-04-22T02:59:08Z

Interesting. Didn't know that. Great catch 👍 I would think we'd use the boxy one, but I'll defer to @dannymcclain here and maybe @shawnborton has some opinions too.

shawnborton · 2025-04-22T10:11:01Z

Agree, I think the boxier one makes more sense but let's let El Rey De Los Icons give us the final ruling here.

dannymcclain · 2025-04-22T13:02:16Z

El Rey De Los Icon

🤣

The square check (box) is the correct one for this!

ChavdaSachin · 2025-04-29T05:28:11Z

@shubham1206agra this is what it looks like from my end.

shubham1206agra · 2025-04-29T12:45:24Z

src/components/Search/SearchList.tsx

+            return;
+        }
+        if (isSmallScreenWidth && selectionMode?.isEnabled) {
+            onCheckboxPress?.(item);


@ChavdaSachin You don't need to touch this code as this was implemented in #60800

Merge main and fix this conflict

shubham1206agra · 2025-04-30T02:22:13Z

assets/images/empty-square.svg

@ChavdaSachin Please don't remove this. Since it might be used later somewhere else.

I did this as per your suggestion but now there's a lint error.
Should I again remove that file and perform relevant cleanup?

melvin-bot · 2025-05-01T21:20:24Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ChavdaSachin · 2025-04-23T20:41:05Z

src/components/Search/SearchList.tsx

-        },
-        [isFocused, isSmallScreenWidth, shouldPreventLongPressRow],
-    );
+    const handleLongPressRow = (item: SearchListItem) => {


@shubham1206agra could I add a lint ignore comment here?

previously handleLongPressRow was wrapped with useCallback hook, but currently I had to remove useCallback in-order to make it work.

the problem: if handleLongPressRow is wrapped in useCallback, it would memoize the function and would return the memoized version which would lead to a bug -

go to search page(small screen device)

turn on selection mode

long press a few items

notice as soon as third item is selected, second item is unselected due to memoized version of the function.

two possible solution:

add lint ignore comment

remove useCallback from renderItem function(which is not ideal)

cc. @mollfpr

@shubham1206agra bump on above.

ChavdaSachin · 2025-05-01T21:22:45Z

assets/images/empty-square.svg

I did this as per your suggestion but now there's a lint error.
Should I again remove that file and perform relevant cleanup?

src/components/Icon/Expensicons.ts

This reverts commit a37ad52.

ChavdaSachin · 2025-05-02T13:27:32Z

Thanks @shubham1206agra.
Changes are up, PR is ready.

shubham1206agra · 2025-05-03T06:41:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-03.at.12.09.04.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-05-03.at.11.54.56.AM.mov

iOS: HybridApp

Screen.Recording.2025-05-03.at.12.01.54.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-03.at.11.50.44.AM.mov

MacOS: Chrome / Safari

NA

MacOS: Desktop

NA

mollfpr

Thank you 🙏

OSBotify · 2025-05-05T06:33:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-06T01:26:23Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.1.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-07T00:07:07Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Toggle selection with long press when selection mode is enabled

e3f2fc5

shubham1206agra reviewed Apr 29, 2025

View reviewed changes

ChavdaSachin added 4 commits April 30, 2025 02:35

Merge main

0e85158

Cleanup

926f68f

Remove deprecated test case

81790ea

cleanup

a37ad52

shubham1206agra reviewed Apr 30, 2025

View reviewed changes

ChavdaSachin added 2 commits May 1, 2025 21:39

Revert the cleanup

1becd32

cleanup

24b9cfc

ChavdaSachin marked this pull request as ready for review May 1, 2025 21:20

ChavdaSachin requested a review from a team as a code owner May 1, 2025 21:20

melvin-bot bot requested a review from shubham1206agra May 1, 2025 21:20

melvin-bot bot removed the request for review from a team May 1, 2025 21:20

ChavdaSachin mentioned this pull request May 1, 2025

[Due for payment 2025-05-14] [$250] Reports - Long pressing on an item does not display "Deselect" option #60320

Closed

18 tasks

ChavdaSachin commented May 1, 2025

View reviewed changes

shubham1206agra reviewed May 2, 2025

View reviewed changes

src/components/Icon/Expensicons.ts Show resolved Hide resolved

Revert "cleanup"

12ce89b

This reverts commit a37ad52.

shubham1206agra approved these changes May 3, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr May 3, 2025 06:41

mollfpr approved these changes May 5, 2025

View reviewed changes

mollfpr merged commit 3f70f73 into Expensify:main May 5, 2025
17 checks passed

github-actions bot mentioned this pull request May 6, 2025

Deploy Checklist: New Expensify 2025-05-06 #61424

Closed

77 tasks

ChavdaSachin deleted the SelectionMode-treat-long-press-as-single-click branch July 28, 2025 12:27

Conversation

ChavdaSachin commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ChavdaSachin commented Apr 21, 2025

Uh oh!

dubielzyk-expensify commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 22, 2025

Uh oh!

dannymcclain commented Apr 22, 2025

Uh oh!

ChavdaSachin commented Apr 29, 2025

Uh oh!

shubham1206agra Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin May 1, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 1, 2025

Uh oh!

ChavdaSachin Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin May 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChavdaSachin commented May 2, 2025

Uh oh!

shubham1206agra commented May 3, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 5, 2025

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ChavdaSachin commented Apr 21, 2025 •

edited

Loading

dubielzyk-expensify commented Apr 22, 2025 •

edited

Loading