Delete stale login when creating a new one #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
requested changes
Oct 6, 2020
src/lib/API.js
Outdated
|
|
||
| if (credentials && credentials.login) { | ||
| // If we have an old login for some reason, we should delete it before storing the new details | ||
| // eslint-disable-next-line no-use-before-define |
Contributor
There was a problem hiding this comment.
Can you just move the position of deleteLogin() instead? I think it looks OK to do so from looking at the code.
Contributor
Author
There was a problem hiding this comment.
Ah yup, this was leftover from when I was doing some crazy different logic to make it work. Reorganized
Contributor
Author
|
Updated |
tgolen
approved these changes
Oct 7, 2020
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgolen can you review please?
The only reason I could find that logins were stacking up is somehow being signed out without hitting the
signOutmethod inSession. When this would happen, we would create a new login on signing in without first deleting the old login. This adds a check that will delete our existing login ifcredentials.loginexists when creating a new login.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/141184
Tests
react-native-chatsecondary devices / logins from your test accountsessionkey. This will sign you out without hitting thesignOutflowScreenshots
N/A