Skip to content

Fix master #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewGable merged 1 commit into from
Oct 6, 2020
Merged

Fix master #607

AndrewGable merged 1 commit into from
Oct 6, 2020

Conversation

@marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 6, 2020

Fixed Issues

Fixes No Issue just a follow up to #560 which seems to have broken master

Tests

  1. Build web
  2. Verify it works

Screenshots

❌

@marcaaron marcaaron self-assigned this Oct 6, 2020
AndrewGable
AndrewGable approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-10-06 at 3 25 28 PM

@AndrewGable AndrewGable merged commit 4eb4885 into master Oct 6, 2020
@AndrewGable AndrewGable deleted the marcaaron-resolveJSX branch October 6, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@tgolen tgolen Awaiting requested review from tgolen

Assignees

@marcaaron marcaaron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcaaron @AndrewGable