🍒 Cherry pick PR #60824 to staging 🍒 by os-botify[bot] · Pull Request #60861 · Expensify/App

os-botify · 2025-04-24T19:10:16Z

🍒 Cherry pick #60824 to staging 🍒

This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:

git fetch
git checkout cherry-pick-staging-60824-14649716162-1
git cherry-pick -S -x --mainline 1 0e0c1850c78471bc1f74e70dfb1b790024104329

Then manually resolve conflicts, and commit the change with git cherry-pick --continue. Lastly, please run:

git commit --amend -m "$(git log -1 --pretty=%B)" -m "(CP triggered by mountiny)"

That will help us keep track of who triggered this CP. Once all that's done, push your changes with git push origin cherry-pick-staging-60824-14649716162-1, and then open this PR for review.

Note that you must test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.

Pro-tip: If this PR appears to have conflicts against the staging base, it means that the version on staging has been updated. The easiest thing to do if you see this is to close the PR and re-run the CP.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

(cherry picked from commit 1b4ca6c)

melvin-bot · 2025-04-24T19:10:46Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ove-0-00 [CP Staging] Fix amount value in header & report preview (cherry picked from commit 0e0c185) (CP triggered by mountiny)

luacmartins

LGTM

luacmartins · 2025-04-24T19:51:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-04-24.at.1.50.17.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-04-24T21:16:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.32-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-28T19:53:37Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-28T20:24:22Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T19:58:16Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.35-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-04-29T20:53:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.36-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T22:19:19Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-04-30T00:47:22Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify added 2 commits April 24, 2025 19:10

Update version to 9.1.32-1

1db3a13

(cherry picked from commit 1b4ca6c)

Update Mobile-Expensify submodule version to 9.1.32-1

6ad9265

os-botify bot added the Engineering label Apr 24, 2025

os-botify bot requested a review from a team as a code owner April 24, 2025 19:10

os-botify bot added the Hourly KSv2 label Apr 24, 2025

os-botify bot assigned mountiny and JakubKorytko Apr 24, 2025

melvin-bot bot requested review from lakchote and removed request for a team April 24, 2025 19:10

Merge pull request #60824 from software-mansion-labs/korytko/fix-appr…

2830993

…ove-0-00 [CP Staging] Fix amount value in header & report preview (cherry picked from commit 0e0c185) (CP triggered by mountiny)

luacmartins requested review from luacmartins and removed request for lakchote April 24, 2025 19:34

Add useSelectedTransactionsActions

4f16700

luacmartins previously approved these changes Apr 24, 2025

View reviewed changes

Resolve merge conflicts

4da0102

mountiny dismissed luacmartins’s stale review via 4da0102 April 24, 2025 20:09

mountiny requested a review from luacmartins April 24, 2025 20:11

luacmartins approved these changes Apr 24, 2025

View reviewed changes

luacmartins merged commit 76520a6 into staging Apr 24, 2025
7 checks passed

luacmartins deleted the cherry-pick-staging-60824-14649716162-1 branch April 24, 2025 20:18

github-actions bot mentioned this pull request Apr 24, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Closed

91 tasks

github-actions bot mentioned this pull request Apr 28, 2025

Deploy Checklist: New Expensify 2025-04-28 #60971

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🍒 Cherry pick PR #60824 to staging 🍒#60861

🍒 Cherry pick PR #60824 to staging 🍒#60861
luacmartins merged 5 commits intostagingfrom
cherry-pick-staging-60824-14649716162-1

os-botify bot commented Apr 24, 2025 •

edited by mountiny

Loading

Uh oh!

melvin-bot bot commented Apr 24, 2025

Uh oh!

luacmartins left a comment

Uh oh!

luacmartins commented Apr 24, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

os-botify bot commented Apr 24, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 24, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Apr 24, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

os-botify bot commented Apr 24, 2025 •

edited by mountiny

Loading