fix: Onboarding - You appears to be offline appears in left without margin. by Krishna2323 · Pull Request #60944 · Expensify/App

Krishna2323 · 2025-04-26T19:12:39Z

Explanation of Change

Fixed Issues

$ #60643
PROPOSAL: #60643 (comment)

Tests

Create a new account with any gmail id
Tap join
Turn off internet
Verify offline message has left padding on "What's your work email" page
Tap skip
Verify offline message has left padding in "What you want to do today"
Test all the pages in each option on "What you want to do today" and verify offline message has left padding

Verify that no errors appear in the JS console

Offline tests

Need to create the account with internet connection

Create a new account with any gmail id
Tap join
Turn off internet
Verify offline message has left padding on "What's your work email" page
Tap skip
Verify offline message has left padding in "What you want to do today"
Test all the pages in each option on "What you want to do today" and verify offline message has left padding

QA Steps

Create a new account with any gmail id
Tap join
Turn off internet
Verify offline message has left padding on "What's your work email" page
Tap skip
Verify offline message has left padding in "What you want to do today"
Test all the pages in each option on "What you want to do today" and verify offline message has left padding

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…argin. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-04-26T19:53:33Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-04-26T19:55:04Z

Not sure why the checks are failing, doesn't seem to be related to this PR.

parasharrajat

Are we good with other onboarding steps? Please check that.
Make sure design is not changed with your changes.

parasharrajat · 2025-04-28T06:07:33Z

We might have to merge main to solve this. Keep a watch on slack for this.

Krishna2323 · 2025-04-28T09:34:11Z

@parasharrajat, I have verified the changes again, and they work fine based on my testing. In the comparison below, the emulator is running the main branch.

Work emails (Android Chrome)	Work emails (Android Native)

Purpose (Android Chrome)	Purpose (Android Native)

Personal Details (Android Chrome)	Personal Details (Android Native)

Employees (Android Chrome)	Employees (Android Native)

Accounting (Android Chrome)	Accounting (Android Native)

Krishna2323 · 2025-05-01T20:15:04Z

@parasharrajat, friendly bump for review.

parasharrajat · 2025-05-02T13:42:05Z

@Krishna2323 I can see that there are a few onboarding steps where we are showing indicator all the time but here we are only showing on small screens. What is reason for that difference?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-05-03T19:48:51Z

I can see that there are a few onboarding steps where we are showing indicator all the time

@parasharrajat, I'm not sure which specific onboarding step you're referring to—could you please clarify?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat · 2025-05-03T20:09:56Z

src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

-                            progressBarPercentage={isPrivateDomainAndHasAccesiblePolicies ? 60 : 20}
-                        />
+        <ScreenWrapper
+            includeSafeAreaPaddingBottom={false}


Why this is false here?

My mistake — it shouldn't be false here because we were using the safe area padding bottom with SafeAreaConsumer. Updated.

parasharrajat · 2025-05-04T16:12:00Z

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

        <ScreenWrapper
            shouldEnableMaxHeight
-            shouldShowOfflineIndicator={false}
+            shouldShowOfflineIndicator={isSmallScreenWidth}


I don't think we need to pass isSmallScreenWidth to shouldShowOfflineIndicator prop in ScreenWrapper. Internally, it uses this. We also don't need to pass this prop as it is true by default.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat

There is extra margin between the continue button and offline indicator on

Employees
Accounting Step.

It should with other screens like personal-details. I think we just need to pass includeSafeAreaPaddingBottom=False to SelectionList on Boarding steps. Please check for other steps as well which use SelectionList.

parasharrajat · 2025-05-05T15:52:05Z

@Krishna2323 Waiting on your changes to wrap this one

…ing flow. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-05-06T05:38:14Z

It should with other screens like personal-details. I think we just need to pass includeSafeAreaPaddingBottom=False to SelectionList on Boarding steps. Please check for other steps as well which use SelectionList.

@parasharrajat, checked and updated. includeSafeAreaPaddingBottom={false} works well.

parasharrajat · 2025-05-06T11:02:42Z

Screenshots

🔲 iOS / native

06.05.2025_16.24.48_REC.mp4

🔲 iOS / Safari

06.05.2025_16.20.55_REC.mp4

🔲 MacOS / Desktop

06.05.2025_17.00.18_REC.mp4

🔲 MacOS / Chrome

06.05.2025_15.36.02_REC.mp4

06.05.2025_15.34.49_REC.mp4

🔲 Android / Chrome

06.05.2025_15.54.33_REC.mp4

🔲 Android / native

06.05.2025_16.48.59_REC.mp4

parasharrajat · 2025-05-06T11:41:44Z

src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

                ListItem={RadioListItem}
                footerContent={footerContent}
                listItemWrapperStyle={onboardingIsMediumOrLargerScreenWidth ? [styles.pl8, styles.pr8] : []}
+                includeSafeAreaPaddingBottom={false}


Now we should enable the safeAreabottom padding on ScreenWrapper. Same for Accounting step. @Krishna2323

@parasharrajat, tested and updated.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2025-05-07T01:44:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-08T00:16:22Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.1.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-09T09:26:50Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.1.43-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T17:52:33Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Krishna2323 added 2 commits April 27, 2025 00:15

fix: Onboarding - You appears to be offline appears in left without m…

33046d2

…argin. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix ESLint.

d37230d

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review April 26, 2025 19:53

Krishna2323 requested a review from a team as a code owner April 26, 2025 19:53

melvin-bot bot requested review from parasharrajat and removed request for a team April 26, 2025 19:53

parasharrajat suggested changes Apr 28, 2025

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/60643

887ffa8

Merge branch 'Expensify:main' into krishna2323/issue/60643

cf2d3d5

Krishna2323 added 2 commits May 3, 2025 23:33

Merge branch 'main' into krishna2323/issue/60643

f4741df

fix BaseOnboardingPrivateDomain.

bad0465

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

remove unused import.

3a5694e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat suggested changes May 4, 2025

View reviewed changes

use default value of shouldShowOfflineIndicator prop.

90758d4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat suggested changes May 5, 2025

View reviewed changes

add includeSafeAreaPaddingBottom={false} to slection lists in onboard…

cc889f5

…ing flow. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat reviewed May 6, 2025

View reviewed changes

Krishna2323 added 2 commits May 7, 2025 03:49

Merge branch 'Expensify:main' into krishna2323/issue/60643

54b4f3a

add includeSafeAreaPaddingBottom to ScreenWrapper.

170aaaf

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

parasharrajat approved these changes May 6, 2025

View reviewed changes

melvin-bot bot requested a review from srikarparsi May 6, 2025 23:59

srikarparsi approved these changes May 7, 2025

View reviewed changes

srikarparsi merged commit 1cbc72c into Expensify:main May 7, 2025
17 of 18 checks passed

github-actions bot mentioned this pull request May 7, 2025

Deploy Checklist: New Expensify 2025-05-07 #61626

Closed

90 tasks

melvin-bot bot mentioned this pull request May 13, 2025

[Due for payment 2025-05-20] [$250] onboarding-You appears to be offline appears in left without margin. #60643

Closed

8 tasks

Conversation

Krishna2323 commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 26, 2025

Uh oh!

Krishna2323 commented Apr 26, 2025

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Apr 28, 2025

Uh oh!

Krishna2323 commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented May 1, 2025

Uh oh!

parasharrajat commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented May 3, 2025

Uh oh!

parasharrajat May 3, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat May 4, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 May 5, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented May 5, 2025

Uh oh!

Krishna2323 commented May 6, 2025

Uh oh!

parasharrajat commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 May 6, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Uh oh!

OSBotify commented May 7, 2025

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Krishna2323 commented Apr 26, 2025 •

edited

Loading

Krishna2323 commented Apr 28, 2025 •

edited

Loading

parasharrajat commented May 2, 2025 •

edited

Loading

Krishna2323 May 5, 2025 •

edited

Loading

parasharrajat left a comment •

edited

Loading

parasharrajat commented May 6, 2025 •

edited

Loading