[Desktop Navigation] Remove leftHandBar beta by WojtekBoman · Pull Request #61066 · Expensify/App

WojtekBoman · 2025-04-29T12:46:02Z

Explanation of Change

This PR removes the leftHandBar beta

Fixed Issues

$ #59371
$ #59372
$ #59373
$ #59369
$ #59366

PROPOSAL:

Tests

Verify that no errors appear in the JS console

Verify if the Left Hand Bar is displayed correctly and Workspace filter in the Reports tab works fine

Offline tests

QA Steps

Verify if the Left Hand Bar is displayed correctly and Workspace filter in the Reports tab works fine

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-04-30.at.08.48.25.mov

iOS: mWeb Safari

Screen.Recording.2025-04-30.at.09.01.44.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-29.at.20.19.52.mov

MacOS: Desktop

Screen.Recording.2025-04-29.at.20.21.07.mov

dukenv0307 · 2025-04-29T14:16:20Z

Is it ready for review @WojtekBoman ?

WojtekBoman · 2025-04-29T17:52:01Z

Is it ready for review @WojtekBoman ?

It's ready :)

dukenv0307 · 2025-04-30T03:07:27Z

src/pages/home/report/ReportFooter.tsx

-    const [shouldShowComposeInput] = useOnyx(ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT, {initialValue: false});
-    const [isAnonymousUser = false] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.authTokenType === CONST.AUTH_TOKEN_TYPES.ANONYMOUS});
+    const [shouldShowComposeInput] = useOnyx(ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT, {initialValue: false, canBeMissing: true});
+    const [isAnonymousUser = false] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.authTokenType === CONST.AUTH_TOKEN_TYPES.ANONYMOUS, canBeMissing: true});


canBeMissing should be false here

dukenv0307 · 2025-04-30T03:10:03Z

src/pages/ConciergePage.tsx

-    const {canUseLeftHandBar} = usePermissions();

-    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED);
+    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED, {canBeMissing: false});


I think canBeMissing should be true, we did the same in other place

dukenv0307 · 2025-04-30T03:10:41Z

src/pages/ConciergePage.tsx

+    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED, {canBeMissing: false});
    const viewTourTaskReportID = introSelected?.viewTour;
-    const [viewTourTaskReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourTaskReportID}`);
+    const [viewTourTaskReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourTaskReportID}`, {canBeMissing: false});


same as above

dukenv0307 · 2025-04-30T03:35:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-30.at.10.27.11.mov

Android: mWeb Chrome

Screen.Recording.2025-04-30.at.10.21.55.mov

iOS: Native

Screen.Recording.2025-04-30.at.10.26.57.mov

iOS: mWeb Safari

Screen.Recording.2025-04-30.at.10.22.08.mov

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

Screen.Recording.2025-04-30.at.10.29.50.mov

dukenv0307 · 2025-04-30T03:35:58Z

looks good, I just left some minor comments

WojtekBoman · 2025-04-30T06:15:00Z

Comments resolved
cc: @mountiny @dukenv0307

melvin-bot · 2025-04-30T06:15:05Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-04-30T07:10:13Z

🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #61155.

github-actions · 2025-04-30T13:33:59Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny

@WojtekBoman minor changes requested

src/components/FloatingActionButton.tsx

shawnborton · 2025-04-30T14:25:30Z

Test build keeps crashing for me :(

WojtekBoman · 2025-04-30T14:34:50Z

Test build keeps crashing for me :(

Great that you have found it! There is a problem, I'll fix it and let you know when it's ready to run new builds 🫡

WojtekBoman · 2025-04-30T14:42:36Z

@mountiny @Expensify/design The build problem should be solved now. Please run new builds and check if everything looks fine :)

There might be a problem with Changed files ESLint check because in HelpContent.tsx default ids are used, but they are needed to avoid crashes.

github-actions · 2025-04-30T14:59:22Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-30T15:38:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61066-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61066-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61066/NewExpensify.dmg	https://61066.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

WojtekBoman · 2025-05-05T07:41:55Z

@WojtekBoman Can you please merge main? Then we can merge

Done!

OSBotify · 2025-05-05T08:19:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-06T01:27:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

pecanoro · 2025-05-06T10:41:48Z

I am not 100% sure, but I think this PR might have caused this bug on Safari: #61460

pecanoro · 2025-05-06T10:45:45Z

Nvm, regardless of Applause, I was able to reproduce on production as well so not coming from this

shawnborton · 2025-05-06T14:06:02Z

Interesting catch on the Safari bug! I wonder if that's a weird z-index thing or something? No idea!

github-actions · 2025-05-07T00:08:01Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

ikevin127 · 2025-05-15T01:03:51Z

src/libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions.ts


                    // We need to shift the sidebar to not be covered by the StackNavigator so it can be clickable.
-                    marginLeft: shouldUseNarrowLayout ? 0 : -sidebarWidth,
+                    marginLeft: shouldUseNarrowLayout ? 0 : -variables.sideBarWithLHBWidth,


The changes here caused this issue:

[Due for payment 2025-05-20] [$250] Safari - Left navigation bar disappears when onboarding modal/RHP is opened #61460

which was fixed in a follow-up PRs (#61506, #61679) by adjusting the styles of the sidebar screen to display LHB correctly on Safari.

QichenZhu · 2025-06-04T13:18:04Z

src/pages/home/report/ReportFooter.tsx

+        canBeMissing: true,
    });
-    const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID}`);
+    const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID}`, {canBeMissing: false});


This line is causing a "useOnyx returned no data for key with canBeMissing set to false" error.

@QichenZhu did you fix it anywhere already?

@mountiny not yet. I can take care of it if needed.

mountiny requested a review from dukenv0307 April 29, 2025 14:13

WojtekBoman force-pushed the improve-desktop-nav/remove-left-hand-bar-beta branch from 851f95c to e17a312 Compare April 29, 2025 17:14

dukenv0307 reviewed Apr 30, 2025

View reviewed changes

WojtekBoman marked this pull request as ready for review April 30, 2025 06:14

WojtekBoman requested review from a team as code owners April 30, 2025 06:14

melvin-bot bot requested a review from stitesExpensify April 30, 2025 06:15

melvin-bot bot removed the request for review from a team April 30, 2025 06:15

dukenv0307 approved these changes Apr 30, 2025

View reviewed changes

melvin-bot bot mentioned this pull request Apr 30, 2025

[Hold for payment 2025-06-03] Payment issue for E/App PR#61066 #61155

Closed

mountiny self-requested a review April 30, 2025 09:54

mountiny assigned WojtekBoman Apr 30, 2025

mountiny previously approved these changes Apr 30, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

WojtekBoman dismissed mountiny’s stale review via 3e59ffd April 30, 2025 14:26

WojtekBoman added 10 commits May 5, 2025 09:13

Remove duplicate SearchQueryUtils methods for leftHandBar

b033a64

Adjust POPOVER_ACCOUNT_SWITCHER_POSITION values for displaying LHB

25aa457

Remove unnecessary test checking passing policy id between navigators

9d92858

Remove unnecessary imports

7ea0eec

Add canBeMissing params

5b636c1

Add canBeMissing to ReportFooter

ff856d5

Adjust canBeMissing param values in ConciergePage and ReportFooter

0882001

Add backgroundColor to leftNavigationTabBarContainer

59e1c32

Remove leftNavigationTabBarPosition style

caa6d9f

Rename isLhbVisible to isLHBVisible

32fc713

WojtekBoman force-pushed the improve-desktop-nav/remove-left-hand-bar-beta branch from a6f1294 to 32fc713 Compare May 5, 2025 07:26

mountiny approved these changes May 5, 2025

View reviewed changes

mountiny merged commit 12bb191 into Expensify:main May 5, 2025
16 checks passed

github-actions bot mentioned this pull request May 6, 2025

Deploy Checklist: New Expensify 2025-05-06 #61424

Closed

77 tasks

ikevin127 reviewed May 15, 2025

View reviewed changes

QichenZhu reviewed Jun 4, 2025

View reviewed changes

QichenZhu mentioned this pull request Jun 4, 2025

Hide option 1-10 in onboarding company size selection if user was routed to app via smb #63330

Merged

51 tasks

mountiny mentioned this pull request Jun 4, 2025

[NoQA] Update the can be missing for report nvps in ReportFooter #63449

Merged

51 tasks

Conversation

WojtekBoman commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Apr 29, 2025

Uh oh!

WojtekBoman commented Apr 29, 2025

Uh oh!

dukenv0307 Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Apr 30, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Apr 30, 2025

Uh oh!

WojtekBoman commented Apr 30, 2025

Uh oh!

melvin-bot bot commented Apr 30, 2025

Uh oh!

melvin-bot bot commented Apr 30, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

shawnborton commented Apr 30, 2025

Uh oh!

WojtekBoman commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WojtekBoman commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

WojtekBoman commented May 5, 2025

Uh oh!

Uh oh!

OSBotify commented May 5, 2025

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

pecanoro commented May 6, 2025

Uh oh!

pecanoro commented May 6, 2025

Uh oh!

shawnborton commented May 6, 2025

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

ikevin127 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

WojtekBoman commented Apr 29, 2025 •

edited

Loading

dukenv0307 Apr 30, 2025 •

edited

Loading

WojtekBoman commented Apr 30, 2025 •

edited

Loading

WojtekBoman commented Apr 30, 2025 •

edited

Loading