-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Create create-and-submit-reports.md #61123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://c8879654.helpdot.pages.dev ⚡️ |
|
I stuffed up and fixed the title already |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@marcochavezf @laurenreidexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I relaunched the preview's deploy to include the last change https://c8879654.helpdot.pages.dev/ |
|
@laurenreidexpensify I think this feature is out now, would you be able to review please? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@marcochavezf looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Removed emergency label per this comment #61123 (comment) |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.1.54-0 🚀
|
| 1. Tap the green **➕ Create** button at the bottom of your screen. | ||
| 2. Select **Create report**. | ||
| 3. Choose the workspace for your report: | ||
| - If you're in one workspace, it will be selected automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RachCHopkins can we revert point #3 here? It's not accurate. The only time a workspace selector shows up is when the user has set their personal policy as the default policy accidentally via OldDot AND they have two or more group workspaces, thus we can't guess.
I think it's bette to kill this point entirely.
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.54-7 🚀
|

Explanation of Change
New help doc for new functionality.
Fixed Issues
https://github.com/Expensify/Expensify/issues/473673
Tests
Make sure it looks ok
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined