perf: calculate chat tab brick road based on derived value by TMisiukiewicz · Pull Request #61376 · Expensify/App

TMisiukiewicz · 2025-05-05T13:49:04Z

Explanation of Change

This PR calculates brick road status in navigation bar based on a derived value instead of calculating everything from scratch each time.

Performance comparison:

Environment: Web, 10x CPU throttle

Action performed: Measured getChatTabBrickRoad function which is being fired each time user is switching between navigation tabs, while in "Most recent" mode

Reports	Before	After
178	35ms	0.1ms
3877	63ms	1.3ms

Fixed Issues

$ #59350
$ #60007
PROPOSAL:

Tests

Create an empty account for easier testing
Start new chat
Create task and assign to yourself
Verify the green dot appeared next to "Inbox" in the navigation tab
Create an expense and upload an image that is not a valid receipt
Wait for image to process
Verify the red dot appeared next to "Inbox" in the navigation tab
Remove expense
Verify the green dot appeared next to "Inbox" in the navigation tab
Resolve task
Verify no dots are visible next to "Inbox" in the navigation tab

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

TMisiukiewicz · 2025-05-07T11:50:12Z

src/libs/WorkspacesSettingsUtils.ts

-    }
-    const reportOption = {...report, isUnread: isUnread(report, oneTransactionThreadReport), isUnreadWithMention: isUnreadWithMention(report)};
-    const shouldShowGreenDotIndicator = requiresAttentionFromCurrentUser(reportOption, itemParentReportAction);
-    return shouldShowGreenDotIndicator ? CONST.BRICK_ROAD_INDICATOR_STATUS.INFO : undefined;


This function seems to share the same logic that is used to determine GBR/RBR status for a report in a derived value, so it is safe to simply check the brick road status directly instead of computing it

melvin-bot · 2025-05-07T13:16:44Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

TMisiukiewicz · 2025-05-07T13:17:37Z

cc @hoangzinh you might be interested in reviewing this one as well as you are already familiar with this part

hoangzinh · 2025-05-07T23:32:12Z

@rushatgabhane has been assigned to this issue #60007, so let he handles here, and we can expand knowledge about derived value. But I can always backup if @rushatgabhane is not available.

TMisiukiewicz · 2025-05-09T05:30:21Z

@rushatgabhane friendly bump 🙏

rushatgabhane · 2025-05-09T06:30:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

WhatsApp.Video.2025-05-09.at.08.25.49.mp4

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-05-09.at.08.43.48.mov

iOS: mWeb Safari

Screen.Recording.2025-05-09.at.08.45.44.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-09.at.08.27.50.mov

Screen.Recording.2025-05-09.at.08.26.16.mov

MacOS: Desktop

TMisiukiewicz · 2025-05-09T06:39:03Z

updated with main and removed the console.log I missed before 👀

rushatgabhane · 2025-05-09T06:40:25Z

could you please delete commit that updated the submodule

TMisiukiewicz · 2025-05-09T06:48:57Z

ah my bad, removed, thank you

mountiny

Going to move it ahead but left some NAB comments

mountiny · 2025-05-09T21:36:27Z

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

                dataToIterate = prepareReportKeys(updates);
                recentlyUpdated = updates;
            } else if (!!transactionsUpdates || !!transactionViolationsUpdates) {
+                let transactionReportIds: string[] = [];


Suggested change

let transactionReportIds: string[] = [];

let transactionReportIDs: string[] = [];

I'll update it with one of the following PRs, thanks

mountiny · 2025-05-09T21:37:41Z

src/pages/WorkspaceSwitcherPage/index.tsx

+    const [currentUserLogin] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.email, canBeMissing: true});
+    const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP, {canBeMissing: true});


can these be missing really?

This property is here for a while now but I still find it super confusing. Out of curiosity I just checked the codebase and this key is used 4 times with false and 11 times with true and I can't really say what's the difference. The JSDoc description of this param is not clear to me and based on these numbers I think it might be problematic for more people. Can we do something to improve it? cc @fabioh8010

OSBotify · 2025-05-09T21:58:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-13T18:22:29Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T19:32:54Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-15T19:01:07Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

TMisiukiewicz added 4 commits May 5, 2025 14:16

use derived value in getBrickRoadForPolicy

a25e799

Merge branch 'main' into perf/policy-brick-road-from-derived-value

3c53dea

display proper chat tab brick road

38c86aa

remove unnecessary parameter from getWorkspacesBrickRoads

505f4eb

TMisiukiewicz added 4 commits May 7, 2025 11:20

Merge branch 'main' into perf/policy-brick-road-from-derived-value

2b4a4e6

fix lint-changed

0409460

fix BottomTabBarTest

3dbf452

fix WorkspaceSettingUtilsTest

a02f0e5

TMisiukiewicz commented May 7, 2025

View reviewed changes

TMisiukiewicz marked this pull request as ready for review May 7, 2025 13:16

TMisiukiewicz requested a review from a team as a code owner May 7, 2025 13:16

melvin-bot bot requested review from rushatgabhane and removed request for a team May 7, 2025 13:16

TMisiukiewicz mentioned this pull request May 7, 2025

perf: move report brick road statuses to a derived value #60827

Merged

51 tasks

TMisiukiewicz mentioned this pull request May 8, 2025

perf: use requiresAttentionFromCurrentUser from a derived value #61586

Merged

51 tasks

rushatgabhane approved these changes May 9, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny May 9, 2025 06:35

Merge branch 'main' into perf/policy-brick-road-from-derived-value

1426552

remove console log

70ee8ea

TMisiukiewicz force-pushed the perf/policy-brick-road-from-derived-value branch from 0155fb6 to 70ee8ea Compare May 9, 2025 06:48

TMisiukiewicz mentioned this pull request May 9, 2025

perf: use getAllReportErrors from a derived value #61772

Merged

51 tasks

mountiny assigned TMisiukiewicz May 9, 2025

mountiny approved these changes May 9, 2025

View reviewed changes

mountiny merged commit 22f539c into Expensify:main May 9, 2025
17 checks passed

github-actions bot mentioned this pull request May 13, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

mitarachim mentioned this pull request May 14, 2025

mweb - LHN - Hidden chat displayed on LHN when delete failed scan request #61968

Closed

8 tasks

	let transactionReportIds: string[] = [];
	let transactionReportIDs: string[] = [];

		const [currentUserLogin] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.email, canBeMissing: true});
		const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP, {canBeMissing: true});

Conversation

TMisiukiewicz commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Performance comparison:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

TMisiukiewicz May 7, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 7, 2025

Uh oh!

TMisiukiewicz commented May 7, 2025

Uh oh!

hoangzinh commented May 7, 2025

Uh oh!

TMisiukiewicz commented May 9, 2025

Uh oh!

rushatgabhane commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

TMisiukiewicz commented May 9, 2025

Uh oh!

rushatgabhane commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TMisiukiewicz commented May 9, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny May 9, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz May 12, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny May 9, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz May 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 9, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TMisiukiewicz commented May 5, 2025 •

edited

Loading

rushatgabhane commented May 9, 2025 •

edited

Loading

rushatgabhane commented May 9, 2025 •

edited

Loading