fix: Error in archived task Set up categories by truph01 · Pull Request #61393 · Expensify/App

truph01 · 2025-05-05T19:08:36Z

Explanation of Change

Fixed Issues

$ #61006
PROPOSAL: #61006 (comment)

Tests

Go to ND
Log in with a new Gmail account (don't use + account).
Click Skip on work email step.
Select Manage my team's expenses.
Select 1-10 employees > Continue.
Select any accounting software > Continue.
Go to Account > Workspaces.
Delete the workspace.
Create a new workspace.
Go to workspace settings > Categories.
Disable any category.
Note that there is task complete sound in the background after disabling the category.
Go back to Inbox.
Open the task report "Set up categories".
Verify: The task report "Set up categories" should not be marked when the original workspace is deleted and category in another workspace is disabled.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-06.at.13.48.33.mov

Android: mWeb Chrome

Screen.Recording.2025-05-06.at.13.50.38.mov

iOS: Native

Screen.Recording.2025-05-06.at.14.05.57.mov

iOS: mWeb Safari

Screen.Recording.2025-05-06.at.13.54.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-06.at.12.52.24.mov

MacOS: Desktop

Screen.Recording.2025-05-06.at.12.52.24.mov

melvin-bot · 2025-05-06T07:08:05Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2025-05-06T07:24:44Z

@truph01 Do you think we should write automate test to avoid this bug in the future 🤔

truph01 · 2025-05-06T07:27:10Z

@hungvu193 Sure. I am on it now.

hungvu193 · 2025-05-06T07:27:56Z

Cool 😄

truph01 · 2025-05-06T07:49:49Z

@hungvu193 I added the test. PR is ready to review

hungvu193 · 2025-05-06T11:11:53Z

tests/actions/TaskTest.ts

This task is failing on local for me, can you take a look 👀 ?

@hungvu193 Could you help run the test again?

Tests passed!

hungvu193 · 2025-05-07T08:41:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-07.at.16.23.28.mov

Android: mWeb Chrome

mAndroidChrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-07.at.15.37.13.mov

MacOS: Desktop

Screen.Recording.2025-05-07.at.15.40.09.mov

robertjchen

thanks!

OSBotify · 2025-05-07T12:37:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-08T00:17:13Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.1.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

tgolen · 2025-05-08T17:34:31Z

tests/actions/TaskTest.ts

+            await Onyx.set(`${ONYXKEYS.NVP_INTRO_SELECTED}`, {choice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM, setupCategories: taskReport.reportID});
+            await waitForBatchedUpdates();
+        });
+        it('Return not empty object', () => {


Hi, just dropping in here, but can you please be more descriptive with the test names or comments? From looking at this test (and the one below), I have no context to understand why an empty or a non-empty object would be expected.

@tgolen Should I create a follow-up PR to add a more descriptive explanation for the test?

github-actions · 2025-05-09T09:27:41Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.1.43-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T17:53:24Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: Error in archived task Set up categories

15406ed

truph01 marked this pull request as ready for review May 6, 2025 07:08

truph01 requested a review from a team as a code owner May 6, 2025 07:08

melvin-bot bot requested review from hungvu193 and removed request for a team May 6, 2025 07:08

fix: add test

b8142ec

hungvu193 reviewed May 6, 2025

View reviewed changes

fix: merge main

197204e

hungvu193 approved these changes May 7, 2025

View reviewed changes

melvin-bot bot requested a review from robertjchen May 7, 2025 09:26

robertjchen approved these changes May 7, 2025

View reviewed changes

robertjchen merged commit 9400495 into Expensify:main May 7, 2025
20 of 22 checks passed

github-actions bot mentioned this pull request May 7, 2025

Deploy Checklist: New Expensify 2025-05-07 #61626

Closed

90 tasks

tgolen reviewed May 8, 2025

View reviewed changes

melvin-bot bot mentioned this pull request May 13, 2025

[Due for payment 2025-05-20] [$250] Error in archived task "Set up categories" when disabling category in another workspace #61006

Closed

8 tasks

Conversation

truph01 commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 6, 2025

Uh oh!

hungvu193 commented May 6, 2025

Uh oh!

truph01 commented May 6, 2025

Uh oh!

hungvu193 commented May 6, 2025

Uh oh!

truph01 commented May 6, 2025

Uh oh!

hungvu193 May 6, 2025

Choose a reason for hiding this comment

Uh oh!

truph01 May 7, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 May 7, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertjchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 7, 2025

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

tgolen May 8, 2025

Choose a reason for hiding this comment

Uh oh!

truph01 May 13, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

truph01 commented May 5, 2025 •

edited

Loading

hungvu193 commented May 7, 2025 •

edited

Loading